From patchwork Tue Jul 11 07:24:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 118296 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp304582vqm; Tue, 11 Jul 2023 00:37:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlEQOzMwWuXNIyEIK1iKWZxir1m28NVbAJQCpAKc3IbiwHn0q3jB6WImlpBTgzs+ibj+sKKO X-Received: by 2002:a05:6a00:cce:b0:682:537f:2cb8 with SMTP id b14-20020a056a000cce00b00682537f2cb8mr19401289pfv.26.1689061061456; Tue, 11 Jul 2023 00:37:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689061061; cv=none; d=google.com; s=arc-20160816; b=s/7Ah5wqom/bcIeYdsZ+uizyNo70XOenwQmhGmTKkBS0+r86MA4dsMiE+AS2cUPmBB t5ISGCRyYP5jhIRUvkrOz+N+AjYfoygJ1kJLX8mSNy1UWUDOD/GlBbb3S77y9c2UUp/A pQCBnNXtlD/H0bFNuLHOIvn7YB3G7gdWFV2sRG39+qfzj4A/c+Jf8/TXU7m0wVJnycTx 1RvZ9H9gushjVSSX4sI/AYDpQ0ETcf+p7SkN+jVDYHcVMswOuLWBQgFWk1sT2yX8zSEz 8iqpHqe+r+lBgo66IJ+TKqQZLU2pl01YS6PHWn9u/6jCbwZriem8/lBIOZ08gkQCnWOE 3XfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; fh=/ZRLvkebetfKh0NzHUcqCbftKGh4+cMFY3HmwXGCxv0=; b=A2I45O36weojsMdRhdVMndok9Tfp/cuV606vXEIdfQJ/aoaamdWNDlJlMZSPnMyIlR 6arK181OQuOl9/VQ3nT1Q1uxDO7h1NgSvIlAg4Q4z78HlkoLfPJ0xns+fX1rhUVoGztW pWo5Uz5YreofK8N6lutxkOSBGExMmGkDdgHA1TRefEyfHO4apacb7/MzaqNqctOk02Eo NopH8V7Lr6cD5J9E7HLdtlhdsiA7fnlA7BUKbOLoc9FQVQBEo+4PXm6Vlau143pi4UoQ JuYsZJHmeL8e+9/2nNOgwqq4SfLt3WXOi96Is6wGwh7d+s1FVuh2uDTbEbkS7NjNboSz bh2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/rnDHmJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a056a00170900b006825e2dba5fsi1058210pfc.258.2023.07.11.00.37.28; Tue, 11 Jul 2023 00:37:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/rnDHmJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbjGKHZk (ORCPT + 99 others); Tue, 11 Jul 2023 03:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231229AbjGKHZV (ORCPT ); Tue, 11 Jul 2023 03:25:21 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6037F10FC for ; Tue, 11 Jul 2023 00:24:54 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-992b27e1c55so654671066b.2 for ; Tue, 11 Jul 2023 00:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689060293; x=1691652293; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; b=L/rnDHmJ17PrZ5VqsKFLoRY5xluqgw+zr1cfhGvQnDJOiTjjm3ZKrbthIu92zrNhtd LFz2HnEVPcrMPENKFYUN1Qk4d6GlmzlZIbAHHMEbdBjRlnL0gBpFfXhVyqSXWOJDY0JP s//q0nNhOH2xisfAUaLjIv9Rq6O62BwJSxzZ+ow7QBBrrlmfN0mlw3TaXkudJg9ZmgbL Nw1M0l4dh/fgJL2tlgt8pu9r+cDUCtMxCBNgkorKjNz4dJO1coQoZaYyqQWaXd/1K9s3 ZHmdTSQNiM6amY6qouOiefTLhOThom7akyZv+OewUokTWfgjCO7LPkMjI/m1pMVOlUpr eBBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689060293; x=1691652293; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; b=HxTX/+v3WIAlD83kupFW0s5esQ/3i6LU0RJhf5Zq3O+yRvGqDo+/gpBy9s96a+fWhS 8lvOhACurZBL/Q2gc5fsYNWySNiIO0dA5w7y68rUpISKSdZ1qfx1nczP0BW47lS4juI6 YbElp2eA6iqRa7KYEcRuWa6LjKbB622NJgDZe/G20SyMcaoMWEO32wJo3VGbXlSMfR1c /1wRilFoLpIpMjG2F+UqOhCi1Bz0CB8xwLPSthWlBm+hFCLD+HIn6zQ8XrwTfHaRSL4/ BaF1Ho/zV7UH5MY4Anql703c9zI+jiyqWL5ouk8qEU6lbJpskC3R5RjOmFb4lqRQwNb5 akfA== X-Gm-Message-State: ABy/qLa2+nlzfIQv36BbjmDsBhAvEzqMmooioJCyblBU5ywo2TKl18aQ i2iChhn4Vn2pPR1i2jWM2MkHcg== X-Received: by 2002:a17:906:f1d0:b0:992:527:8466 with SMTP id gx16-20020a170906f1d000b0099205278466mr12774296ejb.76.1689060292724; Tue, 11 Jul 2023 00:24:52 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id se18-20020a170906ce5200b0099329b3ab67sm763758ejb.71.2023.07.11.00.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 00:24:52 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Krzysztof Kozlowski , Hans de Goede , Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel test robot , Dan Carpenter Subject: [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error Date: Tue, 11 Jul 2023 09:24:49 +0200 Message-Id: <20230711072449.43569-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771108891485632240 X-GMAIL-MSGID: 1771108891485632240 Pass proper PTR_ERR as dev_err_probe() argument. Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/ Signed-off-by: Krzysztof Kozlowski --- drivers/input/keyboard/bcm-keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c index 05b09066df84..bcc480ff7c3b 100644 --- a/drivers/input/keyboard/bcm-keypad.c +++ b/drivers/input/keyboard/bcm-keypad.c @@ -367,7 +367,7 @@ static int bcm_kp_probe(struct platform_device *pdev) /* Enable clock */ kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk"); if (IS_ERR(kp->clk)) { - return dev_err_probe(&pdev->dev, error, "Failed to get clock\n"); + return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n"); } else if (!kp->clk) { dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n"); } else {