From patchwork Tue Jul 11 07:22:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 118295 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp303911vqm; Tue, 11 Jul 2023 00:35:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlEG/5qYVtF6UmWxp/+HOfEV7ETJ5EDIEmIyIvJ/yxwAYelRbY12PNwedWY8VZBt7nxarV/N X-Received: by 2002:a17:903:2307:b0:1b9:e97f:3846 with SMTP id d7-20020a170903230700b001b9e97f3846mr3676810plh.15.1689060954599; Tue, 11 Jul 2023 00:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689060954; cv=none; d=google.com; s=arc-20160816; b=rNfUgUbmquXHaoZMjrUKeUCFdWJ/y5EX99JyAypoqgWOk8gvbcfonTZEeTpZDagBjv Ti432Cqm7Mpp2W/y51irldigFbmlGjHBQOgVDkIlMo4RNtEzwu2iAeCEr7Xd29rXnRPa xvXoLCn8zxh2/yxFrsaIDkOwG9jonKvQzfrvs8nSGw7pP94V1bR4lIE2M/FW9iWWPddd sBOHRAJ2wi9ocqWLawxGhB+60G5lVjsqdIGmNpTaPiT+aE26q+oemUqbqWIoTPGqIGDB URI5XA6Q8CDXN8jzRSgMd5rTrMTjf46vCoA9RnBNHKyK/tgrhLhFEwL9rE1XQY+kVYIq d/iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; fh=UwhUFQz32apRHcW3OwXhQdCRiAbC1ByGuwVLU9rR3FY=; b=znvXg56Wy4d18IL96DBmZyWTzgFjyba2JczxdAWAwKDZaAqAk2xZyO8ey5CW8JS1QA ycJGSKpUhEq8pQcjFudm8QtqOLvaWtHCT9uiVsg0dBV7HyQhfUbs4B7TTS1MNmyWZAV9 cGpoIXfiRjcAruXcxTLmb0jvj7lO+2EZtL4jgLej5YFYNzRbo21AGI3mYXlVVeDf3IE/ KslcbYVcHwEcvOQ9Dcl5k0xPUcz8JOMMSOaMTTD2gtE/dllPJ4sgGL0Vak/trnFWHVlO KIptriYQXjl9G89DHVhgghTiA7UdKIrmCosw+6+sLLhn7xI4g8rS0FPLOM85deL56+Zq iKnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hSpwGle+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p22-20020a170902a41600b001b3d822f131si1118940plq.239.2023.07.11.00.35.41; Tue, 11 Jul 2023 00:35:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hSpwGle+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjGKHXE (ORCPT + 99 others); Tue, 11 Jul 2023 03:23:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbjGKHXA (ORCPT ); Tue, 11 Jul 2023 03:23:00 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 833E1F4 for ; Tue, 11 Jul 2023 00:22:59 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-51e5da802afso1745858a12.3 for ; Tue, 11 Jul 2023 00:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689060178; x=1691652178; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; b=hSpwGle+ZQfU776LqBuG5WKZL1ooIzVolRu95jd9gzB9yWUPn5A/Yx5xzlNDZ/bRyd iiNZuHUGzzuy2d5QXEKYrNPaiHuRwIafz3XD3grKJkAnVkknDeIOUoaVTJKv2TxzPKlI ufaUarNX3hv1wjn483bDlima3EpBJtIfKkZQBnsLNytko8B/KRExl0Dw+2Oo2OwBNqXS cC27LtUhqtvOCsx0FiD84u4jx/C14wbAvQCmU9lz/f1Z7PEBq9Hae0FWsUi0mmEZ5plq 2lNsKVLY1MLo/lFDoTNlj/uTIkAKGB6JvmeSAfPFlEFCKJTLddXX2I8rU+r2+7tp6UIP Xd/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689060178; x=1691652178; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ldbk7xLpFOB3wCnK+tsupp7O8c/p1x/Bm1IetfW9AlI=; b=HkoffE7L4knV2wlDgOK8a+r1ArTyn78X/h5N39bYA0rt0/0/1FXkLE5AHFwYdiX5AT kETuJSon4RhADfd6/Bv2p7wu8W1NmJZD/eoA7wSDhP8Si4uMTKJn9vMhr4s2T/Hic1/4 6SdmRb+iu6FdqUP1pXsBkF7mefuTtporu+tECvMrm7Fl1/Q6NCUtmpXm9zbJMTvjS9tb +4FeuaEMAewX27dIlYgF6/qBq3e0tCd5ihAqU5x9+f9fR3d2LYrDvHRn1Guo9z31Kz2P fyxMIq/DBXLcc/m1JpUB5IMTTA3374xWVA31NCnnH92723Ni+Z3mJ/789PrxBqHhv28D 3VzA== X-Gm-Message-State: ABy/qLabJqvmcvJSi4oqmQN4AMC233h7oaLC+NQnVgvYqFKb2V08LSQD NsK5CFbn396DnNGRDnZeHfvL9g== X-Received: by 2002:a17:906:d965:b0:992:6064:f32b with SMTP id rp5-20020a170906d96500b009926064f32bmr14606261ejb.46.1689060177838; Tue, 11 Jul 2023 00:22:57 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id t23-20020a1709066bd700b00992025654c1sm752588ejs.179.2023.07.11.00.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 00:22:57 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Hans de Goede , Krzysztof Kozlowski , Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel test robot , Dan Carpenter Subject: [PATCH] fix Input: bcm-keypad - Correct dev_err_probe() error Date: Tue, 11 Jul 2023 09:22:54 +0200 Message-Id: <20230711072254.43273-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771108779359573035 X-GMAIL-MSGID: 1771108779359573035 Pass proper PTR_ERR as dev_err_probe() argument. Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/ Signed-off-by: Krzysztof Kozlowski --- drivers/input/keyboard/bcm-keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c index 05b09066df84..bcc480ff7c3b 100644 --- a/drivers/input/keyboard/bcm-keypad.c +++ b/drivers/input/keyboard/bcm-keypad.c @@ -367,7 +367,7 @@ static int bcm_kp_probe(struct platform_device *pdev) /* Enable clock */ kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk"); if (IS_ERR(kp->clk)) { - return dev_err_probe(&pdev->dev, error, "Failed to get clock\n"); + return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n"); } else if (!kp->clk) { dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n"); } else {