| Message ID | 20230710233132.69734-1-contact@artur-rojek.eu |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp155137vqm;
Mon, 10 Jul 2023 17:20:49 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlEZ5CWB14J2mKIr/eZvpRHnH7ZoLPZ8E2+ZxfNW7iE1S2KufUoIJZfiNh5dY7BnWI1+tj+X
X-Received: by 2002:a05:6a20:c1:b0:12d:cf29:b75d with SMTP id
1-20020a056a2000c100b0012dcf29b75dmr13056442pzh.18.1689034849234;
Mon, 10 Jul 2023 17:20:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689034849; cv=none;
d=google.com; s=arc-20160816;
b=HUps8CuWy/JTNbKAjQwPhr/JkjSmMp/zm7vmYriA0QbSvYZXENaTCmEag5JT6AIRtf
Foz4rO1hu3CAtSNxqI97ZskfHW+l4GT1Evj9v6mTKodaDyLz/5aHoTxfeKI7d/7V6G3J
u//DMvT5t6gc1OiY+qSFP4wu49q9wf102yWJsubqJ1JVJCUIGIo12kJQznIauSK1sp7d
TalEpG99QyiIQsTVJZIuqDuo/+O0BiT5UQMreZl/ds1qDDq2+mUzrQ3ng5BLU7LgfsB4
9HZH2buW6ML0Zqtf10fnTwV/AlmZebIY7NTn7s1niXCJkt4VzBvsjS+/+F1NFI7MEErW
uGyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=Kzd224aMs8aAhxcthHoDC1ggJwIikzjdzwZVavG7TQ0=;
fh=CK2X9NDbJ2GbZjj4R6MU//wO8avdZJvKObbH4r0yj/w=;
b=i6fquUDustawcF8GWyEOSn89OuUwfviI0dR0s6dGQhhrXF2kWu3YCz6AjEuj4Y7kkc
kE7s+wvRDDWoxFzGHRC8Sj8R5qv43qzvRQHMhuR7z8S2bBHRcFxqSxjNh6i9c3j0fhBx
lWHTfqwM1j+tMZ1ff57HAq9ISJpO2wMTspzuNgPjqPei1UYn3Gh6jMogcyR9zy5uEDGT
/AeFBsm9hbVlkbc4EaxoB72OQCMVaGxKfy5B8jrhkkjaCOccNhTN83543E4bgiyxx7uH
ijW+MNVSmn0LnWzK2Z2QK6sASKGc/mNfRoIjvEuhd8nJvYOdCUCqBDFxvvB4544QViXO
tDeg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x14-20020a63170e000000b005574c3ac68dsi440785pgl.493.2023.07.10.17.20.34;
Mon, 10 Jul 2023 17:20:49 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231276AbjGJXb4 (ORCPT <rfc822;gnulinuxfreebsd@gmail.com>
+ 99 others); Mon, 10 Jul 2023 19:31:56 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55246 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229581AbjGJXbx (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 10 Jul 2023 19:31:53 -0400
Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net
[IPv6:2001:4b98:dc4:8::228])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C69CA0;
Mon, 10 Jul 2023 16:31:51 -0700 (PDT)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 3FDA21BF204;
Mon, 10 Jul 2023 23:31:47 +0000 (UTC)
From: Artur Rojek <contact@artur-rojek.eu>
To: Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Artur Rojek <contact@artur-rojek.eu>
Subject: [PATCH v2] sh: hd64461: fix virq offsets
Date: Tue, 11 Jul 2023 01:31:32 +0200
Message-ID: <20230710233132.69734-1-contact@artur-rojek.eu>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-GND-Sasl: contact@artur-rojek.eu
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1770947394861698542
X-GMAIL-MSGID: 1771081405902506716
|
| Series |
[v2] sh: hd64461: fix virq offsets
|
|
Commit Message
Artur Rojek
July 10, 2023, 11:31 p.m. UTC
A recent change to start counting SuperH IRQ #s from 16 breaks support
for the Hitachi HD64461 companion chip.
Move the offchip IRQ base and HD64461 IRQ # by 16 in order to
accommodate for the new virq numbering rules.
Fixes: a8ac2961148e ("sh: Avoid using IRQ0 on SH3 and SH4")
Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
---
v2: Make the IRQ base offset an explicit (64 + 16), as per review.
arch/sh/cchips/Kconfig | 4 ++--
arch/sh/include/asm/hd64461.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Tue, Jul 11, 2023 at 1:31 AM Artur Rojek <contact@artur-rojek.eu> wrote: > A recent change to start counting SuperH IRQ #s from 16 breaks support > for the Hitachi HD64461 companion chip. > > Move the offchip IRQ base and HD64461 IRQ # by 16 in order to > accommodate for the new virq numbering rules. > > Fixes: a8ac2961148e ("sh: Avoid using IRQ0 on SH3 and SH4") > Signed-off-by: Artur Rojek <contact@artur-rojek.eu> > --- > > v2: Make the IRQ base offset an explicit (64 + 16), as per review. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Tue, 2023-07-11 at 01:31 +0200, Artur Rojek wrote: > A recent change to start counting SuperH IRQ #s from 16 breaks support > for the Hitachi HD64461 companion chip. > > Move the offchip IRQ base and HD64461 IRQ # by 16 in order to > accommodate for the new virq numbering rules. > > Fixes: a8ac2961148e ("sh: Avoid using IRQ0 on SH3 and SH4") > Signed-off-by: Artur Rojek <contact@artur-rojek.eu> > --- > > v2: Make the IRQ base offset an explicit (64 + 16), as per review. > > arch/sh/cchips/Kconfig | 4 ++-- > arch/sh/include/asm/hd64461.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/sh/cchips/Kconfig b/arch/sh/cchips/Kconfig > index efde2edb5627..9659a0bc58de 100644 > --- a/arch/sh/cchips/Kconfig > +++ b/arch/sh/cchips/Kconfig > @@ -29,9 +29,9 @@ endchoice > config HD64461_IRQ > int "HD64461 IRQ" > depends on HD64461 > - default "36" > + default "52" > help > - The default setting of the HD64461 IRQ is 36. > + The default setting of the HD64461 IRQ is 52. > > Do not change this unless you know what you are doing. > > diff --git a/arch/sh/include/asm/hd64461.h b/arch/sh/include/asm/hd64461.h > index afb24cb034b1..d2c485fa333b 100644 > --- a/arch/sh/include/asm/hd64461.h > +++ b/arch/sh/include/asm/hd64461.h > @@ -229,7 +229,7 @@ > #define HD64461_NIMR HD64461_IO_OFFSET(0x5002) > > #define HD64461_IRQBASE OFFCHIP_IRQ_BASE > -#define OFFCHIP_IRQ_BASE 64 > +#define OFFCHIP_IRQ_BASE (64 + 16) > #define HD64461_IRQ_NUM 16 > > #define HD64461_IRQ_UART (HD64461_IRQBASE+5) Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
On Tue, 2023-07-11 at 01:31 +0200, Artur Rojek wrote: > A recent change to start counting SuperH IRQ #s from 16 breaks support > for the Hitachi HD64461 companion chip. > > Move the offchip IRQ base and HD64461 IRQ # by 16 in order to > accommodate for the new virq numbering rules. > > Fixes: a8ac2961148e ("sh: Avoid using IRQ0 on SH3 and SH4") > Signed-off-by: Artur Rojek <contact@artur-rojek.eu> > --- > > v2: Make the IRQ base offset an explicit (64 + 16), as per review. > > arch/sh/cchips/Kconfig | 4 ++-- > arch/sh/include/asm/hd64461.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/sh/cchips/Kconfig b/arch/sh/cchips/Kconfig > index efde2edb5627..9659a0bc58de 100644 > --- a/arch/sh/cchips/Kconfig > +++ b/arch/sh/cchips/Kconfig > @@ -29,9 +29,9 @@ endchoice > config HD64461_IRQ > int "HD64461 IRQ" > depends on HD64461 > - default "36" > + default "52" > help > - The default setting of the HD64461 IRQ is 36. > + The default setting of the HD64461 IRQ is 52. > > Do not change this unless you know what you are doing. > > diff --git a/arch/sh/include/asm/hd64461.h b/arch/sh/include/asm/hd64461.h > index afb24cb034b1..d2c485fa333b 100644 > --- a/arch/sh/include/asm/hd64461.h > +++ b/arch/sh/include/asm/hd64461.h > @@ -229,7 +229,7 @@ > #define HD64461_NIMR HD64461_IO_OFFSET(0x5002) > > #define HD64461_IRQBASE OFFCHIP_IRQ_BASE > -#define OFFCHIP_IRQ_BASE 64 > +#define OFFCHIP_IRQ_BASE (64 + 16) > #define HD64461_IRQ_NUM 16 > > #define HD64461_IRQ_UART (HD64461_IRQBASE+5) Applied to my for-linus branch. Thanks, Adrian
diff --git a/arch/sh/cchips/Kconfig b/arch/sh/cchips/Kconfig index efde2edb5627..9659a0bc58de 100644 --- a/arch/sh/cchips/Kconfig +++ b/arch/sh/cchips/Kconfig @@ -29,9 +29,9 @@ endchoice config HD64461_IRQ int "HD64461 IRQ" depends on HD64461 - default "36" + default "52" help - The default setting of the HD64461 IRQ is 36. + The default setting of the HD64461 IRQ is 52. Do not change this unless you know what you are doing. diff --git a/arch/sh/include/asm/hd64461.h b/arch/sh/include/asm/hd64461.h index afb24cb034b1..d2c485fa333b 100644 --- a/arch/sh/include/asm/hd64461.h +++ b/arch/sh/include/asm/hd64461.h @@ -229,7 +229,7 @@ #define HD64461_NIMR HD64461_IO_OFFSET(0x5002) #define HD64461_IRQBASE OFFCHIP_IRQ_BASE -#define OFFCHIP_IRQ_BASE 64 +#define OFFCHIP_IRQ_BASE (64 + 16) #define HD64461_IRQ_NUM 16 #define HD64461_IRQ_UART (HD64461_IRQBASE+5)