From patchwork Mon Jul 10 20:27:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 118071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp57882vqm; Mon, 10 Jul 2023 13:34:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGt1lZRIV4BVXnJ1PegsdkVaoglIZsnw3IJwJOPR4XdBlq9XWRX/qxdIy9cl2uPyAMFESo8 X-Received: by 2002:a05:6a20:54a6:b0:12d:346f:d8ac with SMTP id i38-20020a056a2054a600b0012d346fd8acmr17493303pzk.44.1689021286962; Mon, 10 Jul 2023 13:34:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689021286; cv=none; d=google.com; s=arc-20160816; b=DI9MZBgqo7leX5cKAqJZaKl/fcnSCTCo4l4A7kgup7TdtSCzegISAnkgvet0xT6pxX v7/p03PwVTqhOK270SAahqlyruySUE2tEkYolywW3VCSrcM8uaP/pKVjcXtgwXrDEiub 9s+2IWNIpsHsX5FxGuhGw3Ad+kqyBx60VeDjwKTh7qvcoutHrByUG5WTQ0NG2uXzBgk7 pj5HFF/z5WAVWGfdTuTdyFWV6GyQgWcD0MmkylBkzaFyxjUZkT3nGpP4HENorZMzLDTk HZ8nDvGoZIlWd0mcPpXZzPjmQoU/HKEiw/eUzaMUdIy6rLrvYEvpxJzVup9bEWxThc0X cY1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NGagndghDOkiNn3CGVhgbcZSeOY+UYy66oNmW3rStuk=; fh=GUQwZ7uCW3sOebrGSFJwPRX8di32vmIzxh/oFyyWwpA=; b=BypYPBpUjCB5sKXKajhvTnk/MjBI0dO9IQq+GAK+XmH2GRQfyx6nfaLGORJer3jbM+ R3pRUS7FVxs6L7xZvXpJhz8OO8RXqokyw440cL3Cxl1xR/KzGb/gaFrdtpgamfCqHKq1 P2GbWH1xyZf58Bzm2Yk8kDAR3jgPMXpumFNrlANsQUFpZotyDzjXrwCCweE5+HlSWrGg qwvCZ5qQEMd/3qYHXj2Oi8nkbNCK++RGMAr2RV9G5p0yuFKwDWJSM4KQh/D3WSzCzibt sncydSy+RUuYzl2G1JAXx52r6EEiApcYPS/kS1DH6ePDKrY4I1tJHl3jlgyV7g1rs/d8 lp0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m190-20020a6326c7000000b0053ff537164fsi154163pgm.783.2023.07.10.13.34.33; Mon, 10 Jul 2023 13:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbjGJU3q (ORCPT + 99 others); Mon, 10 Jul 2023 16:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbjGJU3e (ORCPT ); Mon, 10 Jul 2023 16:29:34 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2642195; Mon, 10 Jul 2023 13:29:29 -0700 (PDT) Received: from 250.57.4.146.static.wline.lns.sme.cust.swisscom.ch ([146.4.57.250] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1qIxVf-0002mg-1g; Mon, 10 Jul 2023 22:29:27 +0200 From: Martin Kaiser To: Herbert Xu Cc: aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/7] hwrng: ingenic - remove dead assignments Date: Mon, 10 Jul 2023 22:27:29 +0200 Message-Id: <20230710202733.116133-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230710202733.116133-1-martin@kaiser.cx> References: <20230710202733.116133-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771067185289474168 X-GMAIL-MSGID: 1771067185289474168 Don't assign a value to ret if we're about to return from the probe function and ret's value is not used. Signed-off-by: Martin Kaiser --- drivers/char/hw_random/ingenic-trng.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/hw_random/ingenic-trng.c b/drivers/char/hw_random/ingenic-trng.c index 64286cbdf158..bfec28ceab00 100644 --- a/drivers/char/hw_random/ingenic-trng.c +++ b/drivers/char/hw_random/ingenic-trng.c @@ -86,13 +86,11 @@ static int ingenic_trng_probe(struct platform_device *pdev) trng->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(trng->base)) { pr_err("%s: Failed to map DTRNG registers\n", __func__); - ret = PTR_ERR(trng->base); return PTR_ERR(trng->base); } trng->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(trng->clk)) { - ret = PTR_ERR(trng->clk); pr_crit("%s: Cannot get DTRNG clock\n", __func__); return PTR_ERR(trng->clk); }