From patchwork Mon Jul 10 12:50:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 117903 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp5008426vqx; Mon, 10 Jul 2023 06:04:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlE9Jt3lIARDMx5XPapKZcK5reSFm8XulM0gs4RBtU9Z0jJRexzSfSssOVhViwdd4+9uK/pS X-Received: by 2002:a17:906:1114:b0:978:a186:464f with SMTP id h20-20020a170906111400b00978a186464fmr12278736eja.39.1688994263824; Mon, 10 Jul 2023 06:04:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688994263; cv=none; d=google.com; s=arc-20160816; b=j6ItiQ5R2XG0Sm5hmRZlI8frA9oBMD0Oe++vPmb63Q458WblmsNYfJTITVEBCsMcmi 0b9jbFITnBhawlerRfaTvhHDyMaXER0rjcb+MWTEmTGq6DPa7qdeVxEu8+h0cjmmJ+YY Frk1dWK4dw8OxccWPMZ7+l+HF/hktkwkb59OTUUhw7dO/T5ifSSVmU7cboNh5YJzkF/7 FqUEebA6oJXjR69uZznuROw12DyqA9Fm4XlRSIGhfbSHzBq1fFp7vu5jEpDGSe7rGT3K 2QkN5crxaRGmYOXZ4d7d+YIX8KL9xnNXgoCwksCds5oXHxWadDs+5XMyALYUrsXQu4sz CPeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=XpZigZ9QJ+n7ylV5T+Stsnt87sT8wINy/LxbzKCLjCc=; fh=17YvZgVzGG5ZS7L4kfN74vr1MJLFQn7Kam4U1irxq8g=; b=fwFXs/hWF3RnsqHPbk9suyt+Ryg9oCdVshKt9ihFYUNx2Sf/kXbe7D6nO8W2PIyKzw gVB5tmfFxG/mgDMj+qVFF4of7i+6u+xaP0hWlmS9y7bndW43D9bPtpEVZKvPVNRPV47R 3r0LKLncu1eABT5UlDT2uj7f1ec5OtGPTeXZ2DJhkIs5auj3jFdJY+wf5XL/Gc5RBcHn 6Ti/bwKCOryb0VJyZiPA04xMG88M3KdFCdI+HhjWbMTDes8NE94p5WnGFLcl0h1bPoYz HQrcgOEtDTX/LZK/mBLyJ+C2JNdUm9iIokYeCEC4cRoVOrRyIpzvlhaIZV3sBr79Ta8Z 0g8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="m9ixm/VN"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a170906948600b0099279210462si8659429ejx.960.2023.07.10.06.03.58; Mon, 10 Jul 2023 06:04:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="m9ixm/VN"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230351AbjGJNBi (ORCPT + 99 others); Mon, 10 Jul 2023 09:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbjGJNBW (ORCPT ); Mon, 10 Jul 2023 09:01:22 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F9B120; Mon, 10 Jul 2023 06:01:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C6F8221BC; Mon, 10 Jul 2023 13:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688994076; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XpZigZ9QJ+n7ylV5T+Stsnt87sT8wINy/LxbzKCLjCc=; b=m9ixm/VNbqK2unhWLlt2Li87FbE6AzqZWNuZDhHfdK8m2l8wIT6w1Ybg36pIf9qD1mYJ4o 5OFGea/pZxvlL7ubg5WVLxfsl1ZQBdYBld3SeVRDMd23jLp+M2ygmvHPiDDrogZeksYCS3 zcm23zqF4XRNforZpfkkAHGCl/rs57c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688994076; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XpZigZ9QJ+n7ylV5T+Stsnt87sT8wINy/LxbzKCLjCc=; b=vzK3DorasbKCLRFK6Uh+uvHjMCakgDF9fW7SPfJOfZVaCi4Cp0xTXsdME46waVbLdCleqQ 3Q9aDgewKG3ZXvBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B65313A05; Mon, 10 Jul 2023 13:01:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GJHACRwBrGTTFAAAMHmgww (envelope-from ); Mon, 10 Jul 2023 13:01:16 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann Subject: [PATCH 04/17] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Date: Mon, 10 Jul 2023 14:50:08 +0200 Message-ID: <20230710130113.14563-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771038782272340081 X-GMAIL-MSGID: 1771038849336729939 The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/pxafb.c | 1 - drivers/video/fbdev/sa1100fb.c | 1 - drivers/video/fbdev/wm8505fb.c | 3 +-- drivers/video/fbdev/xilinxfb.c | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 2a8b1dea3a67..c8c4677d06b4 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -1826,7 +1826,6 @@ static struct pxafb_info *pxafb_init_fbinfo(struct device *dev, fbi->fb.var.vmode = FB_VMODE_NONINTERLACED; fbi->fb.fbops = &pxafb_ops; - fbi->fb.flags = FBINFO_DEFAULT; fbi->fb.node = -1; addr = fbi; diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c index a2408bf00ca0..3d76ce111488 100644 --- a/drivers/video/fbdev/sa1100fb.c +++ b/drivers/video/fbdev/sa1100fb.c @@ -1089,7 +1089,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev) fbi->fb.var.vmode = FB_VMODE_NONINTERLACED; fbi->fb.fbops = &sa1100fb_ops; - fbi->fb.flags = FBINFO_DEFAULT; fbi->fb.monspecs = monspecs; fbi->fb.pseudo_palette = fbi->pseudo_palette; diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c index 10a8b1250103..5833147aa43d 100644 --- a/drivers/video/fbdev/wm8505fb.c +++ b/drivers/video/fbdev/wm8505fb.c @@ -285,8 +285,7 @@ static int wm8505fb_probe(struct platform_device *pdev) fbi->fb.fix.accel = FB_ACCEL_NONE; fbi->fb.fbops = &wm8505fb_ops; - fbi->fb.flags = FBINFO_DEFAULT - | FBINFO_HWACCEL_COPYAREA + fbi->fb.flags = FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_XPAN | FBINFO_HWACCEL_YPAN diff --git a/drivers/video/fbdev/xilinxfb.c b/drivers/video/fbdev/xilinxfb.c index 2aa3a528277f..768a281a8d2c 100644 --- a/drivers/video/fbdev/xilinxfb.c +++ b/drivers/video/fbdev/xilinxfb.c @@ -324,7 +324,6 @@ static int xilinxfb_assign(struct platform_device *pdev, drvdata->info.fix.line_length = pdata->xvirt * BYTES_PER_PIXEL; drvdata->info.pseudo_palette = drvdata->pseudo_palette; - drvdata->info.flags = FBINFO_DEFAULT; drvdata->info.var = xilinx_fb_var; drvdata->info.var.height = pdata->screen_height_mm; drvdata->info.var.width = pdata->screen_width_mm;