From patchwork Mon Jul 10 12:50:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 117904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp5009794vqx; Mon, 10 Jul 2023 06:06:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlEB5Z9y3Nf46U7+CDKKoP+12AwiHlQ399uQDbgfHWegcCelgWiayir0HSH8ubnEsduundF5 X-Received: by 2002:a17:906:116:b0:987:e23f:6d7a with SMTP id 22-20020a170906011600b00987e23f6d7amr12507996eje.25.1688994360145; Mon, 10 Jul 2023 06:06:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688994360; cv=none; d=google.com; s=arc-20160816; b=P3C6h32lMyRJYuUzx3S4oxXz9DLDnpkBXSFMZtCBGJvGppTCXLOJcn0xd1vkolaG8E ptyJrcE4QUfAP3+F2IfGCBgsG6PV3CqykPpoj1sfdiGu6k7cCMiZOM66/wRBtGQWCtYt RxEeieua+6WoZyJdNFq66F+lRr67y9whM8dW9GHOiY01ShkUhhBs1ladfR1qUUuSI8sZ /eWZeqOzmbXdC4HiVGXD4TTexH/kjq++JeWEE8v99GNWaZncSHOECAjuR3eLr/Lsqg/6 2BPLOXG/qD1om2mg9LWn1vdu/vFc68JA5kVyzbXdwEb4fl4eS8oCTGJQyUQXDCydOvHY pfyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=gRUywqxs5a29120EfN3Bn9mdZmuhBJWGIOQrCKZzgUM=; fh=5xlp4VhwWF4/CbtpUhSQrC08KLm7nV5KuWFQPiXioeU=; b=E0z0quamo0nDNW0lQEYWzzhZVEvr1z9sMVDc+6bRfgA9yj4NKceTs77p0KgS6Il425 OtMXsZH1ku+9BenhusA5iUtq/JhZoK5ZGkeX87WjiYx0JCTeTl6FB4EHalsS2cvOP/SE zZNKUpYC7VjCznVMFRcoy1atJPcSCK8Zb9iiCkWyr+f+KMlsmf+wp6SmmmlSP2R1Bmim l+cfCLaWtXd7pJSSrHukZj8MuMym0HWp3lSC20E3aC1a8zYOBGyEh1VVxifRwKm359yv Nhzj1rGbNxFjB+7M8bSXU8BJ6GTE4BV/52xW+dL7uWJBpGiWJhb+9k3etfNZAxnnQozj BjlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=VoO60JR0; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=PThQ3ciL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ja2-20020a170907988200b00992c195ac80si9684067ejc.357.2023.07.10.06.05.35; Mon, 10 Jul 2023 06:06:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=VoO60JR0; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=PThQ3ciL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbjGJNCE (ORCPT + 99 others); Mon, 10 Jul 2023 09:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbjGJNB1 (ORCPT ); Mon, 10 Jul 2023 09:01:27 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A81A4EC; Mon, 10 Jul 2023 06:01:21 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D2DB1FF7D; Mon, 10 Jul 2023 13:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688994080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gRUywqxs5a29120EfN3Bn9mdZmuhBJWGIOQrCKZzgUM=; b=VoO60JR0vkBYYJEfiXCxbto+zB8LminaUWh5RiGEeHNwD6AK72Ls2YONMYilu1NhkZ6XaV IZa+TpEV5wr13aGSMukVpXTcvcVZcdGouOiq2kTZA/6Y8C/KuEv5NfxafZ4fsLYMn2xTf0 IifhIRSVlSJAXstVMXHnhHpWIrvWg8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688994080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gRUywqxs5a29120EfN3Bn9mdZmuhBJWGIOQrCKZzgUM=; b=PThQ3ciLwYhPhcSmsJ7eCkxPJepdaQUYwZw1Qos1hKdfhILaEyy17W+y0NcGj7wVxyKDC+ eJEdJkBM0jXYFxBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A034913A6B; Mon, 10 Jul 2023 13:01:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6NgxJh8BrGTTFAAAMHmgww (envelope-from ); Mon, 10 Jul 2023 13:01:19 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang Subject: [PATCH 12/17] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Date: Mon, 10 Jul 2023 14:50:16 +0200 Message-ID: <20230710130113.14563-13-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771038950198772795 X-GMAIL-MSGID: 1771038950198772795 The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann Cc: Greg Kroah-Hartman Cc: Sudip Mukherjee Cc: Teddy Wang --- drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/sm750fb/sm750.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 3a4abf3bae40..eac1d570f437 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, info->var.transp.offset = 0; info->var.transp.length = 0; - info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; + info->flags = FBINFO_VIRTFB; par = info->par; par->info = info; diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c260f73cf570..79bcd5bd4938 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) info->screen_base = crtc->v_screen; pr_debug("screen_base vaddr = %p\n", info->screen_base); info->screen_size = line_length * var->yres_virtual; - info->flags = FBINFO_FLAG_DEFAULT | 0; /* set info->fix */ fix->type = FB_TYPE_PACKED_PIXELS;