From patchwork Mon Jul 10 10:27:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 117827 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp4925397vqx; Mon, 10 Jul 2023 03:33:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlFsfVnpWIAPg3f3TsDhEXDb0PYkkXi0sBsWy/H3/Jy1y3+7JRkzS+3RaMA+s9p6vMuWzQW8 X-Received: by 2002:a17:903:247:b0:1b8:b285:ec96 with SMTP id j7-20020a170903024700b001b8b285ec96mr19002315plh.23.1688985221666; Mon, 10 Jul 2023 03:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688985221; cv=none; d=google.com; s=arc-20160816; b=auZCDxORjewVRhUuWMr8Z2KZImlXjamViKc6BtSnjl9tM1nYe9VMfgMY1wV1dxMK8x gEYB1VN0SETeq3QS3yOcrOXeY0KY8zCTIIincLhVgJvPB2VRF+f4OCocT0M62tHi4zYj nJn6UaSnh650GTTWeyGjOrmakrdPqYH51jF0DwjYdxdW7qynaskSORoVD3bBJDQaPzEN frQlPpfgGr6XefzEVABrZ8NiYePXowvRV88HudLtsxPMJsUjIjHgHbvujOAVfQGvjt9E qS4u0T5dkgFL2HBbrj7IDHhZX1+CyGzVl9WImLJ3drHyslZ8GPDObiNV2KFF4CnlqGvx +cNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yonqcIdYIcSOrkp8Q9O3wO9J4Xret+9m7bgDiaovK/8=; fh=0+F98wGFYRypkYB2HnAQPtJBQZZGg6jGZd/5tkylhQc=; b=xcK6Jp41rdZdwltV99xSA+xHe3yqhuO4B6A/z/3nWP/oBCjNI6kk3SdzC6yM9JrQvr 4P9dmscp/erKAOr1kHwHsFXk2U1AH/xGFScC+ulQuyZsWbl8m57XC8DT+CUfLVNU7+Eq ubq2WFaiNUh00UJk14/Ln4ECeuehyzP4MgW86RF+EBgGYHVosmOiYeecUC8i1DISmSbI dgmAMQOrcad1BbPhIJ4YpwtpgVcdENh9C/2npSVmwnWBLfO2P4fTjcfDUqFTIvPdM510 S/hypj3CQZ2OLUFyo/H+wH4x1APNZTivhV1Bt0se8EzxaxQB3eBOybZoURwidtpLN1Zy H9wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h7ybhVYC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a170902e88100b001b6680bc871si9264079plg.445.2023.07.10.03.33.29; Mon, 10 Jul 2023 03:33:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h7ybhVYC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233302AbjGJK2G (ORCPT + 99 others); Mon, 10 Jul 2023 06:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233151AbjGJK16 (ORCPT ); Mon, 10 Jul 2023 06:27:58 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF85B8; Mon, 10 Jul 2023 03:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688984877; x=1720520877; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1YMEKoH26Jvs8dKIC6vdH9uSV/g2LDeyMP+ZqFMU56I=; b=h7ybhVYCq4AvpCWdmYKQb4kBn+J7jGqUqVbRr9PBch+k0VTXjX6UnlmK hphFepYNIa/eFLTkZ9BlMY+gcQFhDij//Nh2pefcSb2KZAYjkduWuySJo HRlP7wF/dM0XxMLl8IWoyqqmXp8K+Fr2siu2713El2EVVp9yKOR6UKvrS VGTOGWaCulWQYZoFaVpXMRpPbPV6pPN1vpZe1B0otTpve0c5rIn9wfoUZ 6628ojS2bs70FsVVcHLa4++uIak2EXAn1AWEyO+mx6sWrAbwJQlJ/izm3 H2isXuwUoZxbKpmddoERvFpFeQ83+pIKhvkd0AsDa7Z7mOLohhS6kpQYg Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="367803738" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="367803738" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 03:27:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="755956011" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="755956011" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 10 Jul 2023 03:27:48 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EDFD31D9; Mon, 10 Jul 2023 13:27:52 +0300 (EEST) From: Andy Shevchenko To: Mark Brown , Yang Yingliang , Andy Shevchenko , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , =?utf-8?q?Uwe_Kleine?= =?utf-8?q?-K=C3=B6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Cc: Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: [PATCH v1 1/8] spi: Remove unneeded OF node NULL checks Date: Mon, 10 Jul 2023 13:27:44 +0300 Message-Id: <20230710102751.83314-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771029367837058989 X-GMAIL-MSGID: 1771029367837058989 In the couple of places the NULL check of OF node is implied by the call that takes it as a parameter. Drop the respective duplicate checks. Signed-off-by: Andy Shevchenko --- drivers/spi/spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 9291b2a0e887..8f3282a71c63 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2399,9 +2399,6 @@ static void of_register_spi_devices(struct spi_controller *ctlr) struct spi_device *spi; struct device_node *nc; - if (!ctlr->dev.of_node) - return; - for_each_available_child_of_node(ctlr->dev.of_node, nc) { if (of_node_test_and_set_flag(nc, OF_POPULATED)) continue; @@ -3134,7 +3131,7 @@ int spi_register_controller(struct spi_controller *ctlr) if (WARN(id < 0, "couldn't get idr")) return id == -ENOSPC ? -EBUSY : id; ctlr->bus_num = id; - } else if (ctlr->dev.of_node) { + } else { /* Allocate dynamic bus number using Linux idr */ id = of_alias_get_id(ctlr->dev.of_node, "spi"); if (id >= 0) {