From patchwork Mon Jul 10 09:59:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 117807 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp4920980vqx; Mon, 10 Jul 2023 03:23:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlH1sT97aMXQYBy/L2ZRfnUN6nOuahEGRf36Q2s0QBHXT27PdzNRmttBPvj6yd3k9AIdQ47T X-Received: by 2002:a17:902:cec3:b0:1b9:d38d:f08d with SMTP id d3-20020a170902cec300b001b9d38df08dmr6854083plg.18.1688984628509; Mon, 10 Jul 2023 03:23:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1688984628; cv=pass; d=google.com; s=arc-20160816; b=hQrgiVmfCbONPzsOLnX/tb6UTY/WD28YpFasH7nRcPL+63E8bja6ChFGo6Mh1fUR8J j3Tl2Bg4Aly8pLsT0zNztw3fVgkv5MNHM92lzSa0JCAXOx4oo85O1xP9p+PLeHKuX5oQ kmRY8ZC4lgB03GHvQ0kjEuVMvYkKFABK6zXqsmbwZc1lABLLxJr4VcTMS1UpDk3DdBwL FFy2TBPq+sR0lrvqrfOo6ztkVvclgxM2wkXJBExhlCEDajSgP6KmGKm9dCRU8fSrKX9r 1fCj7wgrhoy4iy4mVLSLkMi9x482Iz0ZsajYJWQnWvgDC4wcJ9/nk1r9gABxbp6gie5m ivXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=xEXJxwEmFLIkUoDIrsEGxBxyIzn6S+LlOjxnSm/np5e22fTk1c5YvLgHBP35ClNny7 R4VqyI5Ow9kXEMzH3I8yDTwG5izCqYwxsO+1kOcEwRw3ozj3Q5YannpjRSIKPovT+26k vnfrYna25vYGXnEfyKFJ8G5OGc7pmE1F/PZGxaIfPfUWFaic947GCSJgtJnQsW9kJVPs tnyCXYPLCLmUTZPxkvmITo90vqh4XNvFlxIc0X9YiwM1kU+OxCe7685dYQz+aIHm9/Y7 Z8zfP9zktxdj4SWshrMbnlxNO0FIuOLNCHnlPqxiex4wT57D4wx+iCC0Jd+RAm8TnJd4 jc9w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=C3T3PJZp; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k24-20020a634b58000000b0052cbf501db2si8490430pgl.68.2023.07.10.03.23.35; Mon, 10 Jul 2023 03:23:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=C3T3PJZp; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbjGJKEb (ORCPT + 99 others); Mon, 10 Jul 2023 06:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjGJKDJ (ORCPT ); Mon, 10 Jul 2023 06:03:09 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2093.outbound.protection.outlook.com [40.107.255.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D1B35AC; Mon, 10 Jul 2023 03:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amPxAuRZMv3ZtsVpx+myWp1/MLziZKjYJTfSXl5VNG+gt8/dBG/m+3SrQlTioCSswpka4a3T2oNdIe7qJK7iq3IrjtX+ghdvULNVuMxbIrr/BcI75lcbWUfl8jq5xjUMPtgtUKyMVsFh0qavwSrEZZNjuGLXoHN4JbwY6qedOpCHrWGtzIMGui+Nz0vz5Ev86hiw4nykTC98Igtc41e7DligfdNI9H0LebqmF0pWV3jf9miFhMT8vZnnsKeTaTSRvko5nL+frReiUmWX+adZTOwZubMQD/ETWSUw6qrGRGjwGysAeHGXQZQpPfBzcNKEXZw5a3u+b/qh6Y1Shanq9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; b=DBRoJauV/Iz36ttzdDJcffEnVR9Q6xznDu7sSg4GC0geuVPAM0ZEO5nwphZwb7jMBaLdfShohN2yQ3AqeY1Xrrk+hAW8zr6rK1qaWfeLHMp4yWhaaUB8OKqlbSNQ9L5DXzkRIY1ld7N+lrFVmcqcvgKIWtSgwK+mTMugkohlCWTwYiin0U2iyUdcgJIGV99sZsMO9zU8rGTnQS9gX0tWz1idczG9GqrHqxzTFKmZ3gQjKvbWIL8CsjiIpueuA4S6hxJRFU7fwzkQjN0p2ASSQafDmMi0nr0SPNSE+76ANzKQmV+gxijda6WSdfojYuEZi3qhaqV7ZxSrL7OsxgwyRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; b=C3T3PJZpJN/zn5aiM8lnacNMd6abAXvlnGkLKkUO62KUrwB3bisy+Pqs1f8cgLWL3XQvHsW2Ny8wZgDZ7xOYZUDkJm9wPTtGmanWbTTbFfW2H5Aaa3eYv2apxK2bHKyII1nQAuaTItIVFMNM7IefVWC+237lDmM3xM1h1UO0PYIWqLU3srYRXyP70ocJnm/NSicAjg0FF8rqmxHf58BdFrkZuHLgEkasRLv5VwJDsGChFMAvoaqv+emR3it+MUM3hG29aet56M4s/0I64xelAo36OoJm2pcTu7jzSzg5hFrGgCXClrPfqPJWoyOeAoQUmVWo9GtM0hq/otIDnTItWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB6096.apcprd06.prod.outlook.com (2603:1096:400:33e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 10:00:18 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 10:00:18 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 15/21] thermal: max77620: convert to use devm_request*_irq_probe() Date: Mon, 10 Jul 2023 17:59:19 +0800 Message-Id: <20230710095926.15614-15-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230710095926.15614-1-frank.li@vivo.com> References: <20230710095926.15614-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR01CA0167.apcprd01.prod.exchangelabs.com (2603:1096:4:28::23) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB6096:EE_ X-MS-Office365-Filtering-Correlation-Id: 23dcfbf2-5a46-4162-c532-08db812c773f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a8I1eu3K6KqQGqmD41urPvcBoQ9wIEltkQJe39hNYOKrZo6Q7CTUbobRoDrZ8GE21MNs6lieQy8X5D2BFylHSIC+MRWVEl/UvubD9RJKCDgtngJvRU3tC0tPfr34AAPO+fiWg/zoHcyoHt9+2MhGLVK987CzWcCTqBX6Uujt2b2FOQrpB6z0DT6O0owe3/vv5Ja29uoD4tekgmPHUtMHAE31qQ/WFfy7FwxZ0xHcgl2+z17pjAK8Newql+Ro/T49MzvVnqAkpvx9fK2cMZdPAbT6m/89qFBP6pmtM41F9R85hBbgMZRAJWP+5s5MrmY9r045n707bskp9+YSstr9yI8WeW7LlQJjn4FS5m3Pc2v3gM8VAgo8CZDeEU2833s+3NzPxpPBuPPO9kvsfnLVriPXJ0qFrjmWdUt7QFnpkgW1LuhSM8xQyedgtWF+YO9+rWW2LROTNwape2GfnLtr4x56aP8ELekZdybdmA9nIR6gtAM0wqRIEfPd5ei2RYq+A6q5JFV04Mte0R3y+5Te7Lqjn7a3I8Ca1pU6J9TXjARqZJ5lLwmIAofH+Vbc2heyVN84Iy7uP24ATaOvA4Gy/ihF14YNS/thC0mdc+9CnHGgqYe6nY4CgyRH1bl6ffIO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39850400004)(366004)(136003)(346002)(396003)(451199021)(186003)(6506007)(1076003)(2616005)(6512007)(26005)(66574015)(83380400001)(41300700001)(4326008)(66476007)(2906002)(66556008)(316002)(7416002)(5660300002)(8936002)(8676002)(478600001)(66946007)(6486002)(52116002)(110136005)(54906003)(36756003)(38350700002)(38100700002)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?x6AayyocolREbQuhAymO2S2zBeCG?= =?utf-8?q?XPiNGxoK5jTyc5oGDk1r3PW5xoUjCvp/2UEtnFatVM0aWFdOrOgUgZZpvhZxPwEt/?= =?utf-8?q?f3neYkgX0rCi4loOg2s45HbYWD52jcUffobI4ZPQIhq79xouTzLMAcTFTbl14nty6?= =?utf-8?q?3+hs8NSMFNjUQ8H/Wq1ApqADbSJ9ZmRMpziApBMJa1LNe7PokuQzWKsD/jmwmsWJp?= =?utf-8?q?51E7KzjbsQX1T6XaAj38oz4ci6h3geBbQOUt5TJ3jsY/L1Lemg5eKE/t5dpI9IsFl?= =?utf-8?q?DZPGV4oHHrr4RxFvVmDtFT8whZovJGpWWNqumTpRXTVTUa9ELIlikO1bXddYLCFOx?= =?utf-8?q?VsTexeStYRrbQnMXQOlp5H9q96eieJbR4H++HSkJUhKleu5eICNEnkSeMAKuR6KTG?= =?utf-8?q?SUTABh9xGGyYIY26G/6oRQHsDEH97H4oKrUlj2UdDMxerdS20DlvAbPEPvvcKwqZK?= =?utf-8?q?ux82bvE2olCi/YjmU7UV98MTvYdXJS7rLSjKVJ3j7FBMnQukumV3qI81KBjIFMqsN?= =?utf-8?q?8vJsS8YOnzSBN5C5ndSZcedA17JScQGdRXnMFtuBXU1BohEdHCImA5V8Vik91RRqM?= =?utf-8?q?rJn1Q5arGwjYqMHtgEDIIOnv1AIdWzFrinED5zWtgvdjyr4VVe75zbPUe1NALZ2mD?= =?utf-8?q?c0J5uLdIHf98PKgpOQtOUrcOnCq/kkWbTZ8ZZNAGEk7hjsxVc5dW8wVHuR+iEsWPj?= =?utf-8?q?EaTOw/gaRqdDt8V0yEniix8iSYs41vlO5kKy4y1y6+rgikTbXN0dUieANbO2aXeF5?= =?utf-8?q?bMN/K5TmwjGAZlrhkORhFsWImsJmsArcNadi4tVByKwiBhrrhv97hnfhy51S/GUYA?= =?utf-8?q?1ZS81g4QrImt6SMolTNcV5TjlityQYMLYz8OnbKnOW05YC5LmtpaEM5+vESc1JeE1?= =?utf-8?q?2QvB0WLrA0s1mNHA0MU/z7SiplBQWLL+b5e3JwgMgNwq/hwH26qykpn1gQb3QPh+n?= =?utf-8?q?7yTJeKTi9F/EOU4mZ7RNBROHT4bgB5vzcxirlUrlwT9OEcK/q9pq4xeK96DbWtVhD?= =?utf-8?q?g3Z7lSYo+S82Tgyzz5FtgwoRMUhA1EGqWsM2qbVLibyGOxF3Nw7DtyE5R4wNQPdP3?= =?utf-8?q?UAWyCGvjpIrxy9xL5c+JhSYVoVQhoFc3VTsnDle07z8Tspa0em0nPff628p46o0Ui?= =?utf-8?q?jY1dDVkBc8Heaxjr5bXGi0mD0eto04EKegAqJrs8JlnU0bFfEfoWR0cmYlrTgwLWf?= =?utf-8?q?CPeLPpbD7m3VJmW6DFsuP2Z4n2QGHB4DogDpg8AsBoTShM9dCvNJkPBVNAr6aAWyh?= =?utf-8?q?K6YxODDjfaQ4r22Q+R4K/KfuP0/OgjL+GBjU5PPqemWwYKrJuxksOmbT5WYOKeeHP?= =?utf-8?q?HEQgITUZKpIYAq42RIx36fNfxw695z453BHFBDPr+en0adN0o9TytCsMwRqYf+SXl?= =?utf-8?q?gIeatkTk+SJIq580W3UnI9xdrAfkAktPMSr1dfHwbgp88YhcUvT9U4BRP0K2I45pj?= =?utf-8?q?AH623spXZp81yMJOmeR2ojWPQFA7bOWe4SD/AGI79CeU2dQ2yfF6En7we+HkuoQY/?= =?utf-8?q?upNDKuwobVzH?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23dcfbf2-5a46-4162-c532-08db812c773f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 10:00:18.3848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TIXbOWjlJ80Dk9egs0TsY20W0ZLJOCSnGrwM2b2dbMgpToCpwsOKQoOSBWFUTCDCOQRl2GyZ0t++LOnNKVXiAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6096 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771028745921411067 X-GMAIL-MSGID: 1771028745921411067 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/max77620_thermal.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c index 61c7622d9945..92289498fa17 100644 --- a/drivers/thermal/max77620_thermal.c +++ b/drivers/thermal/max77620_thermal.c @@ -121,23 +121,19 @@ static int max77620_thermal_probe(struct platform_device *pdev) return ret; } - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm1, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq1: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm1, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq1"); + if (ret < 0) return ret; - } - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm2, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq2: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm2, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq2"); + if (ret < 0) return ret; - } platform_set_drvdata(pdev, mtherm);