diff mbox series

[v7,1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT

Message ID 20230710064607.155155-2-nmi@metaspace.dk
State New
Headers
Series ublk: enable zoned storage support |

Commit Message

Andreas Hindborg July 10, 2023, 6:46 a.m. UTC 
  From: Andreas Hindborg <a.hindborg@samsung.com>

Ublk zoned storage support relies on DRV_IN handling for zone report.
Prepare for this change by adding offsets for the DRV_IN/DRV_OUT commands.

Suggested-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
---
 include/uapi/linux/ublk_cmd.h | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

Comments

Christoph Hellwig July 10, 2023, 6:54 a.m. UTC | #1 
On Mon, Jul 10, 2023 at 08:46:04AM +0200, Andreas Hindborg wrote:
> +#define		UBLK_IO_OP_WRITE_ZEROES		5
> +/*
> + * Ublk passthrough operation code ranges, and each passthrough operation
> + * provides generic interface between ublk kernel driver and ublk userspace, and
> + * this interface is usually used for handling generic block layer request, such
> + * as command of zoned report zones. Passthrough operation is only needed iff
> + * ublk kernel driver has to be involved for handling this operation.
> + */
> +#define		__UBLK_IO_OP_DRV_IN_START	32
> +#define		__UBLK_IO_OP_DRV_IN_END		96
> +#define		__UBLK_IO_OP_DRV_OUT_START	__UBLK_IO_OP_DRV_IN_END
> +#define		__UBLK_IO_OP_DRV_OUT_END	160

I guess I was just a little late to catch this before your resend,
sorry.  Please look at my comment on the last iteration.
diff mbox series

Patch

diff --git a/include/uapi/linux/ublk_cmd.h b/include/uapi/linux/ublk_cmd.h
index 4b8558db90e1..521a0d2fbc06 100644
--- a/include/uapi/linux/ublk_cmd.h
+++ b/include/uapi/linux/ublk_cmd.h
@@ -229,12 +229,23 @@  struct ublksrv_ctrl_dev_info {
 	__u64   reserved2;
 };
 
-#define		UBLK_IO_OP_READ		0
+#define		UBLK_IO_OP_READ			0
 #define		UBLK_IO_OP_WRITE		1
 #define		UBLK_IO_OP_FLUSH		2
-#define		UBLK_IO_OP_DISCARD	3
-#define		UBLK_IO_OP_WRITE_SAME	4
-#define		UBLK_IO_OP_WRITE_ZEROES	5
+#define		UBLK_IO_OP_DISCARD		3
+#define		UBLK_IO_OP_WRITE_SAME		4
+#define		UBLK_IO_OP_WRITE_ZEROES		5
+/*
+ * Ublk passthrough operation code ranges, and each passthrough operation
+ * provides generic interface between ublk kernel driver and ublk userspace, and
+ * this interface is usually used for handling generic block layer request, such
+ * as command of zoned report zones. Passthrough operation is only needed iff
+ * ublk kernel driver has to be involved for handling this operation.
+ */
+#define		__UBLK_IO_OP_DRV_IN_START	32
+#define		__UBLK_IO_OP_DRV_IN_END		96
+#define		__UBLK_IO_OP_DRV_OUT_START	__UBLK_IO_OP_DRV_IN_END
+#define		__UBLK_IO_OP_DRV_OUT_END	160
 
 #define		UBLK_IO_F_FAILFAST_DEV		(1U << 8)
 #define		UBLK_IO_F_FAILFAST_TRANSPORT	(1U << 9)