From patchwork Sat Jul 8 08:40:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 117411 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3790695vqx; Sat, 8 Jul 2023 01:46:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlE2PEhPSn8fqFHXhuYi4F/y7M8iZjUs5Uz6ERrW6G2denRzpBNRf8dgF4BlrWqm+GwV49vN X-Received: by 2002:a05:6a20:6a1e:b0:12f:b678:92c9 with SMTP id p30-20020a056a206a1e00b0012fb67892c9mr14142155pzk.14.1688805984411; Sat, 08 Jul 2023 01:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688805984; cv=none; d=google.com; s=arc-20160816; b=SVsDW3hfi9SCmY89or8Lq6csn5LX5pU75zAZb7/qZKtsm+oxVxVsiT8PiVShEOsTcb ufpBXIiR/It1iYbFGBNDV/OuG+5XpHfDOR/FJin/BjJM3e2YsWfiTTcKMxfpO6Sr0Mvl CIdUtchYP7koYIDx229ABIYRJdZ4CPnluqFv4LgjWJQPbfHAC8xL0B+NrKJzu1Owpu5D ZDLqbDvMjXYBqHxpjN458MwU+JULB0QVZRFmMJGR7LdCK+OVW+dCmCSILd7/+YXjdb4R 57xgvFz2zShAbQ4k1LiKfXLgTHt6Yf+8m/hdxEi/Hi3QccOw/saDoN+DYksH9XJogra4 KGmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6+AqvnlESMt4eGXysB+WU7X0HzVbXxlbD86pN2OtT+U=; fh=GfEWQRzWO44/ZqMRUP2UsrVMvN7HmpojWFUpmGyXMTg=; b=JFwqBelp4FSPCGWTqhtQOQaqGqYNkTr1nNE9FWJdiOwN3/Ck7Ma7wA7qNzF/pHfHp5 qn9V8keBeSy9f5qEEh6b9ayqIbKlqx4qDDDiZGNodBvEko0NmX4f0d9jWzTtAf668ufe SVkD+hQu0AnLm8gIy9w7wFYujfdQrcXqBl8WFSftG6CFO9h3xM/dscgvl0C9AemD0Dd4 Z+OeypHwYQSd9UdmTGOSS7nmbBz+HqL9CQYU1xhCQ/sTvp+v4pByCAoE/+N5KX3xqZ3P n2Jk1o4g7qYWuh4aNTghddv7Rcw90F5nP//1kSXOjuf5jOBllusCvId4fN5PhARmE68g h51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=JsxMJzck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv192-20020a632ec9000000b0054fd9e9b862si5511639pgb.232.2023.07.08.01.46.12; Sat, 08 Jul 2023 01:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=JsxMJzck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229773AbjGHIk7 (ORCPT + 99 others); Sat, 8 Jul 2023 04:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbjGHIk5 (ORCPT ); Sat, 8 Jul 2023 04:40:57 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEEB61FE0; Sat, 8 Jul 2023 01:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1688805640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+AqvnlESMt4eGXysB+WU7X0HzVbXxlbD86pN2OtT+U=; b=JsxMJzckQmaOdeCcP31JQuVyvWP+HhcsEyUShqxfnLig35BdIwL/wTBtZWhB5LtEy097js cuLkcV+mVyOazDjsDHTHtJv527lJtX/3ObpoQWYoPtp1nPQA4c1bUb0ilS2cF1Ii5kXdxK japyWh109wRYEGhkst2nKHWeYYSnnc8= From: Paul Cercueil To: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , Neil Armstrong , Sam Ravnborg Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Cercueil Subject: [PATCH v2 2/3] drm/panel: ld9040: Register a backlight device Date: Sat, 8 Jul 2023 10:40:26 +0200 Message-Id: <20230708084027.18352-3-paul@crapouillou.net> In-Reply-To: <20230708084027.18352-1-paul@crapouillou.net> References: <20230708084027.18352-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770841424203587642?= X-GMAIL-MSGID: =?utf-8?q?1770841424203587642?= Register a backlight device to be able to switch between all the gamma levels. v2: Remove .get_brightness() callback, use bl_get_data() and backlight_get_brightness() Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 32 +++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c index f39f999c21af..ad5ed635f592 100644 --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c @@ -8,6 +8,7 @@ * Andrzej Hajda */ +#include #include #include #include @@ -310,8 +311,30 @@ static int ld9040_parse_dt(struct ld9040 *ctx) return 0; } +static int ld9040_bl_update_status(struct backlight_device *dev) +{ + struct ld9040 *ctx = bl_get_data(dev); + + ctx->brightness = backlight_get_brightness(dev); + ld9040_brightness_set(ctx); + + return 0; +} + +static const struct backlight_ops ld9040_bl_ops = { + .update_status = ld9040_bl_update_status, +}; + +static const struct backlight_properties ld9040_bl_props = { + .type = BACKLIGHT_RAW, + .scale = BACKLIGHT_SCALE_NON_LINEAR, + .max_brightness = ARRAY_SIZE(ld9040_gammas) - 1, + .brightness = ARRAY_SIZE(ld9040_gammas) - 1, +}; + static int ld9040_probe(struct spi_device *spi) { + struct backlight_device *bldev; struct device *dev = &spi->dev; struct ld9040 *ctx; int ret; @@ -323,7 +346,7 @@ static int ld9040_probe(struct spi_device *spi) spi_set_drvdata(spi, ctx); ctx->dev = dev; - ctx->brightness = ARRAY_SIZE(ld9040_gammas) - 1; + ctx->brightness = ld9040_bl_props.brightness; ret = ld9040_parse_dt(ctx); if (ret < 0) @@ -353,6 +376,13 @@ static int ld9040_probe(struct spi_device *spi) drm_panel_init(&ctx->panel, dev, &ld9040_drm_funcs, DRM_MODE_CONNECTOR_DPI); + + bldev = devm_backlight_device_register(dev, dev_name(dev), dev, + ctx, &ld9040_bl_ops, + &ld9040_bl_props); + if (IS_ERR(bldev)) + return PTR_ERR(bldev); + drm_panel_add(&ctx->panel); return 0;