diff mbox series

[50/53] interconnect: qcom: sm8350: Point display paths to the display RSC

Message ID 20230708-topic-rpmh_icc_rsc-v1-50-b223bd2ac8dd@linaro.org
State New
Headers
Series icc-rpmh multi-RSC voting groundwork |

Commit Message

Konrad Dybcio July 11, 2023, 12:18 p.m. UTC 
  The _DISP paths are expected to go through the DISP RSC. Point them to the
correct place.

Fixes: d26a56674497 ("interconnect: qcom: Add SM8350 interconnect provider driver")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/interconnect/qcom/sm8350.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Dmitry Baryshkov July 11, 2023, 2:17 p.m. UTC | #1 
On 11/07/2023 15:18, Konrad Dybcio wrote:
> The _DISP paths are expected to go through the DISP RSC. Point them to the
> correct place.
> 
> Fixes: d26a56674497 ("interconnect: qcom: Add SM8350 interconnect provider driver")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   drivers/interconnect/qcom/sm8350.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c
> index c48f96ff8575..0466ba5d939a 100644
> --- a/drivers/interconnect/qcom/sm8350.c
> +++ b/drivers/interconnect/qcom/sm8350.c
> @@ -1609,7 +1609,7 @@ static struct qcom_icc_bcm bcm_sn14 = {
>   static struct qcom_icc_bcm bcm_acv_disp = {
>   	.name = "ACV",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,

Shouldn't this value come from a enum? Otherwise a magic '1' is... a magic.

>   	.num_nodes = 1,
>   	.nodes = { &ebi_disp },
>   };
> @@ -1617,7 +1617,7 @@ static struct qcom_icc_bcm bcm_acv_disp = {
>   static struct qcom_icc_bcm bcm_mc0_disp = {
>   	.name = "MC0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &ebi_disp },
>   };
> @@ -1625,7 +1625,7 @@ static struct qcom_icc_bcm bcm_mc0_disp = {
>   static struct qcom_icc_bcm bcm_mm0_disp = {
>   	.name = "MM0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_mem_noc_hf_disp },
>   };
> @@ -1633,7 +1633,7 @@ static struct qcom_icc_bcm bcm_mm0_disp = {
>   static struct qcom_icc_bcm bcm_mm1_disp = {
>   	.name = "MM1",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 2,
>   	.nodes = { &qxm_mdp0_disp, &qxm_mdp1_disp },
>   };
> @@ -1641,7 +1641,7 @@ static struct qcom_icc_bcm bcm_mm1_disp = {
>   static struct qcom_icc_bcm bcm_mm4_disp = {
>   	.name = "MM4",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_mem_noc_sf_disp },
>   };
> @@ -1649,7 +1649,7 @@ static struct qcom_icc_bcm bcm_mm4_disp = {
>   static struct qcom_icc_bcm bcm_mm5_disp = {
>   	.name = "MM5",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qxm_rot_disp },
>   };
> @@ -1657,7 +1657,7 @@ static struct qcom_icc_bcm bcm_mm5_disp = {
>   static struct qcom_icc_bcm bcm_sh0_disp = {
>   	.name = "SH0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_llcc_disp },
>   };
>
Konrad Dybcio July 11, 2023, 2:18 p.m. UTC | #2 
On 11.07.2023 16:17, Dmitry Baryshkov wrote:
> On 11/07/2023 15:18, Konrad Dybcio wrote:
>> The _DISP paths are expected to go through the DISP RSC. Point them to the
>> correct place.
>>
>> Fixes: d26a56674497 ("interconnect: qcom: Add SM8350 interconnect provider driver")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   drivers/interconnect/qcom/sm8350.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c
>> index c48f96ff8575..0466ba5d939a 100644
>> --- a/drivers/interconnect/qcom/sm8350.c
>> +++ b/drivers/interconnect/qcom/sm8350.c
>> @@ -1609,7 +1609,7 @@ static struct qcom_icc_bcm bcm_sn14 = {
>>   static struct qcom_icc_bcm bcm_acv_disp = {
>>       .name = "ACV",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
> 
> Shouldn't this value come from a enum? Otherwise a magic '1' is... a magic.
Yep, rebase mess!

Konrad
> 
>>       .num_nodes = 1,
>>       .nodes = { &ebi_disp },
>>   };
>> @@ -1617,7 +1617,7 @@ static struct qcom_icc_bcm bcm_acv_disp = {
>>   static struct qcom_icc_bcm bcm_mc0_disp = {
>>       .name = "MC0",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 1,
>>       .nodes = { &ebi_disp },
>>   };
>> @@ -1625,7 +1625,7 @@ static struct qcom_icc_bcm bcm_mc0_disp = {
>>   static struct qcom_icc_bcm bcm_mm0_disp = {
>>       .name = "MM0",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 1,
>>       .nodes = { &qns_mem_noc_hf_disp },
>>   };
>> @@ -1633,7 +1633,7 @@ static struct qcom_icc_bcm bcm_mm0_disp = {
>>   static struct qcom_icc_bcm bcm_mm1_disp = {
>>       .name = "MM1",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 2,
>>       .nodes = { &qxm_mdp0_disp, &qxm_mdp1_disp },
>>   };
>> @@ -1641,7 +1641,7 @@ static struct qcom_icc_bcm bcm_mm1_disp = {
>>   static struct qcom_icc_bcm bcm_mm4_disp = {
>>       .name = "MM4",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 1,
>>       .nodes = { &qns_mem_noc_sf_disp },
>>   };
>> @@ -1649,7 +1649,7 @@ static struct qcom_icc_bcm bcm_mm4_disp = {
>>   static struct qcom_icc_bcm bcm_mm5_disp = {
>>       .name = "MM5",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 1,
>>       .nodes = { &qxm_rot_disp },
>>   };
>> @@ -1657,7 +1657,7 @@ static struct qcom_icc_bcm bcm_mm5_disp = {
>>   static struct qcom_icc_bcm bcm_sh0_disp = {
>>       .name = "SH0",
>>       .keepalive = false,
>> -    .voter_idx = 0,
>> +    .voter_idx = 1,
>>       .num_nodes = 1,
>>       .nodes = { &qns_llcc_disp },
>>   };
>>
>
diff mbox series

Patch

diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c
index c48f96ff8575..0466ba5d939a 100644
--- a/drivers/interconnect/qcom/sm8350.c
+++ b/drivers/interconnect/qcom/sm8350.c
@@ -1609,7 +1609,7 @@  static struct qcom_icc_bcm bcm_sn14 = {
 static struct qcom_icc_bcm bcm_acv_disp = {
 	.name = "ACV",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &ebi_disp },
 };
@@ -1617,7 +1617,7 @@  static struct qcom_icc_bcm bcm_acv_disp = {
 static struct qcom_icc_bcm bcm_mc0_disp = {
 	.name = "MC0",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &ebi_disp },
 };
@@ -1625,7 +1625,7 @@  static struct qcom_icc_bcm bcm_mc0_disp = {
 static struct qcom_icc_bcm bcm_mm0_disp = {
 	.name = "MM0",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &qns_mem_noc_hf_disp },
 };
@@ -1633,7 +1633,7 @@  static struct qcom_icc_bcm bcm_mm0_disp = {
 static struct qcom_icc_bcm bcm_mm1_disp = {
 	.name = "MM1",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 2,
 	.nodes = { &qxm_mdp0_disp, &qxm_mdp1_disp },
 };
@@ -1641,7 +1641,7 @@  static struct qcom_icc_bcm bcm_mm1_disp = {
 static struct qcom_icc_bcm bcm_mm4_disp = {
 	.name = "MM4",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &qns_mem_noc_sf_disp },
 };
@@ -1649,7 +1649,7 @@  static struct qcom_icc_bcm bcm_mm4_disp = {
 static struct qcom_icc_bcm bcm_mm5_disp = {
 	.name = "MM5",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &qxm_rot_disp },
 };
@@ -1657,7 +1657,7 @@  static struct qcom_icc_bcm bcm_mm5_disp = {
 static struct qcom_icc_bcm bcm_sh0_disp = {
 	.name = "SH0",
 	.keepalive = false,
-	.voter_idx = 0,
+	.voter_idx = 1,
 	.num_nodes = 1,
 	.nodes = { &qns_llcc_disp },
 };