Message ID | 20230707135852.24292-6-bhe@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3305316vqx; Fri, 7 Jul 2023 07:22:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGa9T4SfrdGGS05OCWHvx5qpM8XvClVDeGIB5/bh8wHEMFzGxLRGDXHA1kUcV+ZQhD5kBpW X-Received: by 2002:a92:2905:0:b0:345:913a:41a2 with SMTP id l5-20020a922905000000b00345913a41a2mr5362634ilg.29.1688739729358; Fri, 07 Jul 2023 07:22:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688739729; cv=none; d=google.com; s=arc-20160816; b=M+pHu8/emWcSuML/dNp5j3cChCSfRpD/klyvWMBG+zMv+EyUq5h/bNCTBNYchoZvg7 RFQqOc55NJNNWOYIJ2nMhNxKhEHLogZ6TzROArj0r7NGYVcEpFU95DsrN31i1p8vZ0LC eRCSFWpP6ohGaD4vt2tAcXI+fTN6vyhsn/0usWsZap6bzVQFRVGdP0TlKvWKvjihU5uk hbmwcXcJD5/Hz8PeKldJSJ/41lf9u74Cp86Q0DFrAa+ADK5z21e+YBWvb56cBq47Qn0f Oh42qarflOMlYC5/CzTqwajcDaKyLDUHYqjh04qCaUiS6uNTW7kHVj+fVEpTNGUk5gcr tu0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; fh=e8la30POMJv1qx1/W6S4CNHyD9IRQbnZFyV8/PzkuTQ=; b=TKN9BNRQWtklqTVHQvJjDrBycTPxbeZxxyTY0TmaZx15WPdvmmeuI9SDK7sif3zdLF rWXSl+1FBa6SsCuCqCBFnglaZ0/wId0Vum5nD1qnqHK7ZN2L53yzkrmtt8gIEEAkg2B6 2P7Rzp+5Va9qDfErg/Sf2BURlBiXnC3/fR3RPou+q3JbDDVbS1UtyMuNMQ9Oz4ABVpi3 5373j61Ltli3Jyce93KkpQyYRTA2yGyoWRHEeOj64hgU96pSAeCJSP8btH7Hz0oixjTc pirTCrigx2Jo4RZWOYY4JI0NOVh4MsfCcv0vkSaWqSMqJ4bb93N0tw06/QjQw6pRIqhH e0yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPPXjdbI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a65670e000000b005578c6a767esi3940351pgf.885.2023.07.07.07.21.53; Fri, 07 Jul 2023 07:22:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPPXjdbI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbjGGOBY (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 7 Jul 2023 10:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232664AbjGGOBV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Jul 2023 10:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB842118 for <linux-kernel@vger.kernel.org>; Fri, 7 Jul 2023 07:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; b=UPPXjdbIQXYdlE1bYNesp3rK2OxkLMlv1WVvzYzaoioWtWF3l9J9XCLtTU9AVbTYcEek9i q8snyAxygq1uVhGcz6nsHFP5jbNNBxAw8Cm7YbJ4kdx8Cr9UgpQWYhwRNPOyjZaO3lhBrf eKdiz4A6NI+tp2ImGmYbVKlKqOPtQEE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-GcVuy2HmPeOr0kuq4Z8fqQ-1; Fri, 07 Jul 2023 10:00:25 -0400 X-MC-Unique: GcVuy2HmPeOr0kuq4Z8fqQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BDDC88D543; Fri, 7 Jul 2023 14:00:23 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 594D02166B26; Fri, 7 Jul 2023 14:00:08 +0000 (UTC) From: Baoquan He <bhe@redhat.com> To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He <bhe@redhat.com>, kernel test robot <lkp@intel.com>, netdev@vger.kernel.org Subject: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:49 +0800 Message-Id: <20230707135852.24292-6-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770771950302355223?= X-GMAIL-MSGID: =?utf-8?q?1770771950302355223?= |
Series |
Make several Kconfig options depend on HAS_IOMEM
|
|
Commit Message
Baoquan He
July 7, 2023, 1:58 p.m. UTC
On s390 systems (aka mainframes), it has classic channel devices for
networking and permanent storage that are currently even more common
than PCI devices. Hence it could have a fully functional s390 kernel
with CONFIG_PCI=n, then the relevant iomem mapping functions
[including ioremap(), devm_ioremap(), etc.] are not available.
Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built
to cause below compiling error if PCI is unset:
------
ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined!
------
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Joyce Ooi <joyce.ooi@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/altera/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > to cause below compiling error if PCI is unset: > > ------ > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > ------ > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > Signed-off-by: Baoquan He <bhe@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested I wonder if this should also have: Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")
On 07/11/23 at 06:17pm, Simon Horman wrote: > On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > > to cause below compiling error if PCI is unset: > > > > ------ > > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > > ------ > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > > Signed-off-by: Baoquan He <bhe@redhat.com> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested Thanks, Simon. > > I wonder if this should also have: > > Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig") Agree, it's worth having Fixes tag.
diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig index 17985319088c..4ef819a9a1ad 100644 --- a/drivers/net/ethernet/altera/Kconfig +++ b/drivers/net/ethernet/altera/Kconfig @@ -2,6 +2,7 @@ config ALTERA_TSE tristate "Altera Triple-Speed Ethernet MAC support" depends on HAS_DMA + depends on HAS_IOMEM select PHYLIB select PHYLINK select PCS_LYNX