Message ID | 20230707135852.24292-5-bhe@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3296290vqx; Fri, 7 Jul 2023 07:09:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHbyxNJbKK78bEShI7WkzrYc8BPU7lyF1MEyczMVW/MpJYvcu4RqgCXMqkNmw6f2/jGAPk6 X-Received: by 2002:a05:6a21:33a9:b0:125:c3f7:f863 with SMTP id yy41-20020a056a2133a900b00125c3f7f863mr13072444pzb.8.1688738971805; Fri, 07 Jul 2023 07:09:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688738971; cv=none; d=google.com; s=arc-20160816; b=U+BTrZBMPY3CQ7K5qvVnd7mZTmnDqR7XQpOmPzY6ehhUxvqX0jUAAuhImEN+QLAY0U B8nbVG/5ns6wT6WhA9IUJFQexLxwCPoq5h7rchgK0uYzfbxhS59Vkb3OcCMrZhga3Ne5 OEeWjUnXOgoK3VOQcLbxvhsaqPg1OO2o0ciiExigaKhL1oyaMgXmmTzsZXa1MtYTKLhn Qvrp0RM8LzDxni24WT03aqQ2N9DTDdEj08CV7+OeKFj4bhxtRbLfXzhD+91u3EUerLRK Y2raj1JgwAfx29k85zPDtK3s4eeMANJmTqttW+S2Vo3up2dlh6uXi+ll+fsR86Z/4JSm KQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; fh=INcnS+yX2NBDfIB23aYzu5gfxH1rW6lB53wHwdUYBVs=; b=txfLCYXzIuAVSfbg+TjnWsoNTfUafUcF0fgi0DUNiFclnc6ppYVc2HftbM2vlykDuO OHbc4L4f7jgUDNj8jTh8T/Z87L+Y+QXZrGqRP7H1n1C5DkrVNmNvPcGjhrrrrCz3pIO3 P1N0AjC6hXtmg9wrAtTpy8DF+Uji2DooS2gbM/FBNiZ0PuDIwXkFiGBgOGHRlr0FM8eZ NpIsVdPyxTku2KyI9N6n7fMhS1eYeL38AG3FOUqGWq3O+QsvGilangSiOCEOX9Ts2EWx NzLivfNYza2MXkHjTup4xv0xqfSCLFFloebfRF1zFqdv3ez4aml5Jp2EE0hZdFQP5RW6 5paA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j10-20020a634a4a000000b0053ff537164fsi3842237pgl.783.2023.07.07.07.09.15; Fri, 07 Jul 2023 07:09:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjGGOBA (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 7 Jul 2023 10:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjGGOA7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Jul 2023 10:00:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B093A2115 for <linux-kernel@vger.kernel.org>; Fri, 7 Jul 2023 07:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; b=DLzUHdthoOunr7DQLJbo1axZLKr+1dfnEDcNI29rNywV8FUAnGYqv3QBoDpXaU9yjilWmR eKj97judUHCVF/4R+QKrWovZLuph7TIIsWarCaASGCcwDvBP2jz+YfjPD9SSK2uuFT54Zv qyq5cmKUIWsEpbKDylgLz9Iw6kmodKk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-Y6FTdWTiNrKHrUZxO4Wg0w-1; Fri, 07 Jul 2023 10:00:09 -0400 X-MC-Unique: Y6FTdWTiNrKHrUZxO4Wg0w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2AEB101A528; Fri, 7 Jul 2023 14:00:07 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34C782166B25; Fri, 7 Jul 2023 13:59:54 +0000 (UTC) From: Baoquan He <bhe@redhat.com> To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He <bhe@redhat.com>, kernel test robot <lkp@intel.com> Subject: [PATCH 4/8] pcmcia : make PCMCIA depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:48 +0800 Message-Id: <20230707135852.24292-5-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770771156295654450?= X-GMAIL-MSGID: =?utf-8?q?1770771156295654450?= |
Series |
Make several Kconfig options depend on HAS_IOMEM
|
|
Commit Message
Baoquan He
July 7, 2023, 1:58 p.m. UTC
On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let depend PCMCIA on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. ------ ld: drivers/pcmcia/cistpl.o: in function `set_cis_map': cistpl.c:(.text+0x1202): undefined reference to `ioremap' ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap' ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap' ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap' ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem': cistpl.c:(.text+0x3f14): undefined reference to `iounmap' ------ Besides, many other Kconfig option, e.g IPWIRELESS, PCMCIA_PCNET, PCMCIA_FMVJ18X, PCMCIA_SMC91C92 which depends on PCMCIA also will cause compiling error if enabled. ------ ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/arcnet/com90xx.ko] undefined! ------ Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He <bhe@redhat.com> Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> --- drivers/pcmcia/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig index e72419d7e72e..dddb235dd020 100644 --- a/drivers/pcmcia/Kconfig +++ b/drivers/pcmcia/Kconfig @@ -19,6 +19,7 @@ if PCCARD config PCMCIA tristate "16-bit PCMCIA support" + depends on HAS_IOMEM select CRC32 default y help