From patchwork Fri Jul 7 07:33:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 117026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3092990vqx; Fri, 7 Jul 2023 00:52:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlFwR07snRyEE88zaJIjcNFWKxupOQ0n2IqBs6tPOoJru6cUslXxXhw5sDsYnP0kplUv67Pu X-Received: by 2002:a17:902:dac9:b0:1b8:76cb:c6a4 with SMTP id q9-20020a170902dac900b001b876cbc6a4mr11048395plx.21.1688716336798; Fri, 07 Jul 2023 00:52:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688716336; cv=none; d=google.com; s=arc-20160816; b=IDlTxExrGKTVfLOTfTW7Ei2/xhv8PtgUWHjNC17zkMKy7CjWPpJO86xiR3nqnOZCR+ lB/TbJ7uOqpZal97LUHbdH6gCOk92/+FRmEs+Ks+6itOh6D8FtWHp897zAoV8zDnxPQO Wl1y7kw+GONJbSyylhx+KZxLGegM2c8CBB1bkE+iRqit90DeerD0FlF1yY/0LsJMfSSw 0otqh/vxj1MfIwKneCY6+IGfuwIqPpfK6YKDajdskkqhgzhfNx6jY3w2jNkKOjrqvFGi IgEccnI9dvWjXcjKQAEbkljdgXJoc+u3XHxcI9CuewjzwRXPU6Cb+nOZT/TMY0Y6LX0F hsYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nxh/h9bDeU185o1AG5kqN2jaBw4lCWss4zD/0p/yjtQ=; fh=oV5q+s+mEkpuQN6h7dOwVKQx+zPg/LCaJmgdBgjR6qU=; b=j2ME7UVNPEvy0woWMDSEo4OYheSbbLcwdQelG7u9V1gUA8UZ1KjdRul9P1aN0QCfL9 zutT3228vR0GD3zqoqYeVEKUnoCJ+QWNiVcDBVQhNTcTTsnx6wenHFNbRSjjOwa1deMZ HD0DDPBS1aDOL3gNcOXCkwiOM3qy+4R/bh5IxspCkMTL0zRLuzNzaqoC2Y1U21Zns3if I6v9nilDhlWsB4VFletDAy9J8WTTJa3QxIezqfpur/em821CcG2hGxD8ggz128F3byfc D+ZEPkQUIF2Gm0NZABM76ks5MyK2B3hxH7oJiwR7ohveDUMTiNUBe8DCM6f/KSrKyNs7 MPxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a170902c21500b001b025aba9f2si3032774pll.22.2023.07.07.00.52.01; Fri, 07 Jul 2023 00:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbjGGHdy (ORCPT + 99 others); Fri, 7 Jul 2023 03:33:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjGGHdw (ORCPT ); Fri, 7 Jul 2023 03:33:52 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65C321FD9 for ; Fri, 7 Jul 2023 00:33:51 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHfyO-0003N7-Cp; Fri, 07 Jul 2023 09:33:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qHfyM-00CgG0-Ar; Fri, 07 Jul 2023 09:33:46 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qHfyL-002wok-Eg; Fri, 07 Jul 2023 09:33:45 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Arnd Bergmann , Julien Panis , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] misc: tps6594-pfsm: Convert to platform remove callback returning void Date: Fri, 7 Jul 2023 09:33:43 +0200 Message-Id: <20230707073343.3396477-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1739; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=lVTZfDlkWQIkBc/T5Uih9QgBjRzRgPeJPBlwUWi78NI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkp7/Wcwt/QNf+huCVErIoFz0vgic9YOIEoEqf0 HTC63+Mx6OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZKe/1gAKCRCPgPtYfRL+ TkpgCACqDEdsTjrn/kBDpGy7weSa6TQnC8pJVl6cOkcw5/jXecKp9c4+xMvXkB3rq/ltmfRUmDV Fpx4ALdBLbjiapJfaY6YP1K0D99TVhcieurfnGA5pyzNoNKaItx2Nf82ZYB2agJx2jWIbMc+SJ0 nyGxll3rYxzH8jNgAgHeESfQ7bEa8v++k9/XPykqiGnMEP+SwLKoDau0TseuBb2ypySX2U0LEan KDmrOeDjCuCwGja3hJdxPfFuKO3SZ8l5RF2ixaF10LacYwiDZLPwxMkGBeNMCThh0+3K4B/PkCG Zoek8sMIP1ZBTCkanS/xwhd0dvbIPJvDQRWO/3aayzuaspiO X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770747421550138405?= X-GMAIL-MSGID: =?utf-8?q?1770747421550138405?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/misc/tps6594-pfsm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c index 5223d1580807..0e24f8daaa9a 100644 --- a/drivers/misc/tps6594-pfsm.c +++ b/drivers/misc/tps6594-pfsm.c @@ -281,13 +281,11 @@ static int tps6594_pfsm_probe(struct platform_device *pdev) return misc_register(&pfsm->miscdev); } -static int tps6594_pfsm_remove(struct platform_device *pdev) +static void tps6594_pfsm_remove(struct platform_device *pdev) { struct tps6594_pfsm *pfsm = platform_get_drvdata(pdev); misc_deregister(&pfsm->miscdev); - - return 0; } static struct platform_driver tps6594_pfsm_driver = { @@ -295,7 +293,7 @@ static struct platform_driver tps6594_pfsm_driver = { .name = "tps6594-pfsm", }, .probe = tps6594_pfsm_probe, - .remove = tps6594_pfsm_remove, + .remove_new = tps6594_pfsm_remove, }; module_platform_driver(tps6594_pfsm_driver);