diff mbox series

Move rmnet out of NET_VENDOR_QUALCOMM dependency

Message ID 20230706145154.2517870-1-jforbes@fedoraproject.org
State New
Headers
Series Move rmnet out of NET_VENDOR_QUALCOMM dependency |

Commit Message

Justin M. Forbes July 6, 2023, 2:51 p.m. UTC 
  The rmnet driver is useful for chipsets that are not hidden behind
NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
NET_VENDOR_QUALCOMM as there is no dependency here.

Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
---
 drivers/net/ethernet/qualcomm/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski July 6, 2023, 3:44 p.m. UTC | #1 
On Thu,  6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:
> The rmnet driver is useful for chipsets that are not hidden behind
> NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
> NET_VENDOR_QUALCOMM as there is no dependency here.
> 
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>

Examples of the chipsets you're talking about would be great to have in
the commit message.
Justin M. Forbes July 7, 2023, 4:50 p.m. UTC | #2 
On Thu, Jul 6, 2023 at 10:44 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu,  6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:
> > The rmnet driver is useful for chipsets that are not hidden behind
> > NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
> > NET_VENDOR_QUALCOMM as there is no dependency here.
> >
> > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
>
> Examples of the chipsets you're talking about would be great to have in
> the commit message.

The user in the Fedora bug was using mhi_net with qmi_wwan.

Justin

> pw-bot: cr
>
Jakub Kicinski July 7, 2023, 10:12 p.m. UTC | #3 
On Fri, 7 Jul 2023 11:50:16 -0500 Justin Forbes wrote:
> > On Thu,  6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:  
> > > The rmnet driver is useful for chipsets that are not hidden behind
> > > NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
> > > NET_VENDOR_QUALCOMM as there is no dependency here.
> > >
> > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>  
> >
> > Examples of the chipsets you're talking about would be great to have in
> > the commit message.  
> 
> The user in the Fedora bug was using mhi_net with qmi_wwan.

Hm, if anything mhi_net should not be sitting directly in drivers/net/

I don't think this is a change in the right direction, just enable
VENDOR_QUALCOMM? Or am I missing something?
Justin M. Forbes July 7, 2023, 11:19 p.m. UTC | #4 
On Fri, Jul 7, 2023 at 4:12 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 7 Jul 2023 11:50:16 -0500 Justin Forbes wrote:
> > > On Thu,  6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:
> > > > The rmnet driver is useful for chipsets that are not hidden behind
> > > > NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
> > > > NET_VENDOR_QUALCOMM as there is no dependency here.
> > > >
> > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> > >
> > > Examples of the chipsets you're talking about would be great to have in
> > > the commit message.
> >
> > The user in the Fedora bug was using mhi_net with qmi_wwan.
>
> Hm, if anything mhi_net should not be sitting directly in drivers/net/
>
> I don't think this is a change in the right direction, just enable
> VENDOR_QUALCOMM? Or am I missing something?

Enabling it is not a problem, but it seems that if devices not hidden
behind VENDOR_QUALCOMM are able to use rmnet, then it is incorrect for
rmnet to be hidden behind VENDOR_QUALCOMM. I have already enabled
everything for Fedora users, so I am not worried about how to support
my users, just a matter of correctness, and the fact that Kconfig deps
are more difficult for people to understand in general.   Someone
reading online hears they need to turn on rmnet, so they add an entry
for it, and don't realize that the entry is ignored because
VENDOR_QUALCOMM is not enabled.  Either all devices capable of using
rmnet should be hidden behind VENDOR_QUALCOMM or rmnet should not be.

Justin
Jakub Kicinski July 7, 2023, 11:27 p.m. UTC | #5 
On Fri, 7 Jul 2023 17:19:12 -0600 Justin Forbes wrote:
> they add an entry for it, and don't realize that the entry is ignored

Maybe that someone should not be "adding an entry" to a file which 
has this at the top:

#
# Automatically generated file; DO NOT EDIT.

?

> VENDOR_QUALCOMM is not enabled.  Either all devices capable of using
> rmnet should be hidden behind VENDOR_QUALCOMM or rmnet should not be.

I agree that Qualcomm drivers are an atrocious mess.
They should live neatly in the wwan section. But it's Qualcomm,
they don't care. Let's not have it sprawl even more.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index 9210ff360fdc..5beebe6b486e 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -61,6 +61,6 @@  config QCOM_EMAC
 	  low power, Receive-Side Scaling (RSS), and IEEE 1588-2008
 	  Precision Clock Synchronization Protocol.

-source "drivers/net/ethernet/qualcomm/rmnet/Kconfig"
-
 endif # NET_VENDOR_QUALCOMM
+
+source "drivers/net/ethernet/qualcomm/rmnet/Kconfig"