diff mbox series

[1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()

Message ID 20230706120850.11026-1-frank.li@vivo.com
State New
Headers
Series [1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource() |

Commit Message

李扬韬 July 6, 2023, 12:08 p.m. UTC 
  Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alexander Lobakin July 6, 2023, 12:29 p.m. UTC | #1 
From: Yangtao Li <frank.li@vivo.com>
Date: Thu,  6 Jul 2023 20:08:47 +0800

> [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()

Please clearly specify the target tree (net or net-next) in the subject
prefix. Since your series is cleanups, it should be "PATCH net-next".

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index ad2c30d9a482..3cba947e4cbd 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
>  
>  	ndev->irq = rc;
>  
> -	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
> -	lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
> +	lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
>  	if (IS_ERR(lp->base_addr)) {
>  		rc = PTR_ERR(lp->base_addr);
>  		goto error;

Thanks,
Olek
Jakub Kicinski July 6, 2023, 3:48 p.m. UTC | #2 
On Thu,  6 Jul 2023 20:08:47 +0800 Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

## Form letter - net-next-closed

The merge window for v6.5 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after July 10th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
diff mbox series

Patch

diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index ad2c30d9a482..3cba947e4cbd 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1114,8 +1114,7 @@  static int xemaclite_of_probe(struct platform_device *ofdev)
 
 	ndev->irq = rc;
 
-	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
-	lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
+	lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
 	if (IS_ERR(lp->base_addr)) {
 		rc = PTR_ERR(lp->base_addr);
 		goto error;