mbox series

[GIT,PULL] vfs fixes

Message ID 20230706-anlehnen-fichtenwald-1b7c46c068f6@brauner
State New
Headers
Series [GIT,PULL] vfs fixes |

Pull-request

git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.5/vfs.fixes.2

Message

Christian Brauner July 6, 2023, 11:52 a.m. UTC 
  Hey Linus,

/* Summary */
This contains two minor fixes for Jan's rename locking work:
(1) Unlocking the source inode was guarded by a check whether source was
    non-NULL. This doesn't make sense because source must be non-NULL
    and the commit message explains in detail why.
(2) The lock_two_nondirectories() helper called WARN_ON_ONCE() and
    dereferenced the inodes unconditionally but the underlying
    lock_two_inodes() helper and the kernel documentation for that
    function are clear that it is valid to pass NULL arguments. So here
    a non-NULL check is needed. No caller does pass non-NULL arguments
    but let's not knowingly leave landmines around.

/* Testing */
clang: Ubuntu clang version 15.0.7
gcc: (Ubuntu 12.2.0-3ubuntu1) 12.2.0

/* Conflicts */
At the time of creating this PR no merge conflicts were reported from
linux-next and no merge conflicts showed up doing a test-merge with
current mainline.

All patches are based on current mainline. No build failures or warnings
were observed. All old and new tests in fstests, selftests, and LTP pass
without regressions.

The following changes since commit 24be4d0b46bb0c3c1dc7bacd30957d6144a70dfc:

  arch/arm64/mm/fault: Fix undeclared variable error in do_page_fault() (2023-07-03 19:04:32 -0700)

are available in the Git repository at:

  git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.5/vfs.fixes.2

for you to fetch changes up to 33ab231f83cc12d0157711bbf84e180c3be7d7bc:

  fs: don't assume arguments are non-NULL (2023-07-04 10:21:11 +0200)

Please consider pulling these changes from the signed v6.5/vfs.fixes.2 tag.

Thanks!
Christian

----------------------------------------------------------------
v6.5/vfs.fixes.2

----------------------------------------------------------------
Christian Brauner (1):
      fs: don't assume arguments are non-NULL

Jan Kara (1):
      fs: no need to check source

 fs/inode.c | 6 ++++--
 fs/namei.c | 3 +--
 2 files changed, 5 insertions(+), 4 deletions(-)

Comments

pr-tracker-bot@kernel.org July 7, 2023, 2:27 a.m. UTC | #1 
The pull request you sent on Thu,  6 Jul 2023 13:52:59 +0200:

> git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.5/vfs.fixes.2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7fdeb23f32d6843c34ad1a4200d04069ff339906

Thank you!