From patchwork Wed Jul 5 21:51:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 116456 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2159056vqx; Wed, 5 Jul 2023 14:58:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlGqxw6FvfjQtXBrNh+5utce2PnR4AkXf8vOQpa1d7jtF2WGG/qyHlNnpUweLtNHjyEgStiP X-Received: by 2002:a05:6358:3a1b:b0:134:c7ef:406d with SMTP id g27-20020a0563583a1b00b00134c7ef406dmr73258rwe.31.1688594304962; Wed, 05 Jul 2023 14:58:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688594304; cv=none; d=google.com; s=arc-20160816; b=IAMqlGJX9qPew5Xcfu73EP285R1z6wpU+ZzHP2UpMPSaWmYneHamDEsBDgVBhXwjPE A+9ltP3cXC1kIUNiIL5/+8z1msxlEY61k/n3EsaSocxm6JpBnU515gs1T3Bvw01Hq+JU ZinDbtjlMGTa/oeDvKN9LLGN2ePjYCbh6B6MeRFNgxTOwAMiB+f13yHDvSGmgl40BBZ9 v6dm+j3GfXdi91WKiYYDH1q4nzdGo1iM+LPu5NkmMlP9DD6aMrOncVOcFh3pVb6FSS0f vi6Cjv/+J/aNCG/zdNLaAQoBIAeSyYIe1dqHMb4U0tCS0MsxiZeptThkcGYp/lIYrjKK K1kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pG5sHhRilqQNOqdg7J34jIBo6Ejr3LEqWSkoVpRsi9I=; fh=emqNSapYDYTP4/qI6teL5iP5euaV+NeB6GOE7oT4/M8=; b=pmMZM0rGEh9WUf6IrSKPR81fXCTq/lkTkWO89EB29qwfvI9y3rHjRa2C+UB1M++5qP 6sUQgmd/dCpVnEh0XpT1aPEbVM1A/TNvsu/167c0Mcca6UdO2djnU/7RRTiGNo2/j1ix E+OwaEZGB7XTgNdc6n6SbVXSs1XnrGh+qYCcX+tAketeHQtI6cA/oaNGuQQJJT1KzSq3 eD+mGnydZ6LXtynhQXWd2FeTQisc3PIz9Tt3c0GysJ29YYTp3r6p/2WjwbhQzG83sqK5 wrQt8Hpj2E/Erw+xotgHWR4EkqqHhUYyajpNoILJn8neuHIa9VVltu1Wdmko1bSqTbxQ j4rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=eIV+QNlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a63ee0d000000b0055b7999649asi61857pgi.442.2023.07.05.14.58.12; Wed, 05 Jul 2023 14:58:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=eIV+QNlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232346AbjGEVwG (ORCPT + 99 others); Wed, 5 Jul 2023 17:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232168AbjGEVwE (ORCPT ); Wed, 5 Jul 2023 17:52:04 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E8B6199F for ; Wed, 5 Jul 2023 14:52:03 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51ddbf83ff9so4288a12.0 for ; Wed, 05 Jul 2023 14:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688593922; x=1691185922; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pG5sHhRilqQNOqdg7J34jIBo6Ejr3LEqWSkoVpRsi9I=; b=eIV+QNlYmoIToossEO8Dr2P2tCM4DMYnFyd5SjAMU/ToJzxZEKeOH5CBebCKRd9IAZ Cug25UC1mzVYGrUHRpn40fvyuB3KTlWODuncWkgEnRCidvIkHtFTREZGTGzx8q+6UXXS zZ8g1kJvPy2+AAfkx48C4DvCYAejkrTmrU2IoDNhQK+00FA8tUapR61Og+U7m5jVk3Nr CeYazCkSM6CI4gQ47nhtTODWMAS9RsPyt03z3OlXdfGiiayAZcJBWhTpNYfp9IWI9Dui brgQK37yVZodTIc1tD9lr+mC4evztPGbPgrXeb/hdVYiLCqmyhUWD//V05PGb1uAbOi7 NjDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688593922; x=1691185922; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pG5sHhRilqQNOqdg7J34jIBo6Ejr3LEqWSkoVpRsi9I=; b=dKElWEVWBfAy536awkSRp4Kchu1E6dt4wWQVDvy7D3AeKxUjcVAmYvIlEE/Ag+nN2V JJGY8J1+VRRVm4EDy+Z6Sxtxf4SrHG/tt6vrDau+nGMHrOpmmE4xsVKAEDanZuZAUT/5 Y1FwXWhkRhgzqUgM/e6XuXNvKeNTKG9LrxrT+jSjP9blY4eGr3GhEWf3yD4MohqAGJHw OJiMr4VFSRuSBceTrMsaq3IweOp43MQajTCXFYQ78G4ub94yMqCeTIZSGIRn7EIopv+F VXKyq4MKDnGOqZcgWdeseAl/IBQOEuG4sBYHo93Uraj6F9l82YuoO54vkzGW1m1XIqu+ c/Nw== X-Gm-Message-State: ABy/qLbpsbeUTFBePT/pZNkBZiIj5IjW9kZ22MyBzeuqv3f35b+mBUt9 bmh2HdeC10PJK8u///c10lMOAQ== X-Received: by 2002:a50:9fce:0:b0:519:7d2:e256 with SMTP id c72-20020a509fce000000b0051907d2e256mr21130edf.0.1688593921725; Wed, 05 Jul 2023 14:52:01 -0700 (PDT) Received: from localhost ([2a02:168:96c5:1:55ed:514f:6ad7:5bcc]) by smtp.gmail.com with ESMTPSA id u12-20020adfdd4c000000b0030ab5ebefa8sm87738wrm.46.2023.07.05.14.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 14:52:00 -0700 (PDT) From: Jann Horn To: Kees Cook Cc: Nathan Chancellor , linux-kernel@vger.kernel.org, Jann Horn Subject: [PATCH] ubsan: Clarify Kconfig text for CONFIG_UBSAN_TRAP Date: Wed, 5 Jul 2023 23:51:27 +0200 Message-ID: <20230705215128.486054-1-jannh@google.com> X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog MIME-Version: 1.0 X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770619461660189912?= X-GMAIL-MSGID: =?utf-8?q?1770619461660189912?= Make it clearer in the one-line description and the verbose description text that CONFIG_UBSAN_TRAP as currently implemented involves a tradeoff of much less helpful oops messages in exchange for a smaller kernel image. (With the additional effect of turning UBSAN warnings into crashes, which may or may not be desired.) Signed-off-by: Jann Horn --- lib/Kconfig.ubsan | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) base-commit: d528014517f2b0531862c02865b9d4c908019dc4 diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan index efae7e011956..e4f19ba9a029 100644 --- a/lib/Kconfig.ubsan +++ b/lib/Kconfig.ubsan @@ -13,7 +13,7 @@ menuconfig UBSAN if UBSAN config UBSAN_TRAP - bool "On Sanitizer warnings, abort the running kernel code" + bool "Abort on Sanitizer warnings (smaller kernel but less verbose)" depends on !COMPILE_TEST help Building kernels with Sanitizer features enabled tends to grow @@ -26,6 +26,14 @@ config UBSAN_TRAP the system. For some system builders this is an acceptable trade-off. + CAUTION: Selecting Y will (depending on architecture) cause your + kernel to oops with an undefined instruction error with no further + details when a UBSAN violation occurs. + (arm64 can show some basic information.) + This may make it hard to determine whether an oops was caused by + UBSAN or to figure out the details of a UBSAN violation. + It makes the kernel log output less useful for bug reports. + config CC_HAS_UBSAN_BOUNDS_STRICT def_bool $(cc-option,-fsanitize=bounds-strict) help