From patchwork Wed Jul 5 18:12:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 116293 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2056390vqx; Wed, 5 Jul 2023 11:26:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlGPtSb5iR6xOOlguyrhBIbUVW9i9wQxrUcWUX5tQU0nfOdkJtoGPJ/fJkvsrc8KVYfwAVgd X-Received: by 2002:a17:90b:3ec5:b0:263:70d1:ba84 with SMTP id rm5-20020a17090b3ec500b0026370d1ba84mr4315507pjb.18.1688581579349; Wed, 05 Jul 2023 11:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688581579; cv=none; d=google.com; s=arc-20160816; b=Cpt4HjRnJmL0iSMfZdn/eB+vrXTRsh8x5al8VHRkQ891Tx4OxchBNNu6iC2IaXMRyZ w7Bx4WU3t2uKs3R7pnpiumEb6GO5Wfcdvdu3blbcZLIQ4eRgXH7MxssZidp1dIUFlNW3 HyQCXHyM96iGIx64ggWvWqVCbYlbWWAqpNHLgPLiWpad1+8kH4VkuUFC0ZsKrqYtI8dJ tFn8fuh8w4+WhKgy4N1Pco3fDVZ/2bh6oOEX+KNw1CGOgX+FXfhCiKk5oQmI3HQjLfC7 CN18SDLb+zC93T+Nsg3ajnlZh8zV3LZyGm/vOrdmPElB3/FXpfF7c0iOF8Qu5VwugU1r Ji1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=touy8a7//BeI9DXwQuTy3DIG1jDKoaRDRv3dbDYYd7A=; fh=dVCMRuKhK2aqTEuWethYlqkP4G2sINJQEE+rq5xoO1c=; b=O8O6F0NybdSssByIPCdu/Q6vbBhFUokAxtL1miKmAPGefnNiYXJ4u9hahmzX69QdVl AswCMLZ7bYhHSaw4NkHBahuuM0lsOw/Hb9YMsDDfulyNRbIciVtOi6pZ570PgTvGFCVL h1ZvfOSLfoNt3lCmqjJEIdY2X3kCzJty22DRRiUe46oQ3jRYgw84VVMenb9Zgu2L4A0V VaFVcSrIrWrMkvwHFxukiatNCI3P3T+/na+m5ZHtaUcHz9HCmq5sdxMRsmPIKNckggEq 1zX18o4B0FI6fHKkJyRWiI7qxfTXGbUBIwyS/cf+75PKPKoDbLaB6h0unO1Z/cHoD+9D jotw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bRf0/gE2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id co5-20020a17090afe8500b002635333de96si2079545pjb.97.2023.07.05.11.26.04; Wed, 05 Jul 2023 11:26:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bRf0/gE2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233420AbjGESRj (ORCPT + 99 others); Wed, 5 Jul 2023 14:17:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233403AbjGESR2 (ORCPT ); Wed, 5 Jul 2023 14:17:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C1A1985 for ; Wed, 5 Jul 2023 11:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688581001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=touy8a7//BeI9DXwQuTy3DIG1jDKoaRDRv3dbDYYd7A=; b=bRf0/gE2Af75MWSNZa6GZtLmlRk10CBo3aTBBwDMg+36xwGoqleWJ21QUOgO4G/vqMyUPv UGQrPQzp06C56zVhhuBl2lHQpx7rWd4L3DUIyQYyY/P8CJ7GXLIPZuu45X5Usm6cOLCIAb Po/q/AyzuRQNuk0us1FXSYe87qmaRAI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-rTU3Fnz6O_mjXhT8Or3jrg-1; Wed, 05 Jul 2023 14:16:38 -0400 X-MC-Unique: rTU3Fnz6O_mjXhT8Or3jrg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BA218037BA; Wed, 5 Jul 2023 18:16:36 +0000 (UTC) Received: from vschneid.remote.csb (unknown [10.42.28.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 508F218EB4; Wed, 5 Jul 2023 18:16:31 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: [RFC PATCH 06/14] objtool: Flesh out warning related to pv_ops[] calls Date: Wed, 5 Jul 2023 19:12:48 +0100 Message-Id: <20230705181256.3539027-7-vschneid@redhat.com> In-Reply-To: <20230705181256.3539027-1-vschneid@redhat.com> References: <20230705181256.3539027-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770606118141061008?= X-GMAIL-MSGID: =?utf-8?q?1770606118141061008?= I had to look into objtool itself to understand what this warning was about; make it more explicit. Signed-off-by: Valentin Schneider --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 0fcf99c914000..fe62232f218f9 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3404,7 +3404,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { if (!target->sec->noinstr) { - WARN("pv_ops[%d]: %s", idx, target->name); + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); file->pv_ops[idx].clean = false; } }