From patchwork Wed Jul 5 14:40:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 116206 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1942075vqx; Wed, 5 Jul 2023 08:19:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlF2wIMYjc2psN7AjVRw3VRSuGIHQPosKwbhFUW1vBeCsyQNYjxznhv1C/ml/FEZLUpc7dyD X-Received: by 2002:a17:902:a518:b0:1b8:9958:e14b with SMTP id s24-20020a170902a51800b001b89958e14bmr5960312plq.10.1688570368271; Wed, 05 Jul 2023 08:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688570368; cv=none; d=google.com; s=arc-20160816; b=UBRxxxQ/2P+6hU2TzYEwtf/7YYQn1f9Ev8QoePtnWujd5+BBjstcRuItvDZSMvyhPB rU5IU/LjJnVCgtY7ddTnyWQi16lAgYpWHxr/Cy3EXfP31qABZ5+5eOBEJ33DOWNhx1Pn BicR/Szgx6Vp3lMw47PsbZFmQF4OvF65pCDnypYwLqXsYi+am3fXr16TI9pOUeJURqnm Rp96+4BNS039l8WvACe3myElOGdnbv16FPi6O6yunRmPWZN5W5v5qzhrbGJbl1xK/Ode ddUNyVghzWVtOlU+6xTzRbarVLFFWBMxg2BRQX2Td0kPPnvFf8FjB24pdWy+ZzsOSigK Sa9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=IJRwYplMq5Fm8Uc7UgjBy5V87RIPeDeeLT/0ygumdMw=; fh=X2mZDLcldxhaK9MSc+dq10Uj1WAEP/8G0M1cmQXYUVc=; b=QadUkK6HDvTvDotckXylPilxGgK5qkFgaWo5szBcGIGGgsqmiNokITVuKu7Soz8LKD Bl4VLCCvitwqEHlae6oAAuqJLWMRccAQ3UWrQtSHDIG6vljJ7wxqlcX8e1bR4SHPESU0 lh8U0kAu0Y54VfW2y7xgwctCtZUTCmm5oDv7RShv1pwHl/fmyqLMUEiPrPgGblKZtMZk tH0pjQgkY83aA9pBhZYMqCvV56bhOpmVouFrOFosd5hkzjqVK71zxBkuagIAflyhb0+N ZTK4wthkMwJyD7mxOwJT5cE7dde19Gr4+NZL0181dDPa3grZbWQqSZN1qU3zRv33oYWz wmKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a1709027fc600b0019e57f5a5aesi507531plb.567.2023.07.05.08.19.13; Wed, 05 Jul 2023 08:19:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232538AbjGEOqi (ORCPT + 99 others); Wed, 5 Jul 2023 10:46:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232113AbjGEOqf (ORCPT ); Wed, 5 Jul 2023 10:46:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D96F1B6; Wed, 5 Jul 2023 07:46:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98FB8612B1; Wed, 5 Jul 2023 14:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DA7BC433C9; Wed, 5 Jul 2023 14:46:32 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qH3m4-003Pgs-0D; Wed, 05 Jul 2023 10:46:32 -0400 Message-ID: <20230705144631.880308757@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 05 Jul 2023 10:40:32 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , stable@vger.kernel.org, Mateusz Stachyra Subject: [for-linus][PATCH 1/3] tracing: Fix null pointer dereference in tracing_err_log_open() References: <20230705144031.702796304@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770594362585811185?= X-GMAIL-MSGID: =?utf-8?q?1770594362585811185?= From: Mateusz Stachyra Fix an issue in function 'tracing_err_log_open'. The function doesn't call 'seq_open' if the file is opened only with write permissions, which results in 'file->private_data' being left as null. If we then use 'lseek' on that opened file, 'seq_lseek' dereferences 'file->private_data' in 'mutex_lock(&m->lock)', resulting in a kernel panic. Writing to this node requires root privileges, therefore this bug has very little security impact. Tracefs node: /sys/kernel/tracing/error_log Example Kernel panic: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000038 Call trace: mutex_lock+0x30/0x110 seq_lseek+0x34/0xb8 __arm64_sys_lseek+0x6c/0xb8 invoke_syscall+0x58/0x13c el0_svc_common+0xc4/0x10c do_el0_svc+0x24/0x98 el0_svc+0x24/0x88 el0t_64_sync_handler+0x84/0xe4 el0t_64_sync+0x1b4/0x1b8 Code: d503201f aa0803e0 aa1f03e1 aa0103e9 (c8e97d02) ---[ end trace 561d1b49c12cf8a5 ]--- Kernel panic - not syncing: Oops: Fatal exception Link: https://lore.kernel.org/linux-trace-kernel/20230703155237eucms1p4dfb6a19caa14c79eb6c823d127b39024@eucms1p4 Link: https://lore.kernel.org/linux-trace-kernel/20230704102706eucms1p30d7ecdcc287f46ad67679fc8491b2e0f@eucms1p3 Cc: stable@vger.kernel.org Fixes: 8a062902be725 ("tracing: Add tracing error log") Signed-off-by: Mateusz Stachyra Suggested-by: Steven Rostedt Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 64a4dde073ef..3d34e6fea6b2 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -8135,7 +8135,7 @@ static const struct file_operations tracing_err_log_fops = { .open = tracing_err_log_open, .write = tracing_err_log_write, .read = seq_read, - .llseek = seq_lseek, + .llseek = tracing_lseek, .release = tracing_err_log_release, };