From patchwork Wed Jul 5 14:42:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Obbard X-Patchwork-Id: 116186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1921834vqx; Wed, 5 Jul 2023 07:50:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlFLRT128ICi0Dv9EFgsl/HAcNIpvyZS5plCKN6NauvrLFfs5gqaYMQ0/9aVaroewe3ySEuR X-Received: by 2002:a17:90a:305:b0:25b:be3a:e6ae with SMTP id 5-20020a17090a030500b0025bbe3ae6aemr15679030pje.18.1688568622206; Wed, 05 Jul 2023 07:50:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688568622; cv=none; d=google.com; s=arc-20160816; b=W8CGbc5a/T/uYDGoVtquvEOFzfUBkGKUFRPetXgijuJOmP8QN9d4/mVdjgK65gGaGo 33o5ZLsTydKOvSpF20L3qpci6blnhbD2V9350hISuf/mXcKB4+LuIgQTHW6TXddgjUiw T94FBvUFQMW8SbFgLdXDw5arkUmrDGjs4gZM0C6+F8cXScHGivDZOw4rGINfFZnzKKa/ QxNvww/VtoMHup9hMg3c0A0DS9j34rhaqkOPui5N7tzz0LA5ZnH5nMGACHPa5oBx33CJ A7cLg/VlnJ1krtMifgnKV3O45XODySWMTlT5RcWsJWStD/LRD02s56sHcm1007lpKbSy DoVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eKXfOyJHvZW8tPNbOkcSSpAyRXXOOEZwpLMi8/rRq0c=; fh=W6WNxarNbL+2PJDK16W0xVA2DnArgD81JE2UvRQD644=; b=W0jyNi2UMI2xU5xk09qKtcYYv7E+TJZ5SJDeWGvybcylXcKdzhAC7eNBgEVwR3cFvt FJMwQx6M8EvLjlqlUzLOUIwuuZE0RvEor7C9RaVvAxO/5oM1DUNlJ4jhOorGJ44Oyh1y 3c0ZYPZlRTzCupFfGvCmifCdHu5dQL5fimajKG00Qll3QAiOPsB95jUQKeyoPNnzG1PJ xmdk4XoDph+QbJnkmmNPygb1ygMVbGjLDs0QYfhMi+5149BYY4xs0whA4bQ21Jh6vCvU c2oKQ0W1Mr9J1YBL8DK7qHO5XqITSI8+OFRcFkVwdNBI/FZ8NEmGucGXzhBKFl9Mkeq7 Aymw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=eCJKws57; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a8-20020a17090ad80800b0025c1ff9cd67si1701203pjv.184.2023.07.05.07.50.08; Wed, 05 Jul 2023 07:50:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=eCJKws57; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232276AbjGEOnZ (ORCPT + 99 others); Wed, 5 Jul 2023 10:43:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231857AbjGEOnT (ORCPT ); Wed, 5 Jul 2023 10:43:19 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4CBF1BC8; Wed, 5 Jul 2023 07:43:03 -0700 (PDT) Received: from obbardc-t14.home (unknown [IPv6:2a00:23c8:b70a:ae01:7599:ed26:1798:f430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: obbardc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 35DA16606FBC; Wed, 5 Jul 2023 15:43:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688568182; bh=V58cBnqk19ExhjbGA1KcziLl4pEqWwYt10fdubSKHPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eCJKws57Os/TNHkGMeIsQr10uHdrPTuGAqhHwMGkGzhXWzoLTs/dveUTQt1OORGV4 zZPvfXH8fWegzcL8oWKoyo3tj6O/hH0bfnk4QetgKnhnehDuzjz8XMT2t6VFpew2AC 1POWAKxZYd8H5VPN19pq2sxa/JstaXv6OA1pKpYgJnc1xQitaAXdlDZbWxhce+cJvN Yk2yevmq98l4+mdFH9UMguG/ajpF5msAfU7717QMFixGXDzzWpy9Z8lJeRXFsSzqfZ lAT0m+b5KleRUF/HjvYs2xNoLbqGSSiBjJWs8gejxZQIIRq697yJjEho5m8YAJrUUa lSWp4dDn1isLA== From: Christopher Obbard To: linux-rockchip@lists.infradead.org Cc: kernel@collabora.com, Christopher Obbard , Conor Dooley , FUKAUMI Naoki , Heiko Stuebner , Jagan Teki , Krzysztof Kozlowski , Manoj Sai , Rob Herring , Stephen Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2] arm64: dts: rockchip: Disable HS400 for eMMC on ROCK 4C+ Date: Wed, 5 Jul 2023 15:42:55 +0100 Message-Id: <20230705144255.115299-3-chris.obbard@collabora.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230705144255.115299-1-chris.obbard@collabora.com> References: <20230705144255.115299-1-chris.obbard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770592531797910272?= X-GMAIL-MSGID: =?utf-8?q?1770592531797910272?= There is some instablity with some eMMC modules on ROCK Pi 4 SBCs running in HS400 mode. This ends up resulting in some block errors after a while or after a "heavy" operation utilising the eMMC (e.g. resizing a filesystem). An example of these errors is as follows: [ 289.171014] mmc1: running CQE recovery [ 290.048972] mmc1: running CQE recovery [ 290.054834] mmc1: running CQE recovery [ 290.060817] mmc1: running CQE recovery [ 290.061337] blk_update_request: I/O error, dev mmcblk1, sector 1411072 op 0x1:(WRITE) flags 0x800 phys_seg 36 prio class 0 [ 290.061370] EXT4-fs warning (device mmcblk1p1): ext4_end_bio:348: I/O error 10 writing to inode 29547 starting block 176466) [ 290.061484] Buffer I/O error on device mmcblk1p1, logical block 172288 [ 290.061531] Buffer I/O error on device mmcblk1p1, logical block 172289 [ 290.061551] Buffer I/O error on device mmcblk1p1, logical block 172290 [ 290.061574] Buffer I/O error on device mmcblk1p1, logical block 172291 [ 290.061592] Buffer I/O error on device mmcblk1p1, logical block 172292 [ 290.061615] Buffer I/O error on device mmcblk1p1, logical block 172293 [ 290.061632] Buffer I/O error on device mmcblk1p1, logical block 172294 [ 290.061654] Buffer I/O error on device mmcblk1p1, logical block 172295 [ 290.061673] Buffer I/O error on device mmcblk1p1, logical block 172296 [ 290.061695] Buffer I/O error on device mmcblk1p1, logical block 172297 Disabling the Command Queue seems to stop the CQE recovery from running, but doesn't seem to improve the I/O errors. Until this can be investigated further, disable HS400 mode on the ROCK Pi 4 SBCs to at least stop I/O errors from occurring. Fixes: 246450344dad ("arm64: dts: rockchip: rk3399: Radxa ROCK 4C+") Signed-off-by: Christopher Obbard --- arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts index 028eb508ae30..8bfd5f88d1ef 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts @@ -548,9 +548,8 @@ &saradc { &sdhci { max-frequency = <150000000>; bus-width = <8>; - mmc-hs400-1_8v; + mmc-hs200-1_8v; non-removable; - mmc-hs400-enhanced-strobe; status = "okay"; };