From patchwork Wed Jul 5 14:42:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christopher Obbard X-Patchwork-Id: 116189 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1923550vqx; Wed, 5 Jul 2023 07:53:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlG5G8Aj5cHGYhWiflgXtWiuIUF24kAMRqZQfEls5rQqD6TYP15WQzDgVMAyO0D1ShuO42oy X-Received: by 2002:a05:6a20:7488:b0:12f:bca:b16a with SMTP id p8-20020a056a20748800b0012f0bcab16amr4993884pzd.30.1688568820265; Wed, 05 Jul 2023 07:53:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688568820; cv=none; d=google.com; s=arc-20160816; b=smLRPfR5Te5jnBQF9HVwPI+xXbZHaw+G51CqmnNK/bJK8/sxqC9/AzqLIMAcLWhklY jJ83Fk8Ii5gYxuG0h8RfdCaZztO6NPYlCfuLgB5uyG4886GuS39/bDSBH2Ar4PdWgUS6 B1i0aeZB8JBPLE0YK5+aT1wjdw2tUY6J5gpktlxilHhX0aPWCfJjYrQrIOom1Og+OMkM lfc5XhMPihsdUyeVA3nHI+xPD6iMFQA0GZlnpSTjyQz7Wy/M52qJXUoCwQysQwHi3KZX odaKpi5lfGEKKb0BxDxxb7UALHwuEDzDchpBx1ut+3vmfAkpKb7skWIi7S2t/cc1RfEH ewmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0hFVC4N/ST6mrBKaIzfr80z+mZg0V7i5AwnnSICWnzo=; fh=ucB4hWULtXGRPBmwhWYoVZz5HToxpUPFx+01SSg/F0Y=; b=WaRKdofq7d6DxIIRX1pcEprftzFz9Vr8L/zfIzjNRBvXW4++lzGzzv+a1l8jArNNoh B4sRH3V5Cr0whXJ25DBlknd4eECHPiPcqaOZKpAOigCM3GK6sw5JYh1cbASvafHgKmDv 72o8OL92810SxzG1CBhwLnhcXi6DgsF8upnz9VkBMYpHOn8omkUzufTcLw+N8w/bf39Q Jh8gAUWkkigJsyUjrb9cZZsqqoU7RbCkg8c3OJcKro+77RcD9fbc2jBFOTGmaPB6O8bE aRabK2AOP25g6qCsX2UXNKgXhuhJ9pJpauNL9UlBX1uMkL9vGE2GEaF0cg2Ltzsl+lSy 6wTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=A2hNM1Zm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b0054fef6280d1si24349322pgh.745.2023.07.05.07.53.27; Wed, 05 Jul 2023 07:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=A2hNM1Zm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232196AbjGEOnW (ORCPT + 99 others); Wed, 5 Jul 2023 10:43:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232611AbjGEOnS (ORCPT ); Wed, 5 Jul 2023 10:43:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76CA91BC6; Wed, 5 Jul 2023 07:43:03 -0700 (PDT) Received: from obbardc-t14.home (unknown [IPv6:2a00:23c8:b70a:ae01:7599:ed26:1798:f430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: obbardc) by madras.collabora.co.uk (Postfix) with ESMTPSA id B7BFE6606FBA; Wed, 5 Jul 2023 15:43:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688568181; bh=uPaYPRBzOqPzhs7FH+a97cBKmRbQaU3/eRl8Hl4t9z4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A2hNM1ZmvLZ2ham6FGonveGJiwK9UZbmqzgcCkRfqPOTpM7KFaX9itSzRzJTcJFmR DY1OTZaAKpKTbIOujbgh/oyyQwREsRzY/I2uzWVvnM9XPE42PSsafBGfYkW0GQQRsS t8MzAz2sORC51PBadMdhW5y/uT8fTmsdmD+3BdI4uQ2Lb93fjs+ItBTM/VVTll98d8 RP9JjkPcCe3wen1CWcoOBnshnDU3dzOtg0y5eFa9oHVmvEv/4l6NLvfnMUNXPxKu11 fHshVc5tqSej1UpBNspfgT2Tfg6JDMFe/cBOuc0FDyF0yI10DnWRU2+m8is2SkMeY6 RHHaXwZmCtgfw== From: Christopher Obbard To: linux-rockchip@lists.infradead.org Cc: kernel@collabora.com, Christopher Obbard , Akash Gajjar , Conor Dooley , FUKAUMI Naoki , Heiko Stuebner , Jagan Teki , Krzysztof Kozlowski , Pragnesh Patel , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] arm64: dts: rockchip: Disable HS400 for eMMC on ROCK Pi 4 Date: Wed, 5 Jul 2023 15:42:54 +0100 Message-Id: <20230705144255.115299-2-chris.obbard@collabora.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230705144255.115299-1-chris.obbard@collabora.com> References: <20230705144255.115299-1-chris.obbard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770592739450383940?= X-GMAIL-MSGID: =?utf-8?q?1770592739450383940?= There is some instablity with some eMMC modules on ROCK Pi 4 SBCs running in HS400 mode. This ends up resulting in some block errors after a while or after a "heavy" operation utilising the eMMC (e.g. resizing a filesystem). An example of these errors is as follows: [ 289.171014] mmc1: running CQE recovery [ 290.048972] mmc1: running CQE recovery [ 290.054834] mmc1: running CQE recovery [ 290.060817] mmc1: running CQE recovery [ 290.061337] blk_update_request: I/O error, dev mmcblk1, sector 1411072 op 0x1:(WRITE) flags 0x800 phys_seg 36 prio class 0 [ 290.061370] EXT4-fs warning (device mmcblk1p1): ext4_end_bio:348: I/O error 10 writing to inode 29547 starting block 176466) [ 290.061484] Buffer I/O error on device mmcblk1p1, logical block 172288 [ 290.061531] Buffer I/O error on device mmcblk1p1, logical block 172289 [ 290.061551] Buffer I/O error on device mmcblk1p1, logical block 172290 [ 290.061574] Buffer I/O error on device mmcblk1p1, logical block 172291 [ 290.061592] Buffer I/O error on device mmcblk1p1, logical block 172292 [ 290.061615] Buffer I/O error on device mmcblk1p1, logical block 172293 [ 290.061632] Buffer I/O error on device mmcblk1p1, logical block 172294 [ 290.061654] Buffer I/O error on device mmcblk1p1, logical block 172295 [ 290.061673] Buffer I/O error on device mmcblk1p1, logical block 172296 [ 290.061695] Buffer I/O error on device mmcblk1p1, logical block 172297 Disabling the Command Queue seems to stop the CQE recovery from running, but doesn't seem to improve the I/O errors. Until this can be investigated further, disable HS400 mode on the ROCK Pi 4 SBCs to at least stop I/O errors from occurring. While we are here, set the eMMC maximum clock frequency to 1.5MHz to follow the ROCK 4C+. Fixes: 1b5715c602fd ("arm64: dts: rockchip: add ROCK Pi 4 DTS support") Signed-off-by: Christopher Obbard Tested-By: Folker Schwesinger Signed-off-by: Christian Kohlschütter Signed-off-by: Mark Brown --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi index 907071d4fe80..95efee311ece 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi @@ -645,9 +645,9 @@ &saradc { }; &sdhci { + max-frequency = <150000000>; bus-width = <8>; - mmc-hs400-1_8v; - mmc-hs400-enhanced-strobe; + mmc-hs200-1_8v; non-removable; status = "okay"; };