From patchwork Tue Jul 4 07:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 115600 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1046171vqx; Tue, 4 Jul 2023 00:54:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHVgnrRoi/+qRctKrcJZbvGhuA3d9CtqwlEEWwfk7Yvd0xCquDL8OeaMEiikmDb9vAJctCY X-Received: by 2002:a17:90a:c918:b0:262:ebfd:ce44 with SMTP id v24-20020a17090ac91800b00262ebfdce44mr10488976pjt.34.1688457268858; Tue, 04 Jul 2023 00:54:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688457268; cv=none; d=google.com; s=arc-20160816; b=CeqqhvU8EXGXdLRFpm7xB6X/s+xCcM1gFNnu5iTkcp0ulAIjC8h6R+c3KXhsHF0Z4C Z4G9ChYgLs/dblSdEvPxs7LzuY+fOzBdwjMqXHcGlQ0R9K3eMcD7NS/V2xw5zy5qM0Zt Kl/KvBjljDM44AX4j+y4Z1lbl4RHfXvxhkcljcJZJpagNBBBqKboOcr0Guuxq/OZOXbQ mzdtxRrnuPln8+JUC9+k/Isf+RdxzbcnUTGkhsl0ZAcPbGk5qoZwhZ6SRI30FxtTyVWE vXUHhNXiHf+gXAcnaJYxLVH9Y0T3lUyrA16oeoXkEIlgY88zfGoygWAcRUs2FW2z+eTM TQ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wZ0C2lkfZax7VbHphMYzhRUt0SW6Xd4bATRJOGN1W4M=; fh=td1tWwqmzXUMurl83U4wnxYbX8ZMZukrMraSvbRxzQ0=; b=hQPvXwxegczwtxv6ts+lnyqPaM/YnJBG/ZI9QxZdchk3DeYoyyohbtXOsS7XjHAal5 wrFyDvV1P5MYi5NkXgmE6z+Qv2T8XucrmwcUz3q0iO0TAiWgkZsLcWx5RodKgdbwb6pj /ICD3vE3cpZV3kjTo+uijqQS1jnyHgd6cSk0yroZ1O5e4NgIrWKkuNWHZYclcst7BHG2 XuLO/OkYY7q2fZ0Fa/RClR5riN+uDT4SjwvEX93B5iQFYT07n3hzctq1MpdC6Da0iGhI XY/1NTzXpWhSVYFwYYwiypGldZrXfWtCGYPEX5+zSEYy4Nv71oSiGTkC2cp2sjYDC/ly BtGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 15-20020a63164f000000b005574bef6f31si20295271pgw.490.2023.07.04.00.54.14; Tue, 04 Jul 2023 00:54:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbjGDHou (ORCPT + 99 others); Tue, 4 Jul 2023 03:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbjGDHoa (ORCPT ); Tue, 4 Jul 2023 03:44:30 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E766CE6D; Tue, 4 Jul 2023 00:44:23 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwFCD5pDkzTm8c; Tue, 4 Jul 2023 15:43:20 +0800 (CST) Received: from localhost.localdomain (10.67.174.95) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 15:44:21 +0800 From: Yang Jihong To: , , , , , , , , , , , CC: Subject: [PATCH 3/5] perf record: Tracking side-band events for all CPUs when tracing selected CPUs Date: Tue, 4 Jul 2023 07:42:15 +0000 Message-ID: <20230704074217.240939-4-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20230704074217.240939-1-yangjihong1@huawei.com> References: <20230704074217.240939-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.95] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770475744171711252?= X-GMAIL-MSGID: =?utf-8?q?1770475769314659751?= User space tasks can migrate between CPUs, we need to track side-band events for all CPUs. The specific scenarios are as follows: CPU0 CPU1 perf record -C 0 start taskA starts to be created and executed -> PERF_RECORD_COMM and PERF_RECORD_MMAP events only deliver to CPU1 ...... | migrate to CPU0 | Running on CPU0 <----------/ ... perf record -C 0 stop Now perf samples the PC of taskA. However, perf does not record the PERF_RECORD_COMM and PERF_RECORD_COMM events of taskA. Therefore, the comm and symbols of taskA cannot be parsed. The sys_perf_event_open invoked is as follows: # perf --debug verbose=3 record -e cpu-clock -C 1 true Opening: cpu-clock ------------------------------------------------------------ perf_event_attr: type 1 size 136 { sample_period, sample_freq } 4000 sample_type IP|TID|TIME|ID|CPU|PERIOD read_format ID|LOST disabled 1 inherit 1 freq 1 sample_id_all 1 exclude_guest 1 ------------------------------------------------------------ sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 5 Opening: dummy:HG ------------------------------------------------------------ perf_event_attr: type 1 size 136 config 0x9 { sample_period, sample_freq } 4000 sample_type IP|TID|TIME|ID|CPU|PERIOD read_format ID|LOST inherit 1 mmap 1 comm 1 freq 1 task 1 sample_id_all 1 mmap2 1 comm_exec 1 ksymbol 1 bpf_event 1 ------------------------------------------------------------ sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 6 sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 7 sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 9 sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 10 sys_perf_event_open: pid -1 cpu 4 group_fd -1 flags 0x8 = 11 sys_perf_event_open: pid -1 cpu 5 group_fd -1 flags 0x8 = 12 sys_perf_event_open: pid -1 cpu 6 group_fd -1 flags 0x8 = 13 sys_perf_event_open: pid -1 cpu 7 group_fd -1 flags 0x8 = 14 Signed-off-by: Yang Jihong --- tools/perf/builtin-record.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 8872cd037f2c..69e0d8c75aab 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -908,6 +908,31 @@ static int record__config_off_cpu(struct record *rec) return off_cpu_prepare(rec->evlist, &rec->opts.target, &rec->opts); } +static int record__config_tracking_events(struct record *rec) +{ + struct evsel *evsel; + struct evlist *evlist = rec->evlist; + struct record_opts *opts = &rec->opts; + + /* + * User space tasks can migrate between CPUs, so when tracing + * selected CPUs, sideband for all CPUs is still needed. + */ + if (opts->target.cpu_list) { + evsel = evlist__findnew_tracking_event(evlist); + if (!evsel) + return -ENOMEM; + + if (!evsel->core.system_wide) { + evsel->core.system_wide = true; + evsel__set_sample_bit(evsel, TIME); + perf_evlist__propagate_maps(&evlist->core, &evsel->core); + } + } + + return 0; +} + static bool record__kcore_readable(struct machine *machine) { char kcore[PATH_MAX]; @@ -4235,6 +4260,12 @@ int cmd_record(int argc, const char **argv) goto out; } + err = record__config_tracking_events(rec); + if (err) { + pr_err("record__config_tracking_events failed, error %d\n", err); + goto out; + } + err = record__init_thread_masks(rec); if (err) { pr_err("Failed to initialize parallel data streaming masks\n");