From patchwork Tue Jul 4 07:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Z qiang X-Patchwork-Id: 115590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1035336vqx; Tue, 4 Jul 2023 00:27:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5COsJmYimq+ktLgwEQvnxwQbHC6lZ006LGkajVB2tqEyW9o3nyUEbESTwSiGQg9P7W8G9T X-Received: by 2002:a05:6808:11ce:b0:3a3:7245:6296 with SMTP id p14-20020a05680811ce00b003a372456296mr11049055oiv.0.1688455651906; Tue, 04 Jul 2023 00:27:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688455651; cv=none; d=google.com; s=arc-20160816; b=mkZwIUCeO0O3aa0QOESghoVJl7QxXWMfekoLK0sziaK7LYS1nxmZqGW7SBBvOdlbFi D2WFk1ohBvsySzzkjtfpEEfVjPMleg6h77wo1aedQh82ULnI5yv3wciGRsRt4ffnGkML vIXbpyGb5LywX3l1W+U76JUHKLQ5yEsbfrklxks1UKaq4PNSA6EVwG6zxPYxZJdIEtfr s6kC2gi37oekKtg1SBwiZsHp6xb3upjk9IiLcwIA3z0PQegr2KXvGchQV8opFTQHump0 ItH3Hl60LYHedcPGg9KFFvO2/RCFVMC3hsulqvKnOrZZ2onH4L8uARUsaSrZoehl4B9R HVtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=3QSBORDVW5k2buwTkXzNiNoPGGqOZzae03kTOF+RVSo=; fh=gBHKmotWusbmxz5JEuHA/RTvfoLB0D9BR2NQ7/FrpLw=; b=JdE4ZSqOjtOh+GbdI9j9W0t+M12o+YofhA99/N0agLIX4+o94TEVF5Kb3Qd4Q7nFMU aIHUU3q1d9MINS8AMStNUpJJ5m6sV7CdQxWwVhybkYOBwWCHijPa3RwU/xFHZaJjc+aq YVgvdxEknfVitzrwKxYf91CfN5zEYfByZLkEH2edviM6hFHMbj833+aG7lauuyMq8Iq9 c1iWltUtIdWfN5F66WLhj239p1vhymn1ghyv6S4O5q24iz9STu9bpEe0QKuQl6brxzYI UsRlfHv/GeYMT7nxN6Y7mw/DtB7s6/0DLP3rWXgOaWEIidi7sj3892fdTyVgFzd5YDgl nRiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=PYEOW9zI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l190-20020a6391c7000000b0055b5df8d644si9278208pge.137.2023.07.04.00.27.19; Tue, 04 Jul 2023 00:27:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=PYEOW9zI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbjGDHIV (ORCPT + 99 others); Tue, 4 Jul 2023 03:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbjGDHIT (ORCPT ); Tue, 4 Jul 2023 03:08:19 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D982136; Tue, 4 Jul 2023 00:08:19 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b89114266dso17126935ad.0; Tue, 04 Jul 2023 00:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688454498; x=1691046498; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3QSBORDVW5k2buwTkXzNiNoPGGqOZzae03kTOF+RVSo=; b=PYEOW9zIgAsNL9l0PbiWAISqeRxsMFljrPe3hyFhDFaDU3UmiRt0RpA9G0y/acDdGX l7/Jd7OxLmjKKZpKJ8vnGlqfvyzwjnYXbi+38gIY6nlWPiwfWcxmpas1y31MJqLr0ATD 1uVeyMerVkE1YtkAHO6zB+JrsCxZqHVKPvaNti5NCdq0BmTwKQe5VARd57IGTyRHuEee jyfhVW+w3BeMVEMwSFTngE4eh+y7KV2jTvvGdpjcOqpBuoLbe4sgj+jE0crgNG6nPESl sgpxm5GJdbsP+LpTczWZV+neZpcjefWiRphS0HCac6yPzUH1h/6Ypwr2t0c9RvCg18rL l/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688454498; x=1691046498; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3QSBORDVW5k2buwTkXzNiNoPGGqOZzae03kTOF+RVSo=; b=exHzuzNrJ/2byVKKTCYMee5lkaTXkeUoqmj/jcoTZcIOBeh7jCMVXLBqHOU3TFE76N e40MJ/r3zdFTu6rOPjKXpoV2CL9Lr354moB8dAzgBe4V86gUuSjm3N307jHA25uu0ILV 2J6I483EAT0rtT7+g3TC/1MrHG0DbZpRew2WSe8Ap4vVU9V5R7Vd9OChZPTHm5utHjLw qMuUZPNyfbBQBZlGIjxd2n9qkHmDoUIPUAVvVWwqeefSHOHeaNhcvXGhFSdBCmr8jM48 mTMM419Eu6+bJ3HGxo82vC/J6n+fd8Y8pZUKFSnTMVZrpV2vEkEGxQCWRuRROwEMhs0P f/3Q== X-Gm-Message-State: ABy/qLbD/cw4TyZf//XfuoHpmjSfL8rYWCLSOsmV8vDxlLPQi/uo5Tu4 Hh1qn2XmCueWw+YovLiTx4Y= X-Received: by 2002:a17:903:2594:b0:1b2:28ca:d16 with SMTP id jb20-20020a170903259400b001b228ca0d16mr12878627plb.44.1688454498470; Tue, 04 Jul 2023 00:08:18 -0700 (PDT) Received: from MSCND1355B05.fareast.nevint.com ([183.242.39.186]) by smtp.gmail.com with ESMTPSA id be4-20020a170902aa0400b001b52891bd45sm16395497plb.57.2023.07.04.00.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 00:08:17 -0700 (PDT) From: Zqiang To: paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, joel@joelfernandes.org, qiang.zhang1211@gmail.com Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] srcu: Priority check rcu_gp_is_expedited() in synchronize_srcu() Date: Tue, 4 Jul 2023 15:08:09 +0800 Message-Id: <20230704070809.31951-1-qiang.zhang1211@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770474074037410301?= X-GMAIL-MSGID: =?utf-8?q?1770474074037410301?= Since the atomic variable rcu_expedited_nesting is initialized to true, so the rcu_gp_is_expedited() is always return true during system startup until the rcu_end_inkernel_boot() is called. this means that without setting rcupdate.rcu_normal=1 and before the rcu_end_inkernel_boot() is executed, regardless of whether the return value of srcu_might_be_idle() is true, call synchronize_srcu() always fall back to synchronize_srcu_expedited(), so there is no need to checking srcu_might_be_idle() return value. For the rcupdate.rcu_normal=0, rcupdate.rcu_normal_after_boot=0 and rcupdate.rcu_expedited=1 kernels, there is also no need to checking srcu_might_be_idle() return value. This commit therefore priority check rcu_gp_is_expedited() return value in synchronize_srcu(). Signed-off-by: Zqiang --- kernel/rcu/srcutree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 20d7a238d675..a819f11d9b90 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -1435,7 +1435,7 @@ EXPORT_SYMBOL_GPL(synchronize_srcu_expedited); */ void synchronize_srcu(struct srcu_struct *ssp) { - if (srcu_might_be_idle(ssp) || rcu_gp_is_expedited()) + if (rcu_gp_is_expedited() || srcu_might_be_idle(ssp)) synchronize_srcu_expedited(ssp); else __synchronize_srcu(ssp, true);