From patchwork Mon Jul 3 18:08:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 115449 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp706445vqx; Mon, 3 Jul 2023 11:18:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlE3l5ZIRELNRO6VbAsxss2xJhhTOaHch2jXD/STtO+ywMhsbakUErPAdmaO2yItHQfmW7JQ X-Received: by 2002:a05:6a00:138a:b0:675:8521:ddc7 with SMTP id t10-20020a056a00138a00b006758521ddc7mr13721433pfg.0.1688408279991; Mon, 03 Jul 2023 11:17:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688408279; cv=none; d=google.com; s=arc-20160816; b=iqjS8WEY8ci2DMVZWopuMCm5MdMjolpPM5Bp3ziRorzmWjxf592tuaoPgveHRxQmJu YFO5GdFJx0H+YxoyjiBWCRXaN4I6KZA22aFVARpGTz0SeUsxdaWt7shMjBu2JTXYTn4d GZGX1HoNy9Ms6aeQVVRa5itHGidC26oBS+0DejM1Y/+gEcdzyDXcsaRyvO3aX2msStHV v3egLX/6zZ9365t4akOXgQKYdccf3/LMoZhlLS89yIIIXvT9SdTvvgOe7+jO7tqqEzxF Qrlqlod6RpT9k7n9+U5A7qN9R0lL7jJOF+VA9PMgulOSuIFA1ZtrQibHFSf//XgSUT3G bX/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3auGkEfHhpz3BrAdAF5f41VUjnbVwTpR8M5csxbDscI=; fh=5nCoz5CO/cY8MM93RStXHydQaC+x20mkVe8y8vJYm8c=; b=fHj0hIb3Es1ths5QVV7R8dyG3xCPw5KBj2IQln5A4n0WMAE7JdJ6/rcCHcI9sa0hQU jdGtwE6zC5dXBxAGSX3LElYqr3BSWf//4xAj4S6yIiFaVMVyDZfe25/pH7Me+xkenyi5 XBil/9bCC7kDZ+aDkKMDZgTwJG/x6w8zJUPJx65ERRwZE17XkAuL26+22g9SkCs/In7L hH/3rlDbO8RbZJVPVwKu48YgGz6kE2/Xi/scOhM3lD+0PkvqtSOsvUdz18kthqvk0Rz1 9hgN7veMiSe0/PPjmkC7DIjWjJjh4x6Lsq8Aqwvv7oYf+hJs39lC7ensgkyuqYeLbQth XnfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZwP4nUR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j192-20020a638bc9000000b00542b1792242si18841455pge.720.2023.07.03.11.17.45; Mon, 03 Jul 2023 11:17:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZwP4nUR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbjGCSIa (ORCPT + 99 others); Mon, 3 Jul 2023 14:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbjGCSI2 (ORCPT ); Mon, 3 Jul 2023 14:08:28 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B929EE6B for ; Mon, 3 Jul 2023 11:08:27 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-666eba6f3d6so2234859b3a.3 for ; Mon, 03 Jul 2023 11:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688407707; x=1690999707; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3auGkEfHhpz3BrAdAF5f41VUjnbVwTpR8M5csxbDscI=; b=ZwP4nUR3WFNFmNuz2S9cZpy4kVhWdJRsayBoNlmnBRgP37jBLoGHam82DMmysAeGOQ k0oA2997jN0LqeFMiRZh5uwApco9D76BxHdR20QQjbWcjv7/X2UIge7fe/qM6o+0Ra3W wxVb5kWJd/pTpjL6Lie8eJ+Xo+u9MmSUUoLXXddYLjs2A9HSn51vZ3Tx0sIRlibTXQ3c 851sIYyF3bhRvFpxVGU9GGbEKMXDbTC/pjFkGEjTMxWRlRlq6OBR+nVt+lC8WRYFdXGy LACACf8tg6xgXL7dBKkO642tA6yYZLoZBP0BxJ5w2XpGnyb1SeXnHWQh34pY7svq9xiV Zs9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688407707; x=1690999707; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3auGkEfHhpz3BrAdAF5f41VUjnbVwTpR8M5csxbDscI=; b=XKGjH619NdLebhotOJhsUQf8tsGbZD3/tXoFxBjLH3TRKtl9HBMuwt1xImW6NS9Bav sLJXDTv5+atgluO5hD8FKZpdmgJs1iiyswyW0tbPspyQvaKXdAUGNYi+WuFrfIB3kOQX Q1ewXKFZ1CFlYnkMnwJGYOhBJ0ZkRzuslOOT2hkDMxNw648HO1zJ2LYJ9uurwoc4u2Qj yKU/wMAnQ2y39t6Fmr7fr/OwCJFaoY5M7SwZatIv4jLDWYkasa4wTVqJJrE7p7arVvnJ EwPQk0pjij9ONxyUpdc46wKBLf3SYoOPhIfvB1zrky7RZt41C1UcStT4a2vc+kJr2S8C 81Wg== X-Gm-Message-State: ABy/qLZLxg9OVnawtRZ9prHvfC7gG2W3zRbqWAgogUfgBmZlCzjMbC8h mUJcjRCDQqTsLTY4Yn3FQomOVlMZ8Hk= X-Received: by 2002:a62:7b0e:0:b0:682:3126:961a with SMTP id w14-20020a627b0e000000b006823126961amr9464622pfc.5.1688407706528; Mon, 03 Jul 2023 11:08:26 -0700 (PDT) Received: from octofox.hsd1.ca.comcast.net ([2601:646:a201:19d0:feb2:139d:d966:84b8]) by smtp.gmail.com with ESMTPSA id n13-20020aa7904d000000b0063a04905379sm14337172pfo.137.2023.07.03.11.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 11:08:25 -0700 (PDT) From: Max Filippov To: linux-kernel@vger.kernel.org Cc: Chris Zankel , Max Filippov Subject: [PATCH] xtensa: ISS: fix call to split_if_spec Date: Mon, 3 Jul 2023 11:08:22 -0700 Message-Id: <20230703180822.1346356-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770424400560570864?= X-GMAIL-MSGID: =?utf-8?q?1770424400560570864?= split_if_spec expects a NULL-pointer as an end marker for the argument list, but tuntap_probe never supplied that terminating NULL. As a result incorrectly formatted interface specification string may cause a crash because for the random memory access. Fix that by adding NULL terminator to the split_if_spec argument list. Fixes: 7282bee78798 ("[PATCH] xtensa: Architecture support for Tensilica Xtensa Part 8") Signed-off-by: Max Filippov --- arch/xtensa/platforms/iss/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c index 7b97e6ab85a4..85c82cd42188 100644 --- a/arch/xtensa/platforms/iss/network.c +++ b/arch/xtensa/platforms/iss/network.c @@ -237,7 +237,7 @@ static int tuntap_probe(struct iss_net_private *lp, int index, char *init) init += sizeof(TRANSPORT_TUNTAP_NAME) - 1; if (*init == ',') { - rem = split_if_spec(init + 1, &mac_str, &dev_name); + rem = split_if_spec(init + 1, &mac_str, &dev_name, NULL); if (rem != NULL) { pr_err("%s: extra garbage on specification : '%s'\n", dev->name, rem);