From patchwork Mon Jul 3 12:18:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115337 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp489670vqx; Mon, 3 Jul 2023 05:38:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlGInQO2k7n/xWc4cqsltCi+No8sbFwhBp16jPeOnoesdsligX45EniCyCv+LlPIGXms+lEm X-Received: by 2002:a17:90b:2396:b0:262:f76d:b29c with SMTP id mr22-20020a17090b239600b00262f76db29cmr11571045pjb.2.1688387911276; Mon, 03 Jul 2023 05:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688387911; cv=none; d=google.com; s=arc-20160816; b=nzh0kP10HKQLJHGH4SmK+KifVigD1WztJIddnjNgX+8VTY4ElYgFOckzvrQrTmVZdP 5IM+DPkA+vNKlcp0l9+zsEGF13mxJjpRn/gd5A5DZQ0XakqStzzZQGqxbIJkuWnSWOfS 87W5md0wd3sFutiKaGr/OSF0GLbs7G94pq+OCxpl4VSQvsJxc+dXgB9TLMc/VvH1n9MR 8AqWwLyVLfmCtBNrMz2yqZptQjRMnuKJCyUKfiet1UvgpLX3fdGPeq9aupjh/IvtG0/t iE563FpV8jxYBIexm5NqeVKvtmtAcJAa5FNZAI6CsP5VmBA/kJXx26lL13X9jJwPyRjM IbwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nQ3Ua329JQBrIn5E7PHm38P7KUkSSRuzn9c+QpGOAVU=; fh=pnZ7JKqo4a1NkH5BtCuwVXjSzsf2RF1cbw2rekbMd8g=; b=bL3W3A/DfhF/zYieI4kJPk/PChWKAY9ctAQMJlSjNa3fgCfybB4hDRFltrU2qjTf1g 9DT/VUiX173uFeJbapPgRCE1wTYDlV06stMTon54QQ/xC6iDn6y4+KmORvNayOT5WNCU veaaxHh6LPEmSrPRUmZ3EG3U0EoZB2OlE0gk4LPadL+cjhyL/L5G6NUiYUY3gh/Jlthe 0nYwiMxPfRWGBTgEqQxaC4/x3RryxIC5ElgJ0/hXOTQDNEKsO8XqHynBjY3jP79vC6wt /lzvJT+OoKU2PEs+rgkTlJPCwbQfuECcK3IKKs/NQS0+B7uR/4/UtYAqkYZE3vUeka99 Nx0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GUqLaMmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk13-20020a056a02028d00b0055b0f40083dsi12271573pgb.560.2023.07.03.05.38.10; Mon, 03 Jul 2023 05:38:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GUqLaMmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbjGCMS4 (ORCPT + 99 others); Mon, 3 Jul 2023 08:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbjGCMSt (ORCPT ); Mon, 3 Jul 2023 08:18:49 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA3410E; Mon, 3 Jul 2023 05:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688386728; x=1719922728; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f5cSMS9Hc/IEGZhdqhDLhD3xAE26SJ8iHGtEWOKDz/4=; b=GUqLaMmnCfAMT1FkTY3g/JBFtHgAbOAk4wIzHmyYLFv68uwpkhpBbGfx 1QzTVRFGjDX8eBKhKSo+Znc4JBeweHOUuRkXDZYucw2I/0HyuX//Q21Vj 7czSzPjc6X4jRrzZ3KVp+6jiBILbhC9UdY2N+fmL0ZvT7MzN+ttb0gERz Q6Eut9fYtPJD8Gvgt/ZQ5xUIClNyKUHx7RKYISmcbF1Pfau19ZROuVkzf EeFJWKOpn/J4QFs0Xy/NIQv8H1YeBxPRIge3CpFmUC4LV6Mr9ly+Se7PI vlkVqqsBS7/Jc81Xfz2cyIgMVWxdlhrUeICi6BO32nE45x9zEyUpoto5c g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="449242344" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="449242344" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 05:18:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="863065885" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="863065885" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2023 05:18:39 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 22F6113C; Mon, 3 Jul 2023 15:18:42 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Dmitry Torokhov , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Benjamin Tissoires Subject: [PATCH v1 1/3] gpiolib: of: Don't use GPIO chip fwnode in of_gpiochip_*() Date: Mon, 3 Jul 2023 15:18:36 +0300 Message-Id: <20230703121838.70898-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230703121838.70898-1-andriy.shevchenko@linux.intel.com> References: <20230703121838.70898-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770403042715921601?= X-GMAIL-MSGID: =?utf-8?q?1770403042715921601?= GPIO library should rely only on the GPIO device's fwnode. Hence, replace GPIO chip fwnode usage by respective OF node from GPIO device. JFYI, this is partial revert of 8afe82550240 ("gpiolib: of: Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode"). Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib-of.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 1436cdb5fa26..5fde5a3f5118 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -1078,16 +1078,16 @@ int of_gpiochip_add(struct gpio_chip *chip) if (ret) return ret; - fwnode_handle_get(chip->fwnode); + of_node_get(np); ret = of_gpiochip_scan_gpios(chip); if (ret) - fwnode_handle_put(chip->fwnode); + of_node_put(np); return ret; } void of_gpiochip_remove(struct gpio_chip *chip) { - fwnode_handle_put(chip->fwnode); + of_node_put(dev_of_node(&chip->gpiodev->dev)); }