diff mbox series

[v4,5/5] ACPI: scan: Provide symbol declarations

Message ID 20230703121411.69606-6-andriy.shevchenko@linux.intel.com
State New
Headers
Series ACPI: platform: Fix SMB0001 enumeration on Kontron devices |

Commit Message

Andy Shevchenko July 3, 2023, 12:14 p.m. UTC 
  Compiler is not happy about a couple of symbols that, it thinks,
are not declared:

  warning: symbol 'acpi_device_lock' was not declared. Should it be static?
  warning: symbol 'acpi_wakeup_device_list' was not declared. Should it be static?

Include "sleep.h" to have them explicitly declared and make
the compiler happy.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafael J. Wysocki July 4, 2023, 5:21 p.m. UTC | #1 
On Mon, Jul 3, 2023 at 2:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Compiler is not happy about a couple of symbols that, it thinks,
> are not declared:
>
>   warning: symbol 'acpi_device_lock' was not declared. Should it be static?
>   warning: symbol 'acpi_wakeup_device_list' was not declared. Should it be static?
>
> Include "sleep.h" to have them explicitly declared and make
> the compiler happy.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I've just applied a patch from Ben Dooks making the exact same change.

> ---
>  drivers/acpi/scan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index ec1c9bec8bae..5b145f1aaa1b 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -23,6 +23,7 @@
>  #include <linux/dma-direct.h>
>
>  #include "internal.h"
> +#include "sleep.h"
>
>  #define ACPI_BUS_CLASS                 "system_bus"
>  #define ACPI_BUS_HID                   "LNXSYBUS"
> --
diff mbox series

Patch

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index ec1c9bec8bae..5b145f1aaa1b 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -23,6 +23,7 @@ 
 #include <linux/dma-direct.h>
 
 #include "internal.h"
+#include "sleep.h"
 
 #define ACPI_BUS_CLASS			"system_bus"
 #define ACPI_BUS_HID			"LNXSYBUS"