From patchwork Mon Jul 3 12:14:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115327 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp476342vqx; Mon, 3 Jul 2023 05:17:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlGU+9NS+4PRXIx5F9eHlToHVziPblrqf0wHp4pIOChg8j+ojbvq8rtIP3EibcJVRxfKjzJ8 X-Received: by 2002:a17:903:1001:b0:1b8:9215:9163 with SMTP id a1-20020a170903100100b001b892159163mr3694384plb.6.1688386659715; Mon, 03 Jul 2023 05:17:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688386659; cv=none; d=google.com; s=arc-20160816; b=unHADA7f2aU1/0ELRK32dlK11FYgpDcoY24vmceHePJnRNTWF26ZqsFlzb+r2OFyd/ wFqZzaOhEKuE65H0JhTbRM/odtUCKMBLL0cI2iSk7dICTpnFlNWhsLGPa4+ub1s5Yxq2 qrBCRuw8iGoLlEmXPcgVNTPhbTpDo8CoH6XiX/9r544BSg28T8GN0KriDHP8HrUZN+fa zwGetVn+flU4BESJubxdOYoKrkMttMZCXMpCLUAgwnfeyfbdK/DvoYyWleWBRFbKdAKJ MwWcwOW2k7Dl9+zDYUIDJRhbP/mpS4qPWC1Onfk5fSSQN802TBJ3Th+ebtYaZLrMFgPN 6DqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5iemao1POgRE/CvMCeRaCXAPB0CyOPW9l2gtyyY8uws=; fh=z41p7sb2mQHDU0cDatvZvSvBt/K/qZ0WnYN8eOL4by8=; b=fZH6nsbu+GNdpfaQ72ElHlZELUN6BaJjr/XWGeODEfbzZ5TyEGbc0+FzTsVDnwasYo FE6qay7bM/deTWER8Ak8lH0mG0eufBvZKk/m74KqzMOUJvJXKKLL2naD7EwE0NgS03vh 9GvbI5/GnyRnQ8FGdYSD7FsXEUap+OiEVlovzFs/yO66JJuVcSjFl5JwMt7GVTwYpI8Z SJ78h231C79ChclLB37VAP6clMb0nR3Lk1vOjMB2Z7AKM5ag9JCvPKObRk6Mq1Jm0WwL LmZYDc719OjNKFDnn30RajlwnWGqZl1J+rXVddR9nzPoqK9prKrtjpUF4fsvUTfdHNm8 9qyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cmN2v3Bs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a170902b20600b0019c354055d0si17392783plr.304.2023.07.03.05.17.26; Mon, 03 Jul 2023 05:17:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cmN2v3Bs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbjGCMOW (ORCPT + 99 others); Mon, 3 Jul 2023 08:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbjGCMOP (ORCPT ); Mon, 3 Jul 2023 08:14:15 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC5F109; Mon, 3 Jul 2023 05:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688386455; x=1719922455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SqHkBAkMK8Hr6vUp+4hcp7KlH8mbLu8d9B93Kaa2CI0=; b=cmN2v3BsUccyQpB/JP3I9AtikT+eCMQn8WwHu9egn0wTtsuAYkJePai1 6HEjlNDFWllbAKPK60bGVrSH/GYvzl0UQXdKSAB5LWU4n8/saIkNoTzaA fMh+YAlfqXEMOlMMQ0CwefQZTVz3RDjwuAvshaHuA+RDCz/YbJSQE75HA hpXgpCwhxOTNx5bi2F58iuFl58g6RGaSGvPTjLE51k0XKVDf5NT/kznuZ ftDipyD8x8ixCcklcmp+ULXMzkKvDR30DeZQXpxGilEpPjfL0su892qqI ju1zCNIHGPfUCnGWKs4v5ZBYAxl1DpI+SRp2Ahdzf0szGGFoUPiRihiOa g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="449241146" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="449241146" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 05:14:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="718574510" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="718574510" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2023 05:14:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 12A1A177; Mon, 3 Jul 2023 15:14:13 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , "Rafael J. Wysocki" , Wolfram Sang , Andi Shyti , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, acpica-devel@lists.linuxfoundation.org Cc: "Rafael J. Wysocki" , Len Brown , Robert Moore , Michael Walle Subject: [PATCH v4 3/5] ACPI: platform: Move SMB0001 HID to the header and reuse Date: Mon, 3 Jul 2023 15:14:09 +0300 Message-Id: <20230703121411.69606-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230703121411.69606-1-andriy.shevchenko@linux.intel.com> References: <20230703121411.69606-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770401730221189098?= X-GMAIL-MSGID: =?utf-8?q?1770401730221189098?= There are at least two places in the kernel that are using the SMB0001 HID. Make it to be available via acpi_drivers.h header file. While at it, replace hard coded one with a definition. Reviewed-by: Andi Shyti Acked-by: Wolfram Sang # for I2C Link: https://lore.kernel.org/r/20230621151652.79579-2-andriy.shevchenko@linux.intel.com Signed-off-by: Andy Shevchenko --- drivers/acpi/acpi_platform.c | 2 +- drivers/i2c/busses/i2c-scmi.c | 3 --- include/acpi/acpi_drivers.h | 2 ++ 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index c2ce558bd032..3867d5389c51 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -29,7 +29,7 @@ static const struct acpi_device_id forbidden_id_list[] = { {"PNP0000", 0}, /* PIC */ {"PNP0100", 0}, /* Timer */ {"PNP0200", 0}, /* AT DMA Controller */ - {"SMB0001", ACPI_ALLOW_WO_RESOURCES}, /* ACPI SMBUS virtual device */ + {ACPI_SMBUS_MS_HID, ACPI_ALLOW_WO_RESOURCES}, /* ACPI SMBUS virtual device */ { } }; diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c index 104570292241..421735acfa14 100644 --- a/drivers/i2c/busses/i2c-scmi.c +++ b/drivers/i2c/busses/i2c-scmi.c @@ -13,9 +13,6 @@ #include #include -/* SMBUS HID definition as supported by Microsoft Windows */ -#define ACPI_SMBUS_MS_HID "SMB0001" - struct smbus_methods_t { char *mt_info; char *mt_sbr; diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h index 8372b0e7fd15..b14d165632e7 100644 --- a/include/acpi/acpi_drivers.h +++ b/include/acpi/acpi_drivers.h @@ -27,6 +27,8 @@ #define ACPI_BAY_HID "LNXIOBAY" #define ACPI_DOCK_HID "LNXDOCK" #define ACPI_ECDT_HID "LNXEC" +/* SMBUS HID definition as supported by Microsoft Windows */ +#define ACPI_SMBUS_MS_HID "SMB0001" /* Quirk for broken IBM BIOSes */ #define ACPI_SMBUS_IBM_HID "SMBUSIBM"