From patchwork Mon Jul 3 08:02:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wilczynski, Michal" X-Patchwork-Id: 115226 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp371542vqx; Mon, 3 Jul 2023 01:38:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlFHGiq1j8bGXyunuKBDd/3KDiTxa4vshotOWfDyzM+VIvxfaeL8BAivO4EmvvY8swR38RIt X-Received: by 2002:a05:6a00:4189:b0:682:59aa:178d with SMTP id ca9-20020a056a00418900b0068259aa178dmr11828131pfb.1.1688373519634; Mon, 03 Jul 2023 01:38:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688373519; cv=none; d=google.com; s=arc-20160816; b=LsJ8ZXjE+2pR+phN87l+F2MRITzHE38mmfqowaYWns/Iy9EPyzfuS4/e03Z3w87ZU1 a5h15TgV339FasZ7JSBpbs8jDW/5q7KHwuQdLGcxTbpUx3kYFRhF9FpEvHkcgfsdEmWN 06IV2RcMyQJporVtFibteO69MHAzOJWq6NukcXWCWOlxsksrbxAaFIR5zAwIPOcWhw2N 6n12jthetPF3HiiI0Impd/jvvC1uLIcpup/Pt5LLi6X3Avqz129jDZTua9Nw0IDOy0B0 BxjEY+RKIDi0iOCx/Mx3/dfW0x/FboBFwAJNBiqCf7QFqQWQB7HwCkbB3ekGIE4Bm/ov +THw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+tyWFZ28N6lUmbK5s7M5Pk4z2QZdCp3mOmzeHfFqbAY=; fh=KYfAVph4r8Q0QL8w2PKQM+mlcUaM4t4ymfiVotNlWDE=; b=d7qAW2Ps9Lt3rQRNyhvkiosJPru5HyA+KXs2H34hQFhEoSdrczRebOnabrpIowUQVP EbdQ7bQPrtTmq/xNc2+zGgiQHtmmEeshsBGu2WWSOinqQlv4qjG86pemnYNcaB92oz9K y+3+vKcqRF8v2ueBhlJ+ZVUFL5vov3HW3gh9hGvN8L1NWasjS9QnctAZ4uIzqJQNWSq3 9lUTsBuofet43EfxMYhx9OObPoAlW3zFW4JvYdlN1xdKtAKMrMf5Bq6DHQOOYBPIkeok RgGlNf4pV5VuWEPb92a+GVd84CEBaOx0FdC4I55mPID1DhhpfqnceG5C58Mh27NzulM3 wmnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lKJR5COE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fb9-20020a056a002d8900b0064d4d472935si11671066pfb.18.2023.07.03.01.38.26; Mon, 03 Jul 2023 01:38:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lKJR5COE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbjGCIFJ (ORCPT + 99 others); Mon, 3 Jul 2023 04:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjGCIEY (ORCPT ); Mon, 3 Jul 2023 04:04:24 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A814F10E5; Mon, 3 Jul 2023 01:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688371433; x=1719907433; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+KEWHKPpqNaiI+WNm1olqE9/TBQfa5bBD6OIb1rqfsw=; b=lKJR5COESjgAjmyj1ZRYFH3eSz/pThN0F4FzNkZedMC2S/afK10whMN4 LEHGHEbRipyQmoc+L2TdyMav2zvdEhXpprI4ThDpe0I6/Ym8O0vWb4eqh Hsl1cTU3TAdaIAxOYHWy9K4Dvw7n2dx3xSNgoYlUfxAhJbM9VHHYh1cdS RMddsaQ0kwezzy3JOdOGwBngogriZ0os4oEbglWth628pvgfquXD8FTKx sogGZ2n7aptgoF5dzSmchMK+/qjouTPT9lijzUfQpSjRCxw2z76HNTvte VBWLmAUx8lAbxZdSscfOLXeC09+ko/knovAlQ11cpV9nlzTNhIB5JY9ky g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="366304100" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="366304100" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 01:03:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="862994575" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="862994575" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 01:03:36 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org Cc: rafael@kernel.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, lenb@kernel.org, dave.jiang@intel.com, ira.weiny@intel.com, rui.zhang@intel.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, Michal Wilczynski Subject: [PATCH v7 8/9] acpi/nfit: Remove unnecessary .remove callback Date: Mon, 3 Jul 2023 11:02:51 +0300 Message-ID: <20230703080252.2899090-9-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230703080252.2899090-1-michal.wilczynski@intel.com> References: <20230703080252.2899090-1-michal.wilczynski@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770387951684990752?= X-GMAIL-MSGID: =?utf-8?q?1770387951684990752?= Nfit driver doesn't use .remove() callback and provide an empty function as it's .remove() callback. Remove empty acpi_nfit_remove() and initialization of callback. Suggested-by: Dan Williams Signed-off-by: Michal Wilczynski --- drivers/acpi/nfit/core.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 124e928647d3..16bf17a3d6ff 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -3402,11 +3402,6 @@ static int acpi_nfit_add(struct acpi_device *adev) adev); } -static void acpi_nfit_remove(struct acpi_device *adev) -{ - /* see acpi_nfit_unregister */ -} - static void acpi_nfit_update_notify(struct device *dev, acpi_handle handle) { struct acpi_nfit_desc *acpi_desc = dev_get_drvdata(dev); @@ -3488,7 +3483,6 @@ static struct acpi_driver acpi_nfit_driver = { .ids = acpi_nfit_ids, .ops = { .add = acpi_nfit_add, - .remove = acpi_nfit_remove, }, };