diff mbox series

[v7,8/9] acpi/nfit: Remove unnecessary .remove callback

Message ID 20230703080252.2899090-9-michal.wilczynski@intel.com
State New
Headers
Series Remove .notify callback in acpi_device_ops |

Commit Message

Wilczynski, Michal July 3, 2023, 8:02 a.m. UTC 
  Nfit driver doesn't use .remove() callback and provide an empty function
as it's .remove() callback. Remove empty acpi_nfit_remove() and
initialization of callback.

Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
---
 drivers/acpi/nfit/core.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Rafael J. Wysocki July 13, 2023, 3:23 p.m. UTC | #1 
On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski
<michal.wilczynski@intel.com> wrote:
>
> Nfit driver doesn't use .remove() callback and provide an empty function
> as it's .remove() callback. Remove empty acpi_nfit_remove() and
> initialization of callback.
>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>

This one is not strictly related to the rest of the series, but it
does depend on the previous one, so assuming that the previous one is
not objectionable, I suppose I can take them both.  Dan?

> ---
>  drivers/acpi/nfit/core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 124e928647d3..16bf17a3d6ff 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -3402,11 +3402,6 @@ static int acpi_nfit_add(struct acpi_device *adev)
>                                         adev);
>  }
>
> -static void acpi_nfit_remove(struct acpi_device *adev)
> -{
> -       /* see acpi_nfit_unregister */
> -}
> -
>  static void acpi_nfit_update_notify(struct device *dev, acpi_handle handle)
>  {
>         struct acpi_nfit_desc *acpi_desc = dev_get_drvdata(dev);
> @@ -3488,7 +3483,6 @@ static struct acpi_driver acpi_nfit_driver = {
>         .ids = acpi_nfit_ids,
>         .ops = {
>                 .add = acpi_nfit_add,
> -               .remove = acpi_nfit_remove,
>         },
>  };
>
> --
> 2.41.0
>
diff mbox series

Patch

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 124e928647d3..16bf17a3d6ff 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -3402,11 +3402,6 @@  static int acpi_nfit_add(struct acpi_device *adev)
 					adev);
 }
 
-static void acpi_nfit_remove(struct acpi_device *adev)
-{
-	/* see acpi_nfit_unregister */
-}
-
 static void acpi_nfit_update_notify(struct device *dev, acpi_handle handle)
 {
 	struct acpi_nfit_desc *acpi_desc = dev_get_drvdata(dev);
@@ -3488,7 +3483,6 @@  static struct acpi_driver acpi_nfit_driver = {
 	.ids = acpi_nfit_ids,
 	.ops = {
 		.add = acpi_nfit_add,
-		.remove = acpi_nfit_remove,
 	},
 };