diff mbox series

[v3,1/3] drm: Improve Kconfig symbol prompt and help texts

Message ID 20230702191529.768248-2-javierm@redhat.com
State New
Headers
Series Allow disabling all native fbdev drivers and only keeping DRM emulation |

Commit Message

Javier Martinez Canillas July 2, 2023, 7:15 p.m. UTC 
  The current text were not changed since the original Linux-2.6.12-rc2 git
import. Let's improve it and make that more aligned with the DRM/KMS docs.

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

(no changes since v1)

 drivers/gpu/drm/Kconfig | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

Comments

Thomas Zimmermann July 3, 2023, 9:39 a.m. UTC | #1 
Hi Javier

Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas:
> The current text were not changed since the original Linux-2.6.12-rc2 git
> import. Let's improve it and make that more aligned with the DRM/KMS docs.
> 
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
> 
> (no changes since v1)
> 
>   drivers/gpu/drm/Kconfig | 22 +++++++++++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index afb3b2f5f425..373f85e174c2 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -3,10 +3,11 @@
>   # Drm device configuration
>   #
>   # This driver provides support for the
> -# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
> +# Direct Rendering Infrastructure (DRI) that is composed of the Direct
> +# Rendering Manager (DRM) and Kernel Mode Settings (KMS) subsystems.
>   #
>   menuconfig DRM
> -	tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
> +	tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)"
>   	depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA
>   	select DRM_PANEL_ORIENTATION_QUIRKS
>   	select HDMI
> @@ -19,13 +20,16 @@ menuconfig DRM
>   	select VIDEO_CMDLINE
>   	select VIDEO_NOMODESET
>   	help
> -	  Kernel-level support for the Direct Rendering Infrastructure (DRI)
> -	  introduced in XFree86 4.0. If you say Y here, you need to select
> -	  the module that's right for your graphics card from the list below.
> -	  These modules provide support for synchronization, security, and
> -	  DMA transfers. Please see <http://dri.sourceforge.net/> for more
> -	  details.  You should also select and configure AGP
> -	  (/dev/agpgart) support if it is available for your platform.
> +	  Kernel-level support for the Direct Rendering Infrastructure (DRI),
> +	  that is composed of the Direct Rendering Manager (DRM) and Kernel
> +	  Mode Settings (KMS) subsystems.

It's slightly off, as KMS is part of DRM. I'd just drop any mention of KMS.

But TBH instead of these small fixes, we should first discuss how we 
organize the menu structures. For example, the DRM drivers are all 
listed in the graphics menu. They might as well go into a DRM menu.

The framebuffer will be split into drivers and 'core'. The core options 
(FB_DEVICE, FIRMWARE_EDID, FB_*_ENDIAN) probably deserve a separate menu.

And there's the framebuffer console, which has its own menu. We need to 
show it even if only DRM is supported. Plus the other consoles.

I'm not sure what drivers/auxdisplay is, it might fit here as well.

It would be nice to rethink the overall menu.

Best regards
Thomas

> +
> +	  If you say Y here, you need to select the module that's right for
> +	  your graphics card from the list below. These modules provide support
> +	  for synchronization, security, and DMA transfers.
> +
> +	  Please see <https://www.kernel.org/doc/html/latest/gpu/index.html>
> +	  for more details about the Linux DRM and KMS subsystems.
>   
>   config DRM_MIPI_DBI
>   	tristate

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Javier Martinez Canillas July 3, 2023, 9:47 a.m. UTC | #2 
Thomas Zimmermann <tzimmermann@suse.de> writes:

> Hi Javier
>
> Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas:

[...]

>> -	  Kernel-level support for the Direct Rendering Infrastructure (DRI)
>> -	  introduced in XFree86 4.0. If you say Y here, you need to select
>> -	  the module that's right for your graphics card from the list below.
>> -	  These modules provide support for synchronization, security, and
>> -	  DMA transfers. Please see <http://dri.sourceforge.net/> for more
>> -	  details.  You should also select and configure AGP
>> -	  (/dev/agpgart) support if it is available for your platform.
>> +	  Kernel-level support for the Direct Rendering Infrastructure (DRI),
>> +	  that is composed of the Direct Rendering Manager (DRM) and Kernel
>> +	  Mode Settings (KMS) subsystems.
>
> It's slightly off, as KMS is part of DRM. I'd just drop any mention of KMS.
>
> But TBH instead of these small fixes, we should first discuss how we

Right, I'll just drop this patch and we can cleanup the text later.

> organize the menu structures. For example, the DRM drivers are all 
> listed in the graphics menu. They might as well go into a DRM menu.
>
> The framebuffer will be split into drivers and 'core'. The core options 
> (FB_DEVICE, FIRMWARE_EDID, FB_*_ENDIAN) probably deserve a separate menu.
>

Yes, that is what we agreed with Arnd and Geert. To add a new Kconfig in
drivers/video/fbdev/core/Kconfig and drivers/video/fbdev/Kconfig source it.

> And there's the framebuffer console, which has its own menu. We need to 
> show it even if only DRM is supported. Plus the other consoles.
>
> I'm not sure what drivers/auxdisplay is, it might fit here as well.
>

That seems to be for simple character-based displays. And agree that could
be in framebuffer console as well. So we should improve the menu structure
before attempting to complicate with more options like adding the FB_CORE.

> It would be nice to rethink the overall menu.
>
> Best regards
> Thomas
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index afb3b2f5f425..373f85e174c2 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -3,10 +3,11 @@ 
 # Drm device configuration
 #
 # This driver provides support for the
-# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
+# Direct Rendering Infrastructure (DRI) that is composed of the Direct
+# Rendering Manager (DRM) and Kernel Mode Settings (KMS) subsystems.
 #
 menuconfig DRM
-	tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
+	tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)"
 	depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA
 	select DRM_PANEL_ORIENTATION_QUIRKS
 	select HDMI
@@ -19,13 +20,16 @@  menuconfig DRM
 	select VIDEO_CMDLINE
 	select VIDEO_NOMODESET
 	help
-	  Kernel-level support for the Direct Rendering Infrastructure (DRI)
-	  introduced in XFree86 4.0. If you say Y here, you need to select
-	  the module that's right for your graphics card from the list below.
-	  These modules provide support for synchronization, security, and
-	  DMA transfers. Please see <http://dri.sourceforge.net/> for more
-	  details.  You should also select and configure AGP
-	  (/dev/agpgart) support if it is available for your platform.
+	  Kernel-level support for the Direct Rendering Infrastructure (DRI),
+	  that is composed of the Direct Rendering Manager (DRM) and Kernel
+	  Mode Settings (KMS) subsystems.
+
+	  If you say Y here, you need to select the module that's right for
+	  your graphics card from the list below. These modules provide support
+	  for synchronization, security, and DMA transfers.
+
+	  Please see <https://www.kernel.org/doc/html/latest/gpu/index.html>
+	  for more details about the Linux DRM and KMS subsystems.
 
 config DRM_MIPI_DBI
 	tristate