From patchwork Fri Jun 30 08:30:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 114617 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10200914vqr; Fri, 30 Jun 2023 01:42:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlHwNVaeeIIxjV2oxIh3RuOMZ+WtZ2g9+JSyYRlKZXHlbMVkEoqena+f3OXVxgJbgDSsUzc4 X-Received: by 2002:a17:90a:e2c1:b0:263:25f9:65b2 with SMTP id fr1-20020a17090ae2c100b0026325f965b2mr1898755pjb.4.1688114560414; Fri, 30 Jun 2023 01:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688114560; cv=none; d=google.com; s=arc-20160816; b=Cwfn7MJKxKHnlmnQM3FNGu9n741C+nku+3Fip3/kJlZ48AWH0XIC3MdB17Dq+SGkWd 2j7+2YTN7FTwUkC205KVyasZ7pSQmhKfuGl4oNgjmBEVZiEi9foqekte26dOOcigG2tS GGhsUHqtkmuhHbweIuWCeGsVb6ovfAxG16sH7Jy3LJQ5tMkKpUsbCb9hsID/sSNIQrCA jp5z9e/nQ6H6yNWVVnVQShgh+apaQxr9pZtSYNYuMz+snhAuZNAN3SiAXvnJbZey2nrW OB0WehWV4yMROCM0PtER93Xh5n4fgeiORUmh7YwF+4rYuYWq5+i+1mv+K8ZOz19iTObS QBxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YVY/yta8MPWmg9iGDhd2QZ8qAlvFNnDO2cXvkrgJQ+E=; fh=VoQtphkyp1h+kGu6pCIzY/INB1mer40DkWxg4dsVYHk=; b=JaEUa3SzGsHPRiQiUSVc0a4seln2Hd5D8kwPwm6+JZ/BeA1hSoaZU3jgg/zqs5BxqU dQzlqeASzZA0u11k5C8hFnkFabd3Sa6rXGrr3Q4rThyDzlavJzBXXBuCkiN7g64DOZUD AEj1uPnPCzu6N8hsaVbUSyR7ApUOlJbS5J9sycymEwgm9ZbuPYZnwSdgOiXoAB6Ht1Rv aNKzDxGLK5eDw9eumpjodT80b5ar+APmjX4cUH5WPo/oyRw6rvjlkQ+bWUSCp/XJc4ez Zk2OJk56tE4qBuWDUvlBGBubWehFArM0yWqqk9ZWdBewW6hnDB3fICgbdQXA74fhwWY+ zetA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b="kl/TPhm6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id me10-20020a17090b17ca00b0025c1af5672fsi13160576pjb.112.2023.06.30.01.42.26; Fri, 30 Jun 2023 01:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b="kl/TPhm6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbjF3Icx (ORCPT + 99 others); Fri, 30 Jun 2023 04:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232555AbjF3Icn (ORCPT ); Fri, 30 Jun 2023 04:32:43 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCCA61FC1 for ; Fri, 30 Jun 2023 01:32:41 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fa93d61d48so17952505e9.0 for ; Fri, 30 Jun 2023 01:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1688113960; x=1690705960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YVY/yta8MPWmg9iGDhd2QZ8qAlvFNnDO2cXvkrgJQ+E=; b=kl/TPhm6ikHmXXieyToZuU/DsVCjRsYDu5avotvuqaFc6tZ03SeeW4FBKpCi/Mw0WK wYwR3smgKyTmD/+jwch8XyufhBtdkF3f7qT76g3QLFIxycHhxqlDuelvEeFLcQBDGwtt c99+4W37R5ubiuAV02MC9TfgLz/gSE7K7R4yhEbEZr5+7p6QH5R3OjwwnSQN3sEOn7tW RKj4BSD6VxbchcdMJw22xXR3zLMu8PcBAKcXWWpZR1RwCBliqolg8sKRbGtF44CNGBjW 9CyHSusDkCPt0CnofvgfwI9NFxWhPuDzw6CUyYduupu1PMRz4yXtfiSFdQwWM5irvYAE GdrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688113960; x=1690705960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YVY/yta8MPWmg9iGDhd2QZ8qAlvFNnDO2cXvkrgJQ+E=; b=FW+b1947Wb1HNWT7zREPjSNnmp0tSY/CUCzltgLwSkldvH+3LmgDZ3+CY+ueXbpyl3 XY7JMmIelhZM+Ub3OKD/Zw41i2KQRyZt/3mrp3PBoiGBGfFNXRlyHdw8TUmqEZ+RbEka ULHiRoMafd+7/IOX4PqUi07539lK0S0e8V5zyWo6JNg3bVVPhrIsFBvC0rjgEMNVBcxD YqvAWdUJ6CdkUY1EMC+c8Y5QQ+r6sl61V18M0DUBSM/0DN0U11+pI4q4W7TLN8qnGYhd 3PbLRzxAbzJlDxrorr8GD/C9566CNokG+ID9x0Nldpr0zEYU42SXyvMiV4wi/lHjNYMM eMhw== X-Gm-Message-State: AC+VfDxNVjV/WRB//elcj19sCMxL2JzLBE2I399JhgI6Se7tGAt6Fqhl gbeWaUZXNnaVcROfCb7Uy5tC5Un1KaD/zaslaiI= X-Received: by 2002:a1c:7c05:0:b0:3f6:2ae:230e with SMTP id x5-20020a1c7c05000000b003f602ae230emr1443811wmc.3.1688113960321; Fri, 30 Jun 2023 01:32:40 -0700 (PDT) Received: from alex-rivos.ba.rivosinc.com (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id v4-20020a05600c214400b003fa95890484sm13846402wml.20.2023.06.30.01.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 01:32:40 -0700 (PDT) From: Alexandre Ghiti To: Jonathan Corbet , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Rob Herring , Andrew Jones , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Alexandre Ghiti , Atish Patra Subject: [PATCH v3 01/10] perf: Fix wrong comment about default event_idx Date: Fri, 30 Jun 2023 10:30:04 +0200 Message-Id: <20230630083013.102334-2-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230630083013.102334-1-alexghiti@rivosinc.com> References: <20230630083013.102334-1-alexghiti@rivosinc.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770116412883246131?= X-GMAIL-MSGID: =?utf-8?q?1770116412883246131?= Since commit c719f56092ad ("perf: Fix and clean up initialization of pmu::event_idx"), event_idx default implementation has returned 0, not idx + 1, so fix the comment that can be misleading. Signed-off-by: Alexandre Ghiti Reviewed-by: Andrew Jones Reviewed-by: Atish Patra --- include/linux/perf_event.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index d5628a7b5eaa..56fe43b20966 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -442,7 +442,8 @@ struct pmu { /* * Will return the value for perf_event_mmap_page::index for this event, - * if no implementation is provided it will default to: event->hw.idx + 1. + * if no implementation is provided it will default to 0 (see + * perf_event_idx_default). */ int (*event_idx) (struct perf_event *event); /*optional */