Message ID | 20230629083047.3487172-1-linux@roeck-us.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9486814vqr; Thu, 29 Jun 2023 01:41:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6U5l88IwXOsxoSlLgL5kEWmicKNi0HOGAQ+wSNRK4lxB6iGdHUy4Wcd/mbo2WZVi4MaGcT X-Received: by 2002:a05:6a20:7d97:b0:12c:bbd3:a0dd with SMTP id v23-20020a056a207d9700b0012cbbd3a0ddmr1992170pzj.0.1688028107665; Thu, 29 Jun 2023 01:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688028107; cv=none; d=google.com; s=arc-20160816; b=unk/lg21S4Df+ECh24wo7w1D8fOmAskCQGaEK5jduT1WrX9Dkl5/zqq2Iawbk+/g5p cI+TJBc2Izr2ZLums52UnpnCc0/QI3V1Xe7cSeE9SD0R/vZy14eSZqcE0jkxyB2NFSMX D/ggUQKMaYBfIUmRBCkLLo6wkE1sp1EPzIVjq3e1Dw+oOK9zxRsIeO18VJuSKKS37Ytb mZmAUkvbjbYN4EnE/Obd4QSCTMPtaf8fmQAD16LFU+UpEAv75ZqOG2kX8UJD/UTmfVHh 0SLJ1ZEBhmRZZaxvcfIyERBqSvm5+9THIVxiPPL2QBBwpUyKsqDMY9YiRkcKKxgZL71A 468w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=sQtoyriN4YYQEmPoScMjRZhWgO3u3DHPKL9H+7yd4ag=; fh=Vjd/5kKBzcqbNvdmiqHvUPdbpYiyygOgm6cAIOaRQTc=; b=qddgQx4Wbtu37Tiy44bxc/YKdROundDDaoSZ+PkKW5XVFMcTucMl50LJYnfPfoi02w iIb9zxrOU64nBaNpYFvaavuikJ6n47w9/+S9XqnSmhl3aDTMiWF5x1Btizi2JHcMn7MT IIb0sWcC+JR0bwwuSSnMvQbowNp48CUoB1fL+UaXrR5+Yf4nP6FzUvI+m2VUU5/zPcyl ZEM5pP6+4+CW42Fe+R4up/T7Z0xYaeuTetqjea6wtdOSSt/r4cUN/LHqxX5JvUSHPPIh UAiLdfIAuR5sXJjwQhZNs9JvZ8DfBNmaHnDr+OhOZ6tEDDNgkjz0Bbh9SHyFRC7uzVtw HXKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=bhYiZhEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n127-20020a632785000000b00543ef0f981asi10589882pgn.631.2023.06.29.01.41.32; Thu, 29 Jun 2023 01:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=bhYiZhEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232838AbjF2IcY (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Thu, 29 Jun 2023 04:32:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbjF2Iay (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 29 Jun 2023 04:30:54 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230022733 for <linux-kernel@vger.kernel.org>; Thu, 29 Jun 2023 01:30:51 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b7f223994fso3523315ad.3 for <linux-kernel@vger.kernel.org>; Thu, 29 Jun 2023 01:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688027450; x=1690619450; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=sQtoyriN4YYQEmPoScMjRZhWgO3u3DHPKL9H+7yd4ag=; b=bhYiZhEYMXPEQmlagzmx8BkE8mTZrMu9plkEvpagqvFG45XJflWMpwO4WZdRhWgGOb m3B84AN3plYpEf36mpfaIZamaiTARQpjp7abLyO6kCjlDdMfOOXh/uPvP0AsffZccxdQ SB0GrqNYTWuSvdIY8YVzu4Qb4sttJafkebdkecMCGszD4TQ5FC+R7S3nGZHlCPulr/mp QjXK0QKEgCE2laWeLFZl+phSnMRrQF6MP5C9jDSC5wD+BsbDoCTlgNUgbZQpM62eJ0QB r1XGwVbjCM/OX46f7gYa8I6yU1SoV0hu2jzDro5hoU8kVa2V0ydGfSGZKhql2aFNIPAw Jshg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688027450; x=1690619450; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sQtoyriN4YYQEmPoScMjRZhWgO3u3DHPKL9H+7yd4ag=; b=Cw3rdv5cBciTj6kGri0cD+/qtjEh7t8vAS+DEJKoV70LzEDfaWv4zsKSqZ6dwA+Op4 hjtPCD4s2vnhH5SqUfxaYjJ+HpZ5Eq+4R4S7oBYBrz1WshU4yqRvSJW0Vyh74d+eZcgh DVmSMJKIZF56YdqZTyXAhqUGfio34WOk3B8ScmewEGfD9NEofhlIopXyTI2KGwjuWM7t 1SXLf+cxzX5IJ8W38n7pI5Ty49FWVK/ekKP93FNSPE9gyLujR7xfoebUQRBDuu7zvhBX BGkajOiKzJqBt8OG9WSqEsMUqhkk3FJBUQWwzpO6qYuW8dUcUBFhXS4L86H3DAhNmIxG ioZQ== X-Gm-Message-State: ABy/qLYYXsOOtJiSCdDInDEe4rfBvrE2PSfqovteac9ErAxYB/tUGZhk PGjNcI7UfZSy/2u0inupCRM= X-Received: by 2002:a17:903:451:b0:1b8:4b87:20dc with SMTP id iw17-20020a170903045100b001b84b8720dcmr2620093plb.37.1688027450373; Thu, 29 Jun 2023 01:30:50 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id z15-20020a170903018f00b001a072aedec7sm8728140plg.75.2023.06.29.01.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 01:30:49 -0700 (PDT) Sender: Guenter Roeck <groeck7@gmail.com> From: Guenter Roeck <linux@roeck-us.net> To: Jens Axboe <axboe@kernel.dk> Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, Christoph Hellwig <hch@lst.de>, Phillip Potter <phil@philpotter.co.uk>, Hannes Reinecke <hare@suse.de>, Christian Brauner <brauner@kernel.org> Subject: [PATCH] cdrom/gdrom: Fix build error Date: Thu, 29 Jun 2023 01:30:47 -0700 Message-Id: <20230629083047.3487172-1-linux@roeck-us.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770025760674095092?= X-GMAIL-MSGID: =?utf-8?q?1770025760674095092?= |
Series |
cdrom/gdrom: Fix build error
|
|
Commit Message
Guenter Roeck
June 29, 2023, 8:30 a.m. UTC
Commit 7ae24fcee992 ("cdrom: remove the unused mode argument to
cdrom_release") was supposed to remove an unused argument from
cdrom_release(). but instead removed a used argument from
cdrom_open(). This results in the following build error.
drivers/cdrom/gdrom.c: In function 'gdrom_bdops_open':
drivers/cdrom/gdrom.c:484:15: error: too few arguments to function 'cdrom_open'
drivers/cdrom/gdrom.c: In function 'gdrom_bdops_release':
drivers/cdrom/gdrom.c:492:35: error: 'mode' undeclared
Fix it up.
Fixes: 7ae24fcee992 ("cdrom: remove the unused mode argument to cdrom_release")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Phillip Potter <phil@philpotter.co.uk>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
My apologies for the noise if this has already been submitted.
If so I didn't find it. Also apologies for the wide distribution,
but the file doesn't seem to have a maintainer and I have no idea
who would/should apply the patch.
drivers/cdrom/gdrom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, 29 Jun 2023 01:30:47 -0700, Guenter Roeck wrote: > Commit 7ae24fcee992 ("cdrom: remove the unused mode argument to > cdrom_release") was supposed to remove an unused argument from > cdrom_release(). but instead removed a used argument from > cdrom_open(). This results in the following build error. > > drivers/cdrom/gdrom.c: In function 'gdrom_bdops_open': > drivers/cdrom/gdrom.c:484:15: error: too few arguments to function 'cdrom_open' > > [...] Applied, thanks! [1/1] cdrom/gdrom: Fix build error commit: a587b046ce921cc1805de6f0f000209b3644cadd Best regards,
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index 3a46e27479ff..d668b174ace9 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct gendisk *disk, blk_mode_t mode) disk_check_media_change(disk); mutex_lock(&gdrom_mutex); - ret = cdrom_open(gd.cd_info); + ret = cdrom_open(gd.cd_info, mode); mutex_unlock(&gdrom_mutex); return ret; } @@ -489,7 +489,7 @@ static int gdrom_bdops_open(struct gendisk *disk, blk_mode_t mode) static void gdrom_bdops_release(struct gendisk *disk) { mutex_lock(&gdrom_mutex); - cdrom_release(gd.cd_info, mode); + cdrom_release(gd.cd_info); mutex_unlock(&gdrom_mutex); }