From patchwork Thu Jun 29 01:34:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Hu X-Patchwork-Id: 114122 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9333880vqr; Wed, 28 Jun 2023 18:59:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7RPt0zPpGFQLfxEkgZ9D/08SpGDe4zijJc6+sxZ5PF2Bsq1iIPLT/b7u1oX2pq3hKfIRP6 X-Received: by 2002:a05:6a20:549c:b0:125:5f1d:9dbe with SMTP id i28-20020a056a20549c00b001255f1d9dbemr1531382pzk.2.1688003969767; Wed, 28 Jun 2023 18:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688003969; cv=none; d=google.com; s=arc-20160816; b=fI+brA7F80xTAabn/0xTarM7op6wq8nHSDBIwJ4qaLKaXxL2YsZvvTES2TfB613by1 HOwz6HG66n9/lM6191gs6UiDSPJ6xj6EoQLZFxVIQueHmB0YgSY9NSBTuPWcdp58McEE J3Lo7r8dVQgjjHxCr5GweGvLIcW5YkKZv56w5DUasgll5wpWIWKh9wP44tDlxn7s0/2C Q2s8PWXG0gFKdFCGNBZAT9UebkHoTIndXPKv6728ibWRAKFsRtBg99QNeK+RQO+6NrED 3BjoW++Cz2fOQFXfczAEf2+QTLQwpK+ChuKkSbjUYfGj3rwkNnSqq4Fx7h7flIQDuU5L xH6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aRbi4Ndba/YrHSJ7/84h986V9UZojW53o+T4vHUCd1w=; fh=2nJ5fbpFr4QaIndGk4qIzg1ghxQuHfoU06FzfzqqC8c=; b=b3LbF+MUMhEf2vXEpao3QjcWYFZNAuaq7Jj2hrHxX9JrTpYDtdY/zlVvCNA5w+wf14 vYCBu8kNl8up3/vtIzKAQtKlNYWbI8AQfaaOnyiHkBivzwHxeWa8TN8zQoGw/EfGOfLm o53utGk+lOglsNtTBOlzzhiMu8QKrMfbRr5c5bMMCJ5zHbjpj58/KnhYQAssfLv72LlO nR3V9DWMU8v6becqYaBOIoqqWEZ3muxsJb8vIW+YicD5By5OSNpSbnrCIU9FD/AZWf3G OuffvER+qsSh9XRKsFMLYGJykJGLWVhotV+i78/6NYu5UhSKUL8YMekbLmb+PmuZYG5q KzVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m29-20020a634c5d000000b0055b0dcca8b4si3737262pgl.810.2023.06.28.18.59.17; Wed, 28 Jun 2023 18:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjF2BfE (ORCPT + 99 others); Wed, 28 Jun 2023 21:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjF2BfC (ORCPT ); Wed, 28 Jun 2023 21:35:02 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 623891B0 for ; Wed, 28 Jun 2023 18:35:00 -0700 (PDT) X-UUID: 307ba47fb3324b44bec63d7fad732c0a-20230629 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:b4ec874c-a06b-40cd-abd9-8a29c283655d,IP:5,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-INFO: VERSION:1.1.27,REQID:b4ec874c-a06b-40cd-abd9-8a29c283655d,IP:5,URL :0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:15 X-CID-META: VersionHash:01c9525,CLOUDID:ed537d82-5a99-42ae-a2dd-e4afb731b474,B ulkID:2306290934523U986QMZ,BulkQuantity:0,Recheck:0,SF:24|17|19|44|102,TC: nil,Content:0,EDM:5,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI :0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 307ba47fb3324b44bec63d7fad732c0a-20230629 X-User: huxiaoying@kylinos.cn Received: from localhost.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1959421970; Thu, 29 Jun 2023 09:34:49 +0800 From: Hu Xiaoying To: linux-kernel@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, Hu Xiaoying Subject: [PATCH] samples/bpf: Fix outf leak in hbm's read_trace_pipe2 Date: Thu, 29 Jun 2023 09:34:44 +0800 Message-Id: <20230629013444.50350-1-huxiaoying@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770000450877009513?= X-GMAIL-MSGID: =?utf-8?q?1770000450877009513?= Fix outf being fopen'ed but then not subsequently fclose'd. In the affected branch, outf is otherwise going out of scope. --- samples/bpf/hbm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c index bf66277115e2..e28370741d9b 100644 --- a/samples/bpf/hbm.c +++ b/samples/bpf/hbm.c @@ -105,6 +105,8 @@ static void read_trace_pipe2(void) } } } + + fclose(outf); } static void do_error(char *msg, bool errno_flag)