From patchwork Wed Jun 28 12:54:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 113933 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8965441vqr; Wed, 28 Jun 2023 07:23:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zpzrKbWEqh54Tn8YkXZfGULLTwobX+jxoHKDDsc0FWkC++USax/e1j0+G+qu6WJCo8Ga9 X-Received: by 2002:a05:6a21:9985:b0:127:2dc1:c885 with SMTP id ve5-20020a056a21998500b001272dc1c885mr11913348pzb.4.1687962188735; Wed, 28 Jun 2023 07:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687962188; cv=none; d=google.com; s=arc-20160816; b=0Vh2p/COAUTaVP6V6OztA0WwI9wXhjTANEpyavvpE7x8QD9GCLa5Ah8diBK73WgfpL PTp+qDT0my0HDX0Db7nFTdezZ8kVKpNrFmDcc8Y5ca6EpNxoLd1aEY0U955cT/UpO6h2 syPIMVJ5x7RhpcumoiDvBWRhJrXFGo3LHHex2EN//tgVcILBOmt2vU3X7HdsLiO+/zN+ xqFswMOXpl5HC13O3DsBDjLW37Is3QzMGdG+q83TA06jTJypzvainsY2MYaduJw/+yCq yI0SV4nnbtsxsoEuhcrOttLCHjt5tGSb3QXN0NyC+w5mSFBQkNYNMF+4QW2BAD4z9n7n Co6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=Yd6tqeXEG6qUalF+fReiiOEA+oooYPZifLKEn/NjHSY=; fh=XyXCQ+Xm6Xbh43g0a2No8WvLIzKo19KiX0TngsJCwhU=; b=GNkxzONBSvv+oH8CbE61w3arZlzB80VlqtaGtXADCjN+xDIOBQptwFp3Rgm44rszy6 +nw/JYJeZONbofdHG5UG5iXgpygqQwapIJ1HO4Tl3lHaAXuQJ5kLcis4biboim28xbhV OXxD5OQLXwIdqi5lKzZmpSmfP0ZIABIX4CGFauudY8xJtsgZpketdF3QJFWAV1RwVxXG H1ekhk/L1+HvaiIvzO3b/TjzrDrZcYrbEE86rEgrd2FvxMi+i4WNn870AUgDXhBOiFuD YTK9l6FdcvlOtd7qs2HBlyAvTFVCn8586fG+kC/KdYAJzN51Ja9egtntW0HGrP4LA5AY un4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a056a00228700b0064d42dddf9fsi5528759pfe.32.2023.06.28.07.22.55; Wed, 28 Jun 2023 07:23:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232696AbjF1OFu (ORCPT + 99 others); Wed, 28 Jun 2023 10:05:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232584AbjF1OET (ORCPT ); Wed, 28 Jun 2023 10:04:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CEE530EA for ; Wed, 28 Jun 2023 07:03:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 981056134E for ; Wed, 28 Jun 2023 14:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1308EC433C8; Wed, 28 Jun 2023 14:03:41 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qEVlj-002pil-0x; Wed, 28 Jun 2023 10:03:39 -0400 Message-ID: <20230628140339.117011485@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 28 Jun 2023 08:54:51 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Beau Belgrave , sunliming Subject: [for-linus][PATCH 3/3] selftests/user_events: Add test cases when event is disabled References: <20230628125448.007243475@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769956639683899026?= X-GMAIL-MSGID: =?utf-8?q?1769956639683899026?= From: sunliming When user_events are disabled, it's write operation should return -EBADF. Add this test cases. Link: https://lkml.kernel.org/r/20230626111344.19136-4-sunliming@kylinos.cn Acked-by: Beau Belgrave Signed-off-by: sunliming Signed-off-by: Steven Rostedt (Google) --- tools/testing/selftests/user_events/ftrace_test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c index 88898749e5b7..5beb0aef1d81 100644 --- a/tools/testing/selftests/user_events/ftrace_test.c +++ b/tools/testing/selftests/user_events/ftrace_test.c @@ -324,6 +324,10 @@ TEST_F(user, write_events) { io[0].iov_base = ®.write_index; io[0].iov_len = sizeof(reg.write_index); + /* Write should return -EBADF when event is not enabled */ + ASSERT_EQ(-1, writev(self->data_fd, (const struct iovec *)io, 3)); + ASSERT_EQ(EBADF, errno); + /* Enable event */ self->enable_fd = open(enable_file, O_RDWR); ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))