Message ID | 20230627224017.1724097-5-gnstark@sberdevices.ru |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8533679vqr; Tue, 27 Jun 2023 16:24:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4h2GeT5mdMrHJ6JW5x+z3JVknAiRfXwXY16URNY880HT25cX3kMOlXRW6G0VJ2+180ubw4 X-Received: by 2002:a05:6a20:12c5:b0:126:7d25:b0e0 with SMTP id v5-20020a056a2012c500b001267d25b0e0mr13306659pzg.24.1687908253338; Tue, 27 Jun 2023 16:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687908253; cv=none; d=google.com; s=arc-20160816; b=Mqa3gwG/g05oYT5Ayd1gV0zfDOSvx8DK4QcEnxqlnAwil6HVQGHNX1RAQsNWMkIG27 n2pNCFhOfckNLD5G6kQU+PC+RKmaVUkpcBafilciyymRC06+I2i8iRzrak4gijA+SX26 ykQK/2QXe9IB+itXjMIgtMZlFsnx7R5wySMpwoB+9XQ5a9REy7yYYkV1A5a1rLUjNKor yzDMq7450LZF+hSTBkXIChG9nTVqGaEN2nKlsvrGStyW6A6L9w1zZfHhUIQPbxpvSWFq cnZxqp8nvGLO1cmI3EKJYvr09uFzHjbIeVI1WBkG9LEdgBvHXAXzry1q4KhkqKKJLIss fg/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=fGkHaSpBhZc/5j/U10QNDIDrMkJ0Fz7Q81mDkVTHDy8=; fh=dXWV9SwkaSh2/oy/WWRG3ds8vbKYfz+4HQ60WWxpFC4=; b=CWv49HkUy7IHDrf7dbyFwQ1SYDFX+AOh+arBsOu+k6Zo9boW+p/cZZrS0pcfrvwfie QTgRD5n6yq56GwwLRSZWgOAZboRpWdllhZjYcDF3IW1h0KKeNNC2ta1FyM6PsAlbsR8W scqnS464AES5Exca+1JtrSuQ2LRihVDQfoxLI7SN4tv5B6VCk80lCmfJqVyZtM0WjQ9C AXypOnJmX5wotDnn9j8fL41g904/tulkbN7zzFroCsHlGAh3wa0NzHE9sFZvVAFhFS0D 8WEoaLaj1l1tfp5pI0rqFQl4TQl4ondcePaDff8LfE84RISR4jITsKLaNkPeOIytNn9N 4l/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=eTdBVcsY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d21-20020a631d55000000b0053fb768afcdsi8236593pgm.465.2023.06.27.16.24.00; Tue, 27 Jun 2023 16:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=eTdBVcsY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbjF0XTT (ORCPT <rfc822;nicolai.engesland@gmail.com> + 99 others); Tue, 27 Jun 2023 19:19:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjF0XTJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 27 Jun 2023 19:19:09 -0400 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E592F2945 for <linux-kernel@vger.kernel.org>; Tue, 27 Jun 2023 16:19:06 -0700 (PDT) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 5CBE9120008; Wed, 28 Jun 2023 01:40:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 5CBE9120008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1687905634; bh=fGkHaSpBhZc/5j/U10QNDIDrMkJ0Fz7Q81mDkVTHDy8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=eTdBVcsYXOzcwKlEbqu8swR5qSIj+2HRsAJqr9FQwaOPIYw+OdTmaJvt4TQ1btO+0 ncPlcW6U707TNlb5oqMJdgjljQZUjlGrHKMAbf1VZlr6bAVzscjS30ciZff2rGWmDE hgg0zSvHzi4qfVvP3YF9ZemOi75Yy9DpbdliP0nkWhj+LtnDVeEUzWK7jriU5UklFI PqB0GTYGHkCvF7DKL1/k1T95rgO0W5srSKWhg06rn/B/KMEdU816BDPaPWstncA9pz lZq1zpynJ+tbn8xpuFjT7hGGlkRydckkc7sHvuNvFOAudBbHjSmKvujmhJ0pUyf5JC PPw2TcxlFL8AQ== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 28 Jun 2023 01:40:33 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 28 Jun 2023 01:39:34 +0300 From: George Stark <gnstark@sberdevices.ru> To: <jic23@kernel.org>, <lars@metafoo.de>, <neil.armstrong@linaro.org>, <khilman@baylibre.com>, <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>, <andriy.shevchenko@linux.intel.com>, <nuno.sa@analog.com>, <gnstark@sberdevices.ru> CC: <linux-iio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-amlogic@lists.infradead.org>, <kernel@sberdevices.ru>, George Stark <GNStark@sberdevices.ru> Subject: [PATCH v3 4/5] meson saradc: add channel labels Date: Wed, 28 Jun 2023 01:37:17 +0300 Message-ID: <20230627224017.1724097-5-gnstark@sberdevices.ru> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230627224017.1724097-1-gnstark@sberdevices.ru> References: <20230627224017.1724097-1-gnstark@sberdevices.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178297 [Jun 27 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: GNStark@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 517 517 b0056c19d8e10afbb16cb7aad7258dedb0179a79, {Tracking_from_domain_doesnt_match_to}, p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;sberdevices.ru:7.1.1,5.0.1, FromAlignment: s, {Tracking_white_helo}, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/06/27 18:27:00 #21588965 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769900084762373066?= X-GMAIL-MSGID: =?utf-8?q?1769900084762373066?= |
Series |
meson saradc: add iio channels to read channel 7 mux inputs
|
|
Commit Message
George Stark
June 27, 2023, 10:37 p.m. UTC
Add attribute 'label' to all iio channels.
Signed-off-by: George Stark <GNStark@sberdevices.ru>
---
drivers/iio/adc/meson_saradc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
Comments
On Wed, 28 Jun 2023 01:37:17 +0300 George Stark <gnstark@sberdevices.ru> wrote: > Add attribute 'label' to all iio channels. Why? Reasoning is more useful here than a simple statement of 'what'. > > Signed-off-by: George Stark <GNStark@sberdevices.ru> > --- > drivers/iio/adc/meson_saradc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index b87f05dfb322..85970fe852af 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -1058,8 +1058,20 @@ static int meson_sar_adc_calib(struct iio_dev *indio_dev) > return ret; > } > > +static int read_label(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + char *label) > +{ > + if (chan->type == IIO_TEMP) > + return sprintf(label, "%s\n", "temp-sensor"); > + if (chan->type == IIO_VOLTAGE) > + return sprintf(label, "channel-%d\n", chan->channel); > + return 0; > +} > + > static const struct iio_info meson_sar_adc_iio_info = { > .read_raw = meson_sar_adc_iio_info_read_raw, > + .read_label = read_label, > }; > > static const struct meson_sar_adc_param meson_sar_adc_meson8_param = {
On 7/2/23 12:16, Jonathan Cameron wrote: > On Wed, 28 Jun 2023 01:37:17 +0300 > George Stark <gnstark@sberdevices.ru> wrote: > >> Add attribute 'label' to all iio channels. > Why? Reasoning is more useful here than a simple statement of 'what'. Adding labels make sense only for newly-added channels, base channels' default node names are close enough to datasheet names. Ack for extending the commit message. >> Signed-off-by: George Stark <GNStark@sberdevices.ru> >> --- >> drivers/iio/adc/meson_saradc.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> index b87f05dfb322..85970fe852af 100644 >> --- a/drivers/iio/adc/meson_saradc.c >> +++ b/drivers/iio/adc/meson_saradc.c >> @@ -1058,8 +1058,20 @@ static int meson_sar_adc_calib(struct iio_dev *indio_dev) >> return ret; >> } >> >> +static int read_label(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + char *label) >> +{ >> + if (chan->type == IIO_TEMP) >> + return sprintf(label, "%s\n", "temp-sensor"); >> + if (chan->type == IIO_VOLTAGE) >> + return sprintf(label, "channel-%d\n", chan->channel); >> + return 0; >> +} >> + >> static const struct iio_info meson_sar_adc_iio_info = { >> .read_raw = meson_sar_adc_iio_info_read_raw, >> + .read_label = read_label, >> }; >> >> static const struct meson_sar_adc_param meson_sar_adc_meson8_param = {
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index b87f05dfb322..85970fe852af 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -1058,8 +1058,20 @@ static int meson_sar_adc_calib(struct iio_dev *indio_dev) return ret; } +static int read_label(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + char *label) +{ + if (chan->type == IIO_TEMP) + return sprintf(label, "%s\n", "temp-sensor"); + if (chan->type == IIO_VOLTAGE) + return sprintf(label, "channel-%d\n", chan->channel); + return 0; +} + static const struct iio_info meson_sar_adc_iio_info = { .read_raw = meson_sar_adc_iio_info_read_raw, + .read_label = read_label, }; static const struct meson_sar_adc_param meson_sar_adc_meson8_param = {