From patchwork Tue Jun 27 14:10:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 113443 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8242224vqr; Tue, 27 Jun 2023 07:31:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ67lL64+CmCNyok2nMXjVzrv2eSS6Taa/xMFeJhCaiiCQPd2g4Mexdy3vNsyhqwR1KriXeA X-Received: by 2002:a05:6808:120c:b0:39e:bcdc:4bd7 with SMTP id a12-20020a056808120c00b0039ebcdc4bd7mr27729130oil.24.1687876278614; Tue, 27 Jun 2023 07:31:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687876278; cv=none; d=google.com; s=arc-20160816; b=lIkrw5jgIqkpCRKbqI9pMsutrRMVLkPZut9y0ZSc//hGpWUOlpApm1kYGt+qAadIKD S9UXePsQM8f1csLZSLx8FNJMLe2TNFp0jMCTbamq+mdWDnnlNSK10Ez5ykXkODhBypDs DfsSsQB+IZWKpIy+NSjPYz+x2QtfRoeS1keIgGlvgmjDC7hVG4tZDznhNWLmrjFWFvOK 2TWeFSYFaWMxjxSeqsz7YnA/ro4zIh5NyhdtXZu86TxwKtakUSR/YNcaxk+3xNu+BjPQ kiT9TvHOgT6QKwr6lM8yXYhwBNCCEhWvh3B/+YHWz1t1jFV2hKQiZEa63bS1+4Sp2hrX Mn3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=y9aImzMW/PakC2TBzXaQ7zhnPtPy3XVwM3s4I1XFVYg=; fh=bFxd5zrf6YG5S02n3pDFk3gOSn4Vu7UZMSVWs1FN2Ek=; b=YK1q9ardwifw7g+0MKwu0/TGhU0fl/1OTyMugZWt5GEIqDvPfTEfcm0eClcW4xpdiB mQkuaZegP3YbkHT9u0/ekoOFaHLeAAwbv4iYbsZ8XN7BV2uJppP+vEyj5KjtQAwDAQFq xEdS56bKkh39Mv19zq0HgLfwJbfhKfcq2X/vFL/17dOrCk0NvAfYLOQnx7rQVxcX1avF MnR2JLfIDWF4BR+/IIU06XNIRUGFdOO6/2qjSdEkiAPI3HAGfzWppb4VPoCbvpBLRPdr ezrHkMSxoWLMIKZi1Y+oWRxZY9h7Bqp50rONVh02w8/RyeyS+KKrYsWxQFI0ujkGc9hf EgYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n30WKHJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p21-20020a63e655000000b0053439c1712esi6998055pgj.713.2023.06.27.07.31.03; Tue, 27 Jun 2023 07:31:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n30WKHJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbjF0OKt (ORCPT + 99 others); Tue, 27 Jun 2023 10:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230493AbjF0OKr (ORCPT ); Tue, 27 Jun 2023 10:10:47 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B36492D6A for ; Tue, 27 Jun 2023 07:10:45 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-666ed230c81so4076390b3a.0 for ; Tue, 27 Jun 2023 07:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687875045; x=1690467045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y9aImzMW/PakC2TBzXaQ7zhnPtPy3XVwM3s4I1XFVYg=; b=n30WKHJRZHvMomWhxgqD21t/bO/+pUUYZsxUxB+6+yZUlyC8n5P0vx1KOVfeRe1Wqk +W4mbn70eOuN9hgYvUtCmgDd3fjyz/1gSHvOUCY2+SM/5DAjQuwOswD8uLhwN47JeCoo KFdfVUeP4iEbpUCAr2kfdhZP6QPr6tuKEC2FzkqzlaJ1tOWbgQALGyuHTzLrOGip+8o/ pgIAuWMa0c5/042ZpuwBXvpb6A28QSuJnvWE6oWcd1nxUCQE7238ZHsUTueP/hkWLDsP RN0grXoMZChL1JJBmPiQXhBC/qokw4Wdv7yVy1SzapYHltYXFhmcG1aJUbI9nN0C43ng dKaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687875045; x=1690467045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y9aImzMW/PakC2TBzXaQ7zhnPtPy3XVwM3s4I1XFVYg=; b=dNZCs0lHc4U1wJBJ5etyDggSivcNkzdcfKhA0+aDm6UJeo7vhlVt8hVhY8/skgzAaK RoGivsSz6fhsU7WONzJboJYya8lVzM0upi9WQJER95VLs/ii52VIxewj/m+j4e0XH8RL gsk+5M4Yr/fwy4NJZvg8c+Uot/GVYtYHPcQGEsHTBQdtyOhRzoz2mkN49S5psGK3ok6u /JjtPNKV4d0fRye9sqOYy/dk2vSWI2BktTnEQ3uEE9S3sw30xQW98U+lOqV4PfB1Chpa 3W87CV1TsbNCMwUXP9J6g785RoO3uDLTukDR6blAjoAzwMcEs6FrnsbjylQvlETC74ic kL8g== X-Gm-Message-State: AC+VfDwE9AjFufny9wzQo3KRd4GPaeBQcTFllaMdMUaHIinPqtDa1lvg tbownlveDd+K/rAYLbtze0PW X-Received: by 2002:a05:6a20:3d87:b0:127:aaf:59a2 with SMTP id s7-20020a056a203d8700b001270aaf59a2mr8377010pzi.35.1687875045065; Tue, 27 Jun 2023 07:10:45 -0700 (PDT) Received: from localhost.localdomain ([117.217.176.90]) by smtp.gmail.com with ESMTPSA id n11-20020a6546cb000000b00528da88275bsm5254593pgr.47.2023.06.27.07.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 07:10:44 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , =?utf-8?q?Krzyszt?= =?utf-8?q?of_Wilczy=C5=84ski?= Subject: [PATCH] PCI: qcom-ep: Fix the write to PARF_MHI_CLOCK_RESET_CTRL register Date: Tue, 27 Jun 2023 19:40:36 +0530 Message-Id: <20230627141036.11600-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769866556692119128?= X-GMAIL-MSGID: =?utf-8?q?1769866556692119128?= Instead of writing the updated "val" that clears PARF_MSTR_AXI_CLK_EN, "val" is read again. Fix it! Fixes: c457ac029e44 ("PCI: qcom-ep: Gate Master AXI clock to MHI bus during L1SS") Reported-by: Krzysztof Wilczyński Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 0fe7f06f2102..267e1247d548 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -415,7 +415,7 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci) /* Gate Master AXI clock to MHI bus during L1SS */ val = readl_relaxed(pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL); val &= ~PARF_MSTR_AXI_CLK_EN; - val = readl_relaxed(pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL); + writel_relaxed(val, pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL); dw_pcie_ep_init_notify(&pcie_ep->pci.ep);