diff mbox series

[next] power: supply: bd99954: make read-only array sub_status_reg

Message ID 20230627121707.722021-1-colin.i.king@gmail.com
State New
Headers
Series [next] power: supply: bd99954: make read-only array sub_status_reg |

Commit Message

Colin Ian King June 27, 2023, 12:17 p.m. UTC 
  Don't populate the read-only array on the stack, instead make it
static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/power/supply/bd99954-charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matti Vaittinen June 27, 2023, 12:38 p.m. UTC | #1 
On 6/27/23 15:17, Colin Ian King wrote:
> Don't populate the read-only array on the stack, instead make it
> static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

Thanks!

Yours,
-- Matti
Sebastian Reichel July 19, 2023, 9:14 p.m. UTC | #2 
Hi,

On Tue, Jun 27, 2023 at 03:38:35PM +0300, Matti Vaittinen wrote:
> On 6/27/23 15:17, Colin Ian King wrote:
> > Don't populate the read-only array on the stack, instead make it
> > static const.
> > 
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

Thanks, queued.

-- Sebastian
diff mbox series

Patch

diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index 086dcf4033c1..1ed1d9f99fb3 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -536,7 +536,7 @@  static irqreturn_t bd9995x_irq_handler_thread(int irq, void *private)
 
 	for_each_set_bit(i, &tmp, 7) {
 		int sub_status, sub_mask;
-		int sub_status_reg[] = {
+		static const int sub_status_reg[] = {
 			INT1_STATUS, INT2_STATUS, INT3_STATUS, INT4_STATUS,
 			INT5_STATUS, INT6_STATUS, INT7_STATUS,
 		};