Message ID | 20230627-sm6125-dpu-v2-1-03e430a2078c@somainline.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8449561vqr; Tue, 27 Jun 2023 13:20:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6S5G6NDH/TBZ0j8j2TU0EBJoC0kWlf8iuvEmTD7s3fzjnI/d6xaUZBY/TFHCMlcE2oxK5p X-Received: by 2002:a05:6a20:7f8c:b0:11a:f632:78fb with SMTP id d12-20020a056a207f8c00b0011af63278fbmr42213274pzj.19.1687897239937; Tue, 27 Jun 2023 13:20:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687897239; cv=none; d=google.com; s=arc-20160816; b=TauAgCAtFjfy8uzl7/GOcjf9sgUwuJROE8Z8Wp3kXGAHGxpbGEfhN9Di4qRoePPUjv Mr0vYoG8IOQyILRnwgpgVUIKEOS3g00fPFEll/HkuD6yFMHyCAVzPgBRnzIr87gBI5Qi QXULeykOFBdEm1MugJcrdoUBciw0aqP+mctjNO+CkTz40ziiOVTcCAdTujkaFTThVfLR eL4LArIHNTOR+aEVM26bG4raQfZg2fZ8RoLEBH59lxFLKiK5WzoNEEYv5Q2WyvMcGY0n PGTD/exRsPKOd+m832RJzqSpA2ysG0XlasHzaCF4Vj2CqcbQfigj8rXsNmeL9EUFuJHX VohA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from; bh=t0R0KIkNKVABqNIiRjXMJxmYfsWDgtE5UWFvSpa8R5o=; fh=pj9lVTD7zJGSjaLEKdvLb7dkz1RbGKHUxYpQTxVQ54Y=; b=BoTmEjXXRGHzeNlwap11OqSODAFn+vbTU0JMYWzF09MHtDKBQ5L1kxou/6RMkLUg8b LosK02gavekGl/dluSLQi4HpvrALbiAluk5QaobA+RXSAA0HymCuPa9GQBWzD0aJCwRk euCDaX1q5XMsrdgD5ikG4T2x4ozHf1knNgdAdTtmLdoSl9olBzu2m+VALrAH2skHaI14 8YuaXFotEMnSMOBnWbdmRlJjdqdl/8E/pz1SS0vN/jhXfH8zJ/qAhNENc4eQZyJYqLzQ GtNe0kXEYIvEHbpsqGyGoglP4Z/y7mOGTZjXLSKgxltqZizKzI+ZciwEiqDyAKmp+KwM 4/NA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc18-20020a056a002e1200b00653fb3f21d3si8321390pfb.373.2023.06.27.13.20.27; Tue, 27 Jun 2023 13:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjF0UOe (ORCPT <rfc822;nicolai.engesland@gmail.com> + 99 others); Tue, 27 Jun 2023 16:14:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbjF0UOa (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 27 Jun 2023 16:14:30 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5229B1BDD for <linux-kernel@vger.kernel.org>; Tue, 27 Jun 2023 13:14:25 -0700 (PDT) Received: from Marijn-Arch-PC.localdomain (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 83E893F715; Tue, 27 Jun 2023 22:14:22 +0200 (CEST) From: Marijn Suijten <marijn.suijten@somainline.org> Date: Tue, 27 Jun 2023 22:14:16 +0200 Subject: [PATCH v2 01/15] drm/msm/dsi: Drop unused regulators from QCM2290 14nm DSI PHY config MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230627-sm6125-dpu-v2-1-03e430a2078c@somainline.org> References: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> In-Reply-To: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Krishna Manikandan <quic_mkrishn@quicinc.com>, Marijn Suijten <marijn.suijten@somainline.org>, Loic Poulain <loic.poulain@linaro.org>, Konrad Dybcio <konrad.dybcio@somainline.org> Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Martin Botka <martin.botka@somainline.org>, Jami Kettunen <jami.kettunen@somainline.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga <they@mint.lgbt> X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769888536159292889?= X-GMAIL-MSGID: =?utf-8?q?1769888536159292889?= |
Series |
drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel
|
|
Commit Message
Marijn Suijten
June 27, 2023, 8:14 p.m. UTC
The regulator setup was likely copied from other SoCs by mistake. Just
like SM6125 the DSI PHY on this platform is not getting power from a
regulator but from the MX power domain.
Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 --
1 file changed, 2 deletions(-)
Comments
On 27.06.2023 22:14, Marijn Suijten wrote: > The regulator setup was likely copied from other SoCs by mistake. Just > like SM6125 the DSI PHY on this platform is not getting power from a > regulator but from the MX power domain. > > Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index 3ce45b023e63..31deda1c664a 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1087,8 +1087,6 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { > > const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs = { > .has_phy_lane = true, > - .regulator_data = dsi_phy_14nm_17mA_regulators, > - .num_regulators = ARRAY_SIZE(dsi_phy_14nm_17mA_regulators), > .ops = { > .enable = dsi_14nm_phy_enable, > .disable = dsi_14nm_phy_disable, >
On 27/06/2023 23:14, Marijn Suijten wrote: > The regulator setup was likely copied from other SoCs by mistake. Just > like SM6125 the DSI PHY on this platform is not getting power from a > regulator but from the MX power domain. > > Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 6/27/2023 1:14 PM, Marijn Suijten wrote: > The regulator setup was likely copied from other SoCs by mistake. Just > like SM6125 the DSI PHY on this platform is not getting power from a > regulator but from the MX power domain. > > Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c index 3ce45b023e63..31deda1c664a 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -1087,8 +1087,6 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs = { .has_phy_lane = true, - .regulator_data = dsi_phy_14nm_17mA_regulators, - .num_regulators = ARRAY_SIZE(dsi_phy_14nm_17mA_regulators), .ops = { .enable = dsi_14nm_phy_enable, .disable = dsi_14nm_phy_disable,