diff mbox series

drm/tegra: Fix potential memory leak if vmap() fail

Message ID 20230626175805.672589-1-suijingfeng@loongson.cn
State New
Headers
Series drm/tegra: Fix potential memory leak if vmap() fail |

Commit Message

Sui Jingfeng June 26, 2023, 5:58 p.m. UTC 
  The vmap function called in the tegra_fbdev_probe() function could fail,
It doesn't matther. But if the error handling is necessary, it should
also free the resources allocated by drm_fb_helper_alloc_info() function
and the gem buffer object allocated by tegra_bo_create().

Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 drivers/gpu/drm/tegra/fbdev.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
index e74d9be981c7..d2152b5eb77b 100644
--- a/drivers/gpu/drm/tegra/fbdev.c
+++ b/drivers/gpu/drm/tegra/fbdev.c
@@ -141,6 +141,8 @@  static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 
 destroy:
 	drm_framebuffer_remove(fb);
+	drm_fb_helper_release_info(helper);
+	drm_gem_object_put(&bo->gem);
 	return err;
 }