diff mbox series

[v4,1/3] Documentation: arm: Add bootargs to the table of added DT parameters

Message ID 20230626143626.106584-1-alexghiti@rivosinc.com
State New
Headers
Series [v4,1/3] Documentation: arm: Add bootargs to the table of added DT parameters |

Commit Message

Alexandre Ghiti June 26, 2023, 2:36 p.m. UTC 
  The bootargs node is also added by the EFI stub in the function
update_fdt(), so add it to the table.

Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Song Shuai <songshuaishuai@tinylab.org>
---
 Documentation/arm/uefi.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Palmer Dabbelt July 6, 2023, 5:44 p.m. UTC | #1 
On Mon, 26 Jun 2023 07:36:24 PDT (-0700), alexghiti@rivosinc.com wrote:
> The bootargs node is also added by the EFI stub in the function
> update_fdt(), so add it to the table.
>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Reviewed-by: Atish Patra <atishp@rivosinc.com>
> Reviewed-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
>  Documentation/arm/uefi.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/arm/uefi.rst b/Documentation/arm/uefi.rst
> index baebe688a006..2b7ad9bd7cd2 100644
> --- a/Documentation/arm/uefi.rst
> +++ b/Documentation/arm/uefi.rst
> @@ -50,7 +50,7 @@ The stub populates the FDT /chosen node with (and the kernel scans for) the
>  following parameters:
>
>  ==========================  ======   ===========================================
> -Name                        Size     Description
> +Name                        Type     Description
>  ==========================  ======   ===========================================
>  linux,uefi-system-table     64-bit   Physical address of the UEFI System Table.
>
> @@ -67,4 +67,6 @@ linux,uefi-mmap-desc-ver    32-bit   Version of the mmap descriptor format.
>
>  kaslr-seed                  64-bit   Entropy used to randomize the kernel image
>                                       base address location.
> +
> +bootargs                    String   Kernel command line
>  ==========================  ======   ===========================================

I remember having said this somewhere, but it's not on lore for this 
version.  This touches Arm stuff, so I'd prefer an Ack from someone 
before touching it.

Also: it looks like this missed e790a4ce5290 ("arm: docs: Move Arm 
documentation to Documentation/arch/").
Jonathan Corbet July 21, 2023, 9:07 p.m. UTC | #2 
Alexandre Ghiti <alexghiti@rivosinc.com> writes:

> The bootargs node is also added by the EFI stub in the function
> update_fdt(), so add it to the table.
>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Reviewed-by: Atish Patra <atishp@rivosinc.com>
> Reviewed-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
>  Documentation/arm/uefi.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

So I'm not sure if I'm supposed to be applying these patches, or whether
they will go through the arch trees?

In the former case, they don't apply to docs-next, so could I get a
respin please?

Thanks,

jon
Alexandre Ghiti July 22, 2023, 10:49 a.m. UTC | #3 
On 21/07/2023 23:07, Jonathan Corbet wrote:
> Alexandre Ghiti <alexghiti@rivosinc.com> writes:
>
>> The bootargs node is also added by the EFI stub in the function
>> update_fdt(), so add it to the table.
>>
>> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
>> Reviewed-by: Atish Patra <atishp@rivosinc.com>
>> Reviewed-by: Song Shuai <songshuaishuai@tinylab.org>
>> ---
>>   Documentation/arm/uefi.rst | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> So I'm not sure if I'm supposed to be applying these patches, or whether
> they will go through the arch trees?
>
> In the former case, they don't apply to docs-next, so could I get a
> respin please?


Yes sure, I'll do that now. BTW  all the arch documentation was moved in 
Documentation/arch/, but not the riscv, are you working on this or 
should we?

Thanks,

Alex


>
> Thanks,
>
> jon
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Jonathan Corbet July 22, 2023, 7 p.m. UTC | #4 
Alexandre Ghiti <alex@ghiti.fr> writes:

>> In the former case, they don't apply to docs-next, so could I get a
>> respin please?
>
> Yes sure, I'll do that now. BTW  all the arch documentation was moved in 
> Documentation/arch/, but not the riscv, are you working on this or 
> should we?

I'll get there - unless somebody beats me to it :)

Thanks,

jon
diff mbox series

Patch

diff --git a/Documentation/arm/uefi.rst b/Documentation/arm/uefi.rst
index baebe688a006..2b7ad9bd7cd2 100644
--- a/Documentation/arm/uefi.rst
+++ b/Documentation/arm/uefi.rst
@@ -50,7 +50,7 @@  The stub populates the FDT /chosen node with (and the kernel scans for) the
 following parameters:
 
 ==========================  ======   ===========================================
-Name                        Size     Description
+Name                        Type     Description
 ==========================  ======   ===========================================
 linux,uefi-system-table     64-bit   Physical address of the UEFI System Table.
 
@@ -67,4 +67,6 @@  linux,uefi-mmap-desc-ver    32-bit   Version of the mmap descriptor format.
 
 kaslr-seed                  64-bit   Entropy used to randomize the kernel image
                                      base address location.
+
+bootargs                    String   Kernel command line
 ==========================  ======   ===========================================