From patchwork Mon Jun 26 09:14:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Hellstr=C3=B6m?= X-Patchwork-Id: 112818 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7356302vqr; Mon, 26 Jun 2023 02:39:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BnLOTJIDZ3R2dI1YVhC7Hnu1bHq9zcM7zXWAUs7/S31ntu/NvQbv+cYMSqa929QNBafv7 X-Received: by 2002:a17:907:980e:b0:98c:e0b5:f0cc with SMTP id ji14-20020a170907980e00b0098ce0b5f0ccmr10521360ejc.75.1687772351052; Mon, 26 Jun 2023 02:39:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687772351; cv=none; d=google.com; s=arc-20160816; b=OSCaAXrm2+x+HsMS5jKW8bOkHB3i7TYigMJVFxh9wIT1YFtj3Xof2ljMuOPkjoJxAk Rd9bIvIkowCznNmor88vJ+hDNNXOEeN391XJ5TjDXBBBo+oDCdlJh5C9xP0n73lIyfTf iKPgylzflNG1DiaBmGG4wv4+FyPdETSGqTntidKuy7UQbPOrqNhV+6vrXKkoyEYAN+5v +Xu/wsUp1sbJ9SjPdntuAyaLw3XqbDGouO1Uvd9hxFyzRxgEqRBU/8O+IHTQMk1RlsZM Af9nXxfQFlBv3OuppOrNkMzOtiBRG5bM5VB+5qIdkvD41E4ip+RjkScPtjHKSHJBpPKY o/QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K5BQAqsI+CyKMqj56ZlQosX2NbPhttKqN4s7ZzMSgFM=; fh=/8m5jrE18s7zSIDHLxEcBtnkE7/lq4KLyR0Tz1SuJlw=; b=ExQ9tFlJ1bnD5dC450gzFPNcX1rHB3D7fgtnYUhIk7y9G0kSB/vmII85GYnIlya0C1 +D+lgTm7IN3wWWKJCLfG1U8+V8FjouYfYCpX32dPevPwpR2ujtCcsHQVk+qZpfiIIXsk mFBoeb472c40OzMTvglCcTPRhucf+o2iuY6IofvaVYqIwQPGPowLQIwDPF91wH1G/JhN ZDEtwGEI4dVEf+ZY3rk7vBSppgYp1/ucHrmnv7w/6orF4nQ9tHADvZVXx0MjfvakbIny 0XIuPNjQ2lyrfnwXR2WGg000aGE+UHiGRXpSAaJRalrJN8TT1RBDk4jVeZa0/IxLRT+7 fZVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aLwyWWsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t16-20020a170906269000b00988f9dddfefsi2666643ejc.156.2023.06.26.02.38.46; Mon, 26 Jun 2023 02:39:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aLwyWWsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbjFZJUO (ORCPT + 99 others); Mon, 26 Jun 2023 05:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjFZJTK (ORCPT ); Mon, 26 Jun 2023 05:19:10 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60592D4A; Mon, 26 Jun 2023 02:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687770993; x=1719306993; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8NHvqn83ZvFUkevP/WNZb8GNDLDy33tL9NNl4xX0eyI=; b=aLwyWWsX615uznWBrBPf7iuNTGpGDJFApLlhktL8YxXs6c+YwpBaLtnh yqQObHa7R6/FYVSYLI5KqgcYYFUkGrTwWVgR/5Micc37PphTt6lgbOgVv JZNSNnbrngYlw6tss+HhbbjCyioMlC7aXVVnky/akpEqkRm++AAIr8HMW 2ovVf0MooA641iw6725vfbQ1hzgGRBRb3xlLdoereYzk4He6erzOg0VPJ QzoSPZGs1rHNGdLZrSckq+Dp+qFD3uu2daxJDa5J602CluME+eqpiJ0v7 +E1dAPuEDg69AQyR73s7BjxRUutqEM9LfTgrGOYtklfwXpAbwjKXvQSzn g==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="345974096" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="345974096" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 02:15:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="781357775" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="781357775" Received: from ettammin-mobl1.ger.corp.intel.com (HELO thellstr-mobl1.intel.com) ([10.249.254.105]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 02:15:05 -0700 From: =?utf-8?q?Thomas_Hellstr=C3=B6m?= To: intel-xe@lists.freedesktop.org Cc: =?utf-8?q?Thomas_Hellstr=C3=B6m?= , =?utf-8?q?Christian_K=C3=B6nig?= , Roger He , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Matthew Brost , linux-kernel@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , "Andi Shyti" Subject: [PATCH v2 2/4] drm/ttm: Don't shadow the operation context Date: Mon, 26 Jun 2023 11:14:48 +0200 Message-Id: <20230626091450.14757-3-thomas.hellstrom@linux.intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230626091450.14757-1-thomas.hellstrom@linux.intel.com> References: <20230626091450.14757-1-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769757581229610323?= X-GMAIL-MSGID: =?utf-8?q?1769757581229610323?= ttm_bo_swapout() shadows the ttm operation context which may cause major confusion in driver callbacks when swapping out !TTM_PL_SYSTEM memory. Fix this by reusing the operation context argument to ttm_bo_swapout(). Cc: "Christian König" Cc: Roger He Cc: Cc: Cc: # v4.16+ Fixes: dc947770cf34 ("drm/ttm: enable swapout for reserved BOs during allocation") Signed-off-by: Thomas Hellström Acked-by: Matthew Brost --- drivers/gpu/drm/ttm/ttm_bo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index bd5dae4d1624..615d30c4262d 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -1154,7 +1154,6 @@ int ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx, * Move to system cached */ if (bo->resource->mem_type != TTM_PL_SYSTEM) { - struct ttm_operation_ctx ctx = { false, false }; struct ttm_resource *evict_mem; struct ttm_place hop; @@ -1164,7 +1163,7 @@ int ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx, if (unlikely(ret)) goto out; - ret = ttm_bo_handle_move_mem(bo, evict_mem, true, &ctx, &hop); + ret = ttm_bo_handle_move_mem(bo, evict_mem, true, ctx, &hop); if (unlikely(ret != 0)) { WARN(ret == -EMULTIHOP, "Unexpected multihop in swaput - likely driver bug.\n"); goto out;