From patchwork Mon Jun 26 03:53:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= X-Patchwork-Id: 112726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7227712vqr; Sun, 25 Jun 2023 20:56:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ61kMxYgFZ8nlUuIfBShb4YU8qkBMEw5+SU2ni+HfZFAOpQBAY9iXu+L3QID3W8BTXscexz X-Received: by 2002:a17:906:5395:b0:991:bf04:2047 with SMTP id g21-20020a170906539500b00991bf042047mr1136838ejo.14.1687751810108; Sun, 25 Jun 2023 20:56:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687751810; cv=none; d=google.com; s=arc-20160816; b=ygqjEyu5EGVbOPMRkBclJXEOvjBSTciZBd5KNwi/iGaLbAmsyUQ+iNjF7ceqUs9H3P EbqopeqKVJO3DXP/WNTyoV7ZbhxCDaVF9O+UI/baFu/OnEQu6V7lK/HVTeM2Mz0h5xCr kTsRtA25bRiE1mpXfbIDjrD61cCUGZNVE/zcO5A1cTnaN/6+4WOKpZzD+hIGkbCzDuJe QQgEWqdZ4BHqItZeem5K6fxm3j0LRUZMXRIXdOpKyozXHZ0ONiMaHqrBGLaaLJ1u1Puc VqZqQ7izUQTucLSPWtfwpfqJhKk6nmEezI5GMi6B4x/L/sUhguUIdsn/+UE3/PIQCd9g G5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Gg3Iz7KZKq4AQwvOFCGnpPBddjNqoKfPPS0/EGMhENI=; fh=hRh0dkRCnSL0FdUyVBKnNvf+qbxIVe5KZjmuDrMUaZg=; b=aP1mpjTXF2QdmTDFMDR7BN9a6BlbPTQxV41zjcgn9ziQOAtzJleVbHlO5eSYEKikE6 VgwQjykHtbVB2WvV32R8rJiFdPFkU6k6uJ6nIHtZZO3f4kulzX0toYL6f/gFb17BgWKv Dk8NdzBf4G4qRTwLwH5uS28uwUqNr9wWqGIYDu0KmlnufxgAvH1rG1b5/vkAPzsOmcIt /iwxzFEWM+4jgVC4r/y2oW3y6gviKetEDE29hX0D7JsUQ+ywCvijQfNVGod+nCgx6lBO fFH+s5NqzeCU80ywEGeaFH0df5rZjsKUMcM3ENQ8XMfCewogdIAIUKBn01+gVAdEeWtS ktRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="PuO3u/XJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020aa7ce0a000000b0051a44b631casi2125948edv.360.2023.06.25.20.56.26; Sun, 25 Jun 2023 20:56:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="PuO3u/XJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbjFZDyJ (ORCPT + 99 others); Sun, 25 Jun 2023 23:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjFZDyA (ORCPT ); Sun, 25 Jun 2023 23:54:00 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B721A1AA; Sun, 25 Jun 2023 20:53:58 -0700 (PDT) X-UUID: 0ff9f3d413d511eeb20a276fd37b9834-20230626 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=Gg3Iz7KZKq4AQwvOFCGnpPBddjNqoKfPPS0/EGMhENI=; b=PuO3u/XJG2XZiBhjIC8YTz/mw/1AoNOQU1pmhXOPmuN3DkWTQS7FSaVQLf6DdUjsUai7MiJ8j8ZPStcAeX6/0/0VAcAG+boDywanWmmSqK4S1hM2Q6a7lElu2R30UZ9FLQmpJj/lgG0yULcX4CKNTtmnECkAx/76z983HiHu0p4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:83b16f07-ba2f-4a6b-babe-9c6257e87c76,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:01c9525,CLOUDID:53531770-2f20-4998-991c-3b78627e4938,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 0ff9f3d413d511eeb20a276fd37b9834-20230626 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1634227972; Mon, 26 Jun 2023 11:53:51 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 26 Jun 2023 11:53:49 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 26 Jun 2023 11:53:49 +0800 From: Yunfei Dong To: =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert CC: Yunfei Dong , Chen-Yu Tsai , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , , , , , , Subject: [PATCH v4,01/11] media: mediatek: vcodec: remove unused parameter Date: Mon, 26 Jun 2023 11:53:36 +0800 Message-ID: <20230626035346.30654-2-yunfei.dong@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230626035346.30654-1-yunfei.dong@mediatek.com> References: <20230626035346.30654-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769736042178495067?= X-GMAIL-MSGID: =?utf-8?q?1769736042178495067?= remove unused parameter in struct mtk_vcodec_dev. Signed-off-by: Yunfei Dong Reviewed-by: Nicolas Dufresne --- drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 -- drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h | 6 ------ drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 -- 3 files changed, 10 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c index d41f2121b94f..03721eda2769 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c @@ -336,8 +336,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) goto err_core_workq; } - init_waitqueue_head(&dev->queue); - vfd_dec = video_device_alloc(); if (!vfd_dec) { mtk_v4l2_err("Failed to allocate video device"); diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h index f17d67e781c9..e3230a4d7b8e 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h @@ -448,10 +448,7 @@ struct mtk_vcodec_enc_pdata { * @decode_workqueue: decode work queue * @encode_workqueue: encode work queue * - * @int_cond: used to identify interrupt condition happen - * @int_type: used to identify what kind of interrupt condition happen * @dev_mutex: video_device lock - * @queue: waitqueue for waiting for completion of device commands * * @dec_irq: decoder irq resource * @enc_irq: h264 encoder irq resource @@ -496,10 +493,7 @@ struct mtk_vcodec_dev { struct workqueue_struct *decode_workqueue; struct workqueue_struct *encode_workqueue; - int int_cond; - int int_type; struct mutex dev_mutex; - wait_queue_head_t queue; int dec_irq; int enc_irq; diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c index 5df0a22ff3b5..a56652e476c2 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c @@ -311,8 +311,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) goto err_res; } - init_waitqueue_head(&dev->queue); - /* allocate video device for encoder and register it */ vfd_enc = video_device_alloc(); if (!vfd_enc) {