From patchwork Mon Jun 26 03:53:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= X-Patchwork-Id: 112730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7227832vqr; Sun, 25 Jun 2023 20:57:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FlEOGRVyRcXOQPnYvWMjYlpRNAuW8D4QQKAv3s82JpSbym75KcVhyEHkIif/tI4PMoLpQ X-Received: by 2002:a17:907:168c:b0:98c:e3a1:dbba with SMTP id hc12-20020a170907168c00b0098ce3a1dbbamr13095130ejc.4.1687751831949; Sun, 25 Jun 2023 20:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687751831; cv=none; d=google.com; s=arc-20160816; b=JYKEY4PJ6PxockJKQIgGXtwqubxaV9xosQCC3LiYLIpYg9PfuKutand8Len7hNk9hd fCT7YYgc0K7peIaZ4OWyVqou8haPaOcgyr7XyqsH36TjxuAbSWykAZ4u413lNVrW1F0E gBBif+BanbrGCcF5NuuCn3FFeyyrEwapboG5fbzVC3qRXp3kgfbUUrIUflYCrEiyW2et iHRHeYGZGTQXwnNhyn48ehst00Q41YNRQRKVwQ6O+6rGETFCNntaO7Lhr0AUyDZhot0w 5wX8HjlorUqXgw1IvhQESi+ZUnuK1KB7QYdHylQYnyDuUezp3VNj4GaIidRPD+JLKwiM MavA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7J44CPJLVuQmKx8uRsJDBq0OUSEiyngOmORztKqfS/o=; fh=hRh0dkRCnSL0FdUyVBKnNvf+qbxIVe5KZjmuDrMUaZg=; b=h0tKCkCcOzxQMGkJEtgppM+96iH/3Ed8XZLV9k1cnVq4qqOoB6y0qug821QK6B4CNX kSP8r9QPNfUq5nks335l6r9uLnylYW16349OlEP3JBNsfCDSGUwD+6GEsvZ0hgFFJyYF SEhP+deeaQChm5KX8pTpLClMGCQ+cUrKUuxRerffsr/AFU9q4R3OoNRO/26/sLaVEasf nQltD1iDo0LZgS5q9hPCbc/4IGh9UvKx1X7W6R4D2vZFC575D72ZBP1uKryJNinraZoK YyYoF/276KSanZhw7X2eLJnF7Gnc849ed/lnFOcTDdp6z4heyCEQ5kRsd7afMZfWVmJ6 uNEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=GL3qXL0A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a056402134b00b005163242f90csi2085666edw.184.2023.06.25.20.56.47; Sun, 25 Jun 2023 20:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=GL3qXL0A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbjFZDzR (ORCPT + 99 others); Sun, 25 Jun 2023 23:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbjFZDyp (ORCPT ); Sun, 25 Jun 2023 23:54:45 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A460CE4C; Sun, 25 Jun 2023 20:54:07 -0700 (PDT) X-UUID: 153fed5813d511eeb20a276fd37b9834-20230626 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=7J44CPJLVuQmKx8uRsJDBq0OUSEiyngOmORztKqfS/o=; b=GL3qXL0A/ddYsMv77FyfVcopx7T2qC+zfpcC/xHRkaV19ydvZshs6aJPINubUV2SToRN/Unn8It9hijDPWprqfWGxEmMPmric8BuGLWwIKv924WqSKXW0ZobycYFuOgz4HgVDWOxaFPlR9zQuaswDtAb5BkLCdzVjL3+5GP5Y5U=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:a3636070-37f8-4e11-9b3d-db35917f8e5d,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:70 X-CID-INFO: VERSION:1.1.27,REQID:a3636070-37f8-4e11-9b3d-db35917f8e5d,IP:0,URL :0,TC:0,Content:-25,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTI ON:quarantine,TS:70 X-CID-META: VersionHash:01c9525,CLOUDID:f0b5a33f-7aa7-41f3-a6bd-0433bee822f3,B ulkID:230626115403N7IPGFZ9,BulkQuantity:0,Recheck:0,SF:28|17|19|48|38|29,T C:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SDM,TF_CID_SPAM_ASC,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD, TF_CID_SPAM_SNR X-UUID: 153fed5813d511eeb20a276fd37b9834-20230626 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1795394905; Mon, 26 Jun 2023 11:54:00 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 26 Jun 2023 11:53:58 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 26 Jun 2023 11:53:57 +0800 From: Yunfei Dong To: =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert CC: Yunfei Dong , Chen-Yu Tsai , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , , , , , , Subject: [PATCH v4,09/11] media: mediatek: vcodec: fix unreasonable parameter definition and style Date: Mon, 26 Jun 2023 11:53:44 +0800 Message-ID: <20230626035346.30654-10-yunfei.dong@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230626035346.30654-1-yunfei.dong@mediatek.com> References: <20230626035346.30654-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769736064742055485?= X-GMAIL-MSGID: =?utf-8?q?1769736064742055485?= Fix unreasonable coding style. Fix unreasonable parameter definition. Signed-off-by: Yunfei Dong Reviewed-by: Nicolas Dufresne --- .../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h | 4 ++-- .../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h index a18ba8f32d41..1a0375dd5b6d 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h @@ -19,7 +19,7 @@ #define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING) /* - * struct mtk_vdec_format_types - Structure used to get supported + * enum mtk_vdec_format_types - Structure used to get supported * format types according to decoder capability */ enum mtk_vdec_format_types { @@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev { const struct mtk_vcodec_dec_pdata *vdec_pdata; struct mtk_vcodec_fw *fw_handler; - unsigned long id_counter; + u64 id_counter; /* decoder hardware mutex lock */ struct mutex dec_mutex[MTK_VDEC_HW_MAX]; diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h index a88ef9078848..4804d8531a4e 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h @@ -32,13 +32,13 @@ */ struct mtk_vcodec_enc_pdata { bool uses_ext; - unsigned long min_bitrate; - unsigned long max_bitrate; + u64 min_bitrate; + u64 max_bitrate; const struct mtk_video_fmt *capture_formats; size_t num_capture_formats; const struct mtk_video_fmt *output_formats; size_t num_output_formats; - int core_id; + u8 core_id; bool uses_34bit; }; @@ -208,7 +208,7 @@ struct mtk_vcodec_enc_dev { const struct mtk_vcodec_enc_pdata *venc_pdata; struct mtk_vcodec_fw *fw_handler; - unsigned long id_counter; + u64 id_counter; /* encoder hardware mutex lock */ struct mutex enc_mutex;