[3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt

Message ID 20230626-topic-bindingsfixups-v1-3-254ae8642e69@linaro.org
State New
Headers
Series random msm bindings fixes |

Commit Message

Konrad Dybcio June 26, 2023, 8 p.m. UTC
  Add the missing short interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['ovp'] is too short

Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Luca Weiss June 26, 2023, 8:17 p.m. UTC | #1
On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> Add the missing short interrupt. This fixes the schema warning:
> 
> wled@d800: interrupt-names: ['ovp'] is too short
> 
> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> 100644
> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
>  		pm6150l_wled: leds@d800 {
>  			compatible = "qcom,pm6150l-wled";
>  			reg = <0xd800>, <0xd900>;
> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
> -			interrupt-names = "ovp";
> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "ovp", "short";

Are you sure this interrupt really exists? It's not a thing used downstream at
least:
https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293

Regards
Luca

>  			label = "backlight";
> 
>  			status = "disabled";
  
Konrad Dybcio June 26, 2023, 8:18 p.m. UTC | #2
On 26.06.2023 22:17, Luca Weiss wrote:
> On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
>> Add the missing short interrupt. This fixes the schema warning:
>>
>> wled@d800: interrupt-names: ['ovp'] is too short
>>
>> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
>>  		pm6150l_wled: leds@d800 {
>>  			compatible = "qcom,pm6150l-wled";
>>  			reg = <0xd800>, <0xd900>;
>> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
>> -			interrupt-names = "ovp";
>> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
>> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-names = "ovp", "short";
> 
> Are you sure this interrupt really exists? It's not a thing used downstream at
> least:
> https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> 
Confirmed with a reliable source.

Konrad
> Regards
> Luca
> 
>>  			label = "backlight";
>>
>>  			status = "disabled";
> 
> 
> 
>
  
Luca Weiss June 26, 2023, 8:26 p.m. UTC | #3
On Montag, 26. Juni 2023 22:18:11 CEST Konrad Dybcio wrote:
> On 26.06.2023 22:17, Luca Weiss wrote:
> > On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> >> Add the missing short interrupt. This fixes the schema warning:
> >> 
> >> wled@d800: interrupt-names: ['ovp'] is too short
> >> 
> >> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >> 
> >>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> >> 100644
> >> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
> >> 
> >>  		pm6150l_wled: leds@d800 {
> >>  		
> >>  			compatible = "qcom,pm6150l-wled";
> >>  			reg = <0xd800>, <0xd900>;
> >> 
> >> -			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>;
> >> -			interrupt-names = "ovp";
> >> +			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>,
> >> +				     <0x5 0xd8 0x2 
IRQ_TYPE_EDGE_RISING>;
> >> +			interrupt-names = "ovp", "short";
> > 
> > Are you sure this interrupt really exists? It's not a thing used
> > downstream at least:
> > https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/
> > android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> Confirmed with a reliable source.

Fine by me then.

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> 
> Konrad
> 
> > Regards
> > Luca
> > 
> >>  			label = "backlight";
> >>  			
> >>  			status = "disabled";
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
index 6a7fe1e59f15..d13a1ab7c20b 100644
--- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
@@ -121,8 +121,9 @@  pm6150l_flash: led-controller@d300 {
 		pm6150l_wled: leds@d800 {
 			compatible = "qcom,pm6150l-wled";
 			reg = <0xd800>, <0xd900>;
-			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
-			interrupt-names = "ovp";
+			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
 			label = "backlight";
 
 			status = "disabled";