From patchwork Sun Jun 25 16:28:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 112641 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6997535vqr; Sun, 25 Jun 2023 09:30:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5mHbVvP6qF8DtJOIdzqoiLoy+SH9Y/HMyqH57bUKTS37KYNY6tObFC6MYL/zypwq9gIKx5 X-Received: by 2002:a17:907:272a:b0:98d:6e25:aa5e with SMTP id d10-20020a170907272a00b0098d6e25aa5emr6668275ejl.31.1687710657930; Sun, 25 Jun 2023 09:30:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687710657; cv=none; d=google.com; s=arc-20160816; b=iNuPK6vSoWl43F8+MvZbClOGV9arjHWQRMx4OMyKoDnMF9z1RuAV4w2vvHEr0PUaZ5 pFZimceDggk8TIVtd/bgQltD5EreV+keMOkuEr9O2h6toxFnQRHkb2EvhKO+AgQ9qAG6 TS7qLBjuV5YTF/qukbW9QfHXA3UG0pQIuFu/I97Xthjf1fwO5OMCsNhKCLG00kKWPmpk AwMx2MGDAvLsg+2WfVQgklVCt9OjA1I2IMxoQMR9Mfb2iVboFApDYCQc7ZSaQ5NMJHbp EpC8RpCw7U5VONNBog8qH2I86PziuyiB8qt2Ipw5qEu62WJ9JEHb0/uD4Tp26AwixQgs 0rUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sNSURL3k6Qay5bYk2FFSYR3PPWS59SfGVXg9PpOHVeA=; fh=9JCOumVf9dngCFHiV6Hmkcm2vnKQxEc42icPYm2blNQ=; b=HLqzSU+rsbxWOh5901lCZBBj+WtLLH75ayxLLgvQqo+UH33wgyNyT7khk0dfinyvCR uMEwEK+8nXfeKwFSOUXGsT62b9z2LCiMyBYJhnEbxjarBYU+C2fbKfWU5yAjacH/y0Oy rroUzRoH0G6iFYN/bP1XltWup6ljgHbBb6Nseuyvn0xQ1IQZ7T6Helzo3YzR44uSTdzJ wu1UC1UKyYw/v+Ru+qH8/NWhyuLje5WBOD6mt7e32PiKl+qNfTTza/kC3qFtjmpxOefC H0ZLjUXKPDUeJDytnagvCaopqE7r281migat3xNyQLj56UwjYtvwFDdYpDu5i1ElKbEN wJYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AxBkfFnS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gr1-20020a170906e2c100b00974d5816686si1901444ejb.66.2023.06.25.09.30.33; Sun, 25 Jun 2023 09:30:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AxBkfFnS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbjFYQ3G (ORCPT + 99 others); Sun, 25 Jun 2023 12:29:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjFYQ2t (ORCPT ); Sun, 25 Jun 2023 12:28:49 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BAD9BD for ; Sun, 25 Jun 2023 09:28:39 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-98e25fa6f5bso160104766b.3 for ; Sun, 25 Jun 2023 09:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687710517; x=1690302517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sNSURL3k6Qay5bYk2FFSYR3PPWS59SfGVXg9PpOHVeA=; b=AxBkfFnSYMeyDyifssvOcSpvlHZk/yg55Z26BVi9K72MFLzpaCXoujbiTwBfdjxD7l NwbDaAVbb3yecQ0+2am8/x2+MoSlMSi7sdvA1NXXAImIeFia6yJMnK0XF9M87RXMMShs uS6w256K389mkMZUuaxfhPEzd1tGrRJjlvUwBCC/jPgNIB+AGC04hU17X2XqS0IAybjr RQfOEz7Ip6zcf1vCF4sJwPMtsMTdpfAswuF3h/2P0cCHOCeVOcsV1xvN0IR96sPa+i7e +Df1gBmmmatCAmK1Hsfx/kwck9xTku4oENk2YanlIM+kCucMLFXUSGqLmkojmc3s3353 pdyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687710517; x=1690302517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sNSURL3k6Qay5bYk2FFSYR3PPWS59SfGVXg9PpOHVeA=; b=YDDSlzCXHjB2isXtXVPTdURD4Tj1Fb/5fb7yDziJtKr8OBnva9mKy3O41M6xLielcp eEE5nCTc8QHXcTF3Q7XRbIGfTPfAEukwrZ7ni4GsEhUUMYOU9SWZ/QEJGT6EV/k2vcvK R9peOGc6UC6n2efda+VoBMQkVv5S2AoczcD4xbaXCCaMhqI8wnvMGYZPhZk6Wdtf6JU1 xCk7HcGjfrNGoklCI+nxvfKCfGJkXYzJKrHH7n1rRwyi3FxcZ96JcAw3I4olrarkxS4X QuJUuytV0b6ZFKqYhLE+Qy8t2boQLore2Y2EzxL2OTYP2gqfGcb4+0nAWeizfOW+sKKm Przw== X-Gm-Message-State: AC+VfDygiVegAyt4DN9h2zRMHGMw1jXOmOdStHzDKbH3i8xqKLMxDhK7 oxqSuVguc0hxSomFHDLdpAgAZg== X-Received: by 2002:a17:907:8a1a:b0:98e:419b:4cbc with SMTP id sc26-20020a1709078a1a00b0098e419b4cbcmr2616998ejc.12.1687710517664; Sun, 25 Jun 2023 09:28:37 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ec10-20020a170906b6ca00b00982be08a9besm2277731ejb.172.2023.06.25.09.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 09:28:37 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , =?utf-8?q?Mika_Penttil=C3=A4?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Andi Shyti , Andy Shevchenko , Krzysztof Kozlowski , Andy Shevchenko Subject: [PATCH v4 08/24] Input: chipone_icn8318 - Simplify with dev_err_probe() Date: Sun, 25 Jun 2023 18:28:01 +0200 Message-Id: <20230625162817.100397-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> References: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769692890497967025?= X-GMAIL-MSGID: =?utf-8?q?1769692890497967025?= Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/touchscreen/chipone_icn8318.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/chipone_icn8318.c b/drivers/input/touchscreen/chipone_icn8318.c index 9fbeaf17f00b..d6876d10b252 100644 --- a/drivers/input/touchscreen/chipone_icn8318.c +++ b/drivers/input/touchscreen/chipone_icn8318.c @@ -191,12 +191,8 @@ static int icn8318_probe(struct i2c_client *client) return -ENOMEM; data->wake_gpio = devm_gpiod_get(dev, "wake", GPIOD_OUT_LOW); - if (IS_ERR(data->wake_gpio)) { - error = PTR_ERR(data->wake_gpio); - if (error != -EPROBE_DEFER) - dev_err(dev, "Error getting wake gpio: %d\n", error); - return error; - } + if (IS_ERR(data->wake_gpio)) + return dev_err_probe(dev, PTR_ERR(data->wake_gpio), "Error getting wake gpio\n"); input = devm_input_allocate_device(dev); if (!input)