From patchwork Sun Jun 25 16:27:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 112637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6997492vqr; Sun, 25 Jun 2023 09:30:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ62s7pWmxkLVvC9y+pNC64Pbi78HBk/j/uIv7+MxAeHiYmoEawD8L3dU/9nc6f+T3FZokfk X-Received: by 2002:a17:907:702:b0:982:be38:a5df with SMTP id xb2-20020a170907070200b00982be38a5dfmr22626821ejb.63.1687710653355; Sun, 25 Jun 2023 09:30:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687710653; cv=none; d=google.com; s=arc-20160816; b=TbW5/OG9gwW4es3p69J88ro5JN6DE02P9DF8KYxK5dST1pVYCpbdrJ8VYqX4VpFWjC paE5e2QTioWkOGi6qGS/H6yCOoDhroX2bfGJno5xHJrqX8QoqyEGn81SpbVkw1ra6B6t 2zbbiJTRoMLSInigMqHEeEwexFLGpujKPkr/RIGnG/R2LTIW8PKnaLS+H1vpzdY1jJAH yMPTkd0tCV8Yk7SjEv8x7fyKsbbWMyZERCK73eUr0CS1RXbAk0L3FTInu5OlkYJjRUyU 6ywLOb1gbrkWLgYXZpaHy9xf+pDyZQYnlF2duMc53sqxQW4WI7UdmNE9mUt+CO+ofiig CD1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PQQKSSUy+f0J5aGwdtUfDXCIC6e04ohCti7qa0/jnj4=; fh=9JCOumVf9dngCFHiV6Hmkcm2vnKQxEc42icPYm2blNQ=; b=bYyOCPGrwl5rBtuYMHQ0b4YqcqzGXOZd0c16y44g8j3v8kCtv89zLWKjeB2p3b2MWI gL1vxz7PuQsJqAypmTeks3L8L/wYWjj3h9Px5XjPOFRDtRvfXvfaPXmHhB8ct24sqPzI Bu08fZXIb2b+XxoZyP0Zzk7uXfnc9cRcZ95rt9MTBXlXaVcQc73L8ujuuTKY3RkTInQS ezmyZ5Uyt8YFBrYb8OfxhUE1YllI6okGVCR4Ha9uDBdvA6f6HDlY8yC5OKg2BAavPpw4 NYAEt5A1bbZinEr/ktQQWsvYG3GDOEx+zaHS2g15t37nJetS0xRBw4rBnCAZBVS8Iiy1 RDMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WqrjXLMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay14-20020a056402202e00b0051d91303c5fsi1090464edb.677.2023.06.25.09.30.29; Sun, 25 Jun 2023 09:30:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WqrjXLMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbjFYQ2o (ORCPT + 99 others); Sun, 25 Jun 2023 12:28:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbjFYQ2e (ORCPT ); Sun, 25 Jun 2023 12:28:34 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 037361A5 for ; Sun, 25 Jun 2023 09:28:32 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-98377c5d53eso293551466b.0 for ; Sun, 25 Jun 2023 09:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687710510; x=1690302510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PQQKSSUy+f0J5aGwdtUfDXCIC6e04ohCti7qa0/jnj4=; b=WqrjXLMk8MjPhCqBb7u4L85CzjKQP0v6bdDMWRRvVx4A4YiLvtd3udbtnWs5Kf2W1E syLob4whf20gprUtgDIS7uLzTwIl8Mc1jXaZoNti8nruVXk1U3wJLBTzZ2fanPbkAZ/1 Uk/Df7kmPyc9gHwT0lcAWG/3GhnpMx8jqY4xaZDymdb/SOeCE/Q+pNTGn5CHaS392JLR xdWHcLbxeKJU3k4JdEuitQG576I8ycIx4LaIOhor9ggDtCV+oDoIigt/P8WAV/eyTv1Y j+pc2XZy6BEQbPhvjlqL/7Ry1vMOnlfA66OiA19iQTr3S/y917LO3kn7y9VnvUzEoKJ1 VvZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687710510; x=1690302510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PQQKSSUy+f0J5aGwdtUfDXCIC6e04ohCti7qa0/jnj4=; b=TEDiCK62zv5euJA3aAXjgbZE/Vgberr82QeatJyyPAeL8EPyujXdGNAM6LmNaDI2A5 EDRfBxM2rACNYJ40kWdknGhFfq0OluuJBhz0VTHFquVOeuBpmbSbK3OQS20uaF9yQ259 Sz8oWgmfIEbOV+3Q2ZuaZ8sc6f3qLs9QuGGYb7JhsBMLMfRXH4xb2zr43sPZZboTV+iQ FxIFuGtzi2glN5HHICg6spgTKnwTqriZOp40mjFzB62Pb99jPyP2h1i/LzwNtLnVUW72 r3aT6NfaccCkhOBcBAl2J/KkFuP0XmBvIIBBs8sdWKJFiloZS3UzsZtcyRU6y4BhsTkq 0A9A== X-Gm-Message-State: AC+VfDzhtviw1CMAiHefBTGSpeAV2XJO0jK0GLzYmPUVrAV+cCYoyTr2 a1pa1l6OjXG0PsMIYQSmpY5vhg== X-Received: by 2002:a17:907:ea9:b0:98e:2c13:c44d with SMTP id ho41-20020a1709070ea900b0098e2c13c44dmr2466192ejc.68.1687710510279; Sun, 25 Jun 2023 09:28:30 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ec10-20020a170906b6ca00b00982be08a9besm2277731ejb.172.2023.06.25.09.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 09:28:29 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , =?utf-8?q?Mika_Penttil=C3=A4?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Andi Shyti , Andy Shevchenko , Krzysztof Kozlowski , Andy Shevchenko Subject: [PATCH v4 04/24] Input: rotary_encoder - Simplify with dev_err_probe() Date: Sun, 25 Jun 2023 18:27:57 +0200 Message-Id: <20230625162817.100397-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> References: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769692886031829751?= X-GMAIL-MSGID: =?utf-8?q?1769692886031829751?= Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/misc/rotary_encoder.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c index 22ec62083065..fb3a34f8eccd 100644 --- a/drivers/input/misc/rotary_encoder.c +++ b/drivers/input/misc/rotary_encoder.c @@ -236,12 +236,8 @@ static int rotary_encoder_probe(struct platform_device *pdev) device_property_read_bool(dev, "rotary-encoder,relative-axis"); encoder->gpios = devm_gpiod_get_array(dev, NULL, GPIOD_IN); - if (IS_ERR(encoder->gpios)) { - err = PTR_ERR(encoder->gpios); - if (err != -EPROBE_DEFER) - dev_err(dev, "unable to get gpios: %d\n", err); - return err; - } + if (IS_ERR(encoder->gpios)) + return dev_err_probe(dev, PTR_ERR(encoder->gpios), "unable to get gpios\n"); if (encoder->gpios->ndescs < 2) { dev_err(dev, "not enough gpios found\n"); return -EINVAL;