From patchwork Sun Jun 25 16:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 112648 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6998346vqr; Sun, 25 Jun 2023 09:32:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7iRJOHSMy5PhsDy0z4CXcotW7tguRMA75V2lpJ2QzsdP/UUNOQ4YOCzRoe/2DeRplCmepE X-Received: by 2002:aa7:de11:0:b0:51b:ea1d:bc31 with SMTP id h17-20020aa7de11000000b0051bea1dbc31mr6036325edv.26.1687710745686; Sun, 25 Jun 2023 09:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687710745; cv=none; d=google.com; s=arc-20160816; b=sdUfeZ0xPFBLfTtJB/LdPKUhoLlEBNgbBsxWlpQpHG44ysK6UsKifcFvcNHvDkVBgw 46vZutC5ZL1H741N1V15euXXw4SGE+8VUrfa0vrBm7Pimt33Nd8y7VkEPvUPNSE9NwSu ONsWhhxemMH0LtRXovniXYIR3ZZ8ca314aKm556MjKU6yj7VZdnOR6htc6HG0bJuTQhZ vaD+/BySmC9istryRG0pvpa2LSc73iko/OjYfNsLbpyrPTE3ZNLRl+NJTW8kjbeGm5tN h5LVRK/5jxhSFIaXCb15TAtR4WGLXGHyH3FcYspkKH28VYQAGFJGFT+zXL+kV+lCYWXn vw6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dFNLWz5nb9xBhB40IBJoDah+KxzePJk8q7QGRODucW0=; fh=9JCOumVf9dngCFHiV6Hmkcm2vnKQxEc42icPYm2blNQ=; b=ltdoMVCOP6+AkJ1lRwWhhvjfh/L0Gv6I/2wRapneYI1kAMFKpnr7/cnzIjczvAF6Mo mPevjjTNkZbhjA09RGoSaNUG+URfr4ge65cfq3pyLYPxz9q5/s2ZPjtNxFbeAd7sC/8l bdaQhA8JC8S6+W99jTIdhKrZbllzM7oJk50n0dfakxbdMQ0gfZPbB0IF/g3XCPvKPobj 9faHNBWbL0W1cWZmMFVMyYs2YTDRval8vhb05TBnmqvemBScAKiDy21c1wOrqQrABUY1 JyzEyK4lumlWruIaq0jg+uZQRxxsaw5XDKla4O+KZvFj64W1kb3fjYjDTRYnJF03WEft 7GWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ob0lMxAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020aa7d848000000b0051a2168bb64si1673245eds.389.2023.06.25.09.32.02; Sun, 25 Jun 2023 09:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ob0lMxAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231935AbjFYQaU (ORCPT + 99 others); Sun, 25 Jun 2023 12:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjFYQ3o (ORCPT ); Sun, 25 Jun 2023 12:29:44 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC9AE71 for ; Sun, 25 Jun 2023 09:29:26 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-98df69cacd1so73205666b.1 for ; Sun, 25 Jun 2023 09:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687710540; x=1690302540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dFNLWz5nb9xBhB40IBJoDah+KxzePJk8q7QGRODucW0=; b=ob0lMxAwJrExIVf3oDeXjQ+jA6kXqRF/1aB785MgbNcpsFJMzGAFqFqFU3QJ0Wx437 lf0QxL+6yym9EKpnkTrjiXQrQVauNv88Ex2a2QmeV3DI9cHL9R6z2laDzsULdZ38iXPk bENqFNUI9+CT3IE4JUaecgT+iPnkQ6zSGhSYOQN7KALHcjUy/hTk8Wq9vhfkkkiYlb3X fjA5Tyu406KjZ5NozbmI1U710BcMxDQVNB0rrCFGYpRjGlmqry/P4F2XRtX4wxy3OF8i HLe+1P+BO9bOe9oMJ3TanB7IJemcN4HveJ7rSuASMevLNsP9iMKp3mFoRTBVK89M4PYQ 9FVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687710540; x=1690302540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dFNLWz5nb9xBhB40IBJoDah+KxzePJk8q7QGRODucW0=; b=VXwrk52hRZB+ECgKg48V9ZCSokaaeK88//MCPgmQodUyF6QqHICllqwEIiNnoAaLq3 Dji2dGtE4A6WDasOCcoHePbn9plVUhXfi9Pvyaab3DeU02JxiRZMPl5kdlve9iGU4OFh dyqzF6cciZ1X2yYl7zXZm0+ayzChsnMnByQ8EkwyCF2ATOm3y7a2lqNr7GrijHaPaE8E f96lHbMo0S5XiQ+4t5/GzUtF8qC1+h5lYug+Kv5J4G/4u5gWQMjJI2cPMVJvi1b04qvo PuL1g3TGNaQzcPmS/T3LKf+VJVah1oHP3w1JTom6p1kgHDEGvBG5xmlybSWBiChTjh37 6LMA== X-Gm-Message-State: AC+VfDx78iCT1qGClx/oEZFMgRO+Fq1pC9GlF8S8BiqU6AvZ7dL81ElD UB/a71KZlHaqs0xwThKx5OF8gw== X-Received: by 2002:a17:907:96a5:b0:988:76ed:e55e with SMTP id hd37-20020a17090796a500b0098876ede55emr21352012ejc.13.1687710539927; Sun, 25 Jun 2023 09:28:59 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ec10-20020a170906b6ca00b00982be08a9besm2277731ejb.172.2023.06.25.09.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 09:28:59 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , =?utf-8?q?Mika_Penttil=C3=A4?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Andi Shyti , Andy Shevchenko , Krzysztof Kozlowski , Andy Shevchenko Subject: [PATCH v4 20/24] Input: surface3_spi - Simplify with dev_err_probe() Date: Sun, 25 Jun 2023 18:28:13 +0200 Message-Id: <20230625162817.100397-21-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> References: <20230625162817.100397-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769692983129758035?= X-GMAIL-MSGID: =?utf-8?q?1769692983129758035?= Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/touchscreen/surface3_spi.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 31d140248f2e..7efbcd0fde4f 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -221,7 +221,6 @@ static void surface3_spi_power(struct surface3_ts_data *data, bool on) */ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) { - int error; struct device *dev; struct gpio_desc *gpiod; int i; @@ -231,15 +230,9 @@ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) /* Get the reset lines GPIO pin number */ for (i = 0; i < 2; i++) { gpiod = devm_gpiod_get_index(dev, NULL, i, GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - error = PTR_ERR(gpiod); - if (error != -EPROBE_DEFER) - dev_err(dev, - "Failed to get power GPIO %d: %d\n", - i, - error); - return error; - } + if (IS_ERR(gpiod)) + return dev_err_probe(dev, PTR_ERR(gpiod), + "Failed to get power GPIO %d\n", i); data->gpiod_rst[i] = gpiod; }