Message ID | 20230625094857.29644-5-sherry.sun@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6828089vqr; Sun, 25 Jun 2023 03:03:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7L1NFNZzImZAA0YSkwXX6fn281lT+KpoPMFlXk8RqeqFhKIwGGVvYVZfz51kwEkAiM9mh4 X-Received: by 2002:a17:90b:1b50:b0:260:cece:9358 with SMTP id nv16-20020a17090b1b5000b00260cece9358mr13788316pjb.6.1687687428935; Sun, 25 Jun 2023 03:03:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1687687428; cv=pass; d=google.com; s=arc-20160816; b=mLStkZ1r8HRKdElEWvB5jEwP/3sXUPLtXQIIos74+fgFMC2eOXcnxinCYJURCzdeND KVSla4RLvDMihJX+9yC35bIEQAVRA2mHFmU5Mfl1USEPZvFiu9j5OuEheMEMCtMxfDiQ XbtoSNEpUzPr9YAnXOAqWb8qc8jzKX2x2ItSuZ6u2lIfv20PItMVofvpC28+Q3Pk+ZPN AJheujedNwFHWL5sCxly2BXeB0pZXRkdc9EtEXbGoJpy7JBoat1FkAF9JeHVZWVsnJ0R 2cdEtb0rmIe2zK06vk36kT7DUuKjcVbEJaxvT9hTvjw4+m4vdQqdQj25b6gegkOnqEiJ lQMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=O6RjJEMGbO31IIcRVItQpnF1/zDX5vSfrAJfbPWL+Xw=; fh=UBIUw68UfeVPOQ7o+13Az5q147TvQ4jHXFhsx7/71DA=; b=kCXB0EWQTbOeL7ZHbls1ycvhYZi+Ba05rFtiV4tvK+CDXgdF1gDsoVTuYsq83vhBjh 2A2AemYAAvtq4UMe3crRj1qTlAOs7ElF5WxEbPBl2z4wvfMwyLrvQboKX2AulVhVJ3sR PbMw6ymXpYrjEtks21RLp3xZCcPQeFlbpuFY5uw2aUzQ1b68ZRjYt5aH/wU8+qSWlRUY GgYu1tPqir2k4Dzh603EyG1mQTLU4Bdxf890X5qPxYOH6Dnl86fqAd+Ct3ochDQpa8a7 wyDQ04FBaAnWJfug4ld27tXMJV0hF4xCnh0+4BY/1tneuDFSkRLhlxEoVhe0EklL1K58 19IA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=pBV65s6w; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oo4-20020a17090b1c8400b00262e629f543si899777pjb.80.2023.06.25.03.03.35; Sun, 25 Jun 2023 03:03:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=pBV65s6w; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232034AbjFYJzc (ORCPT <rfc822;duw91626@gmail.com> + 99 others); Sun, 25 Jun 2023 05:55:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbjFYJzX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 25 Jun 2023 05:55:23 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A8E710C8; Sun, 25 Jun 2023 02:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IvlavjtQzggXEUrxJM9CSYZRI1sCHBmb4jixUZnY/96nVWv+dgQTtjSrRn6eLxeJUu7fHonYs0qOYeeXt1+i1EQ9vQFcqCutsIz14KnfKxUKUhwZ3JcNpsiIo5OTkoUlq0ZQKbcPlOhujgUA8Fts113f688nYmEzmWoPlCueEYoosZ3M68y5TtDZe3nMVDc9uGxKc8q91FOY4iWISDW5oA7vmv+zPeiI16SilExSVJc1sOYvIeOb7FR4ctD8VTKeMo4Ne398m2MiOqzd0kkpyL+Hq0UCsocVORPYvLv14JGgeghE/GAz+09MJCSb5xvaGuanC4B/LuBeBn/DNzvE8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O6RjJEMGbO31IIcRVItQpnF1/zDX5vSfrAJfbPWL+Xw=; b=FGXz3D9Eindnc8GoBa4cxR5ecrQuvejkxxcAKRrch4Z+eLnRVi8j26NGupEiRVwBBFS4oUuinQXwtc2vduhL+9UmFP42fxZwUecN+rw+m9KboRukAw7MKAYStU71oaWnlULk+p5UK5unlH9H9CekVU9c4QsZw/gqTWbZvbJ83Vk+NAEB9f/ce//kb0NE4n1ynB96pu6Ql5dArYFaC/d3LqQlDKucSxesDcmyOSfQGhdBf02cTOlBZHVjF/1F7gLr9LmlbBSh0pd2WORYMJEo0bO7LZuyTJ2nC0c38Ja/SzAl02I1+qyC9GmT1fcO4TMTglZItDeLD8oTDxdbEthFZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6RjJEMGbO31IIcRVItQpnF1/zDX5vSfrAJfbPWL+Xw=; b=pBV65s6wapRER3JYT1ZsuQWH3W4nRv43YHkUb05QrCia5sEUaMrPAtlX3AFQW9DzJqhoz67ZBya//ldnrWy7385TmmNorJsewVz+Hx5k5zh+BAiLX3sM0/Svj39QiRSk5OpZwhRO1QBMstRZC44Ks5A/cTJ2J61TrirLQv7Xm60= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by PAXPR04MB8816.eurprd04.prod.outlook.com (2603:10a6:102:20f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Sun, 25 Jun 2023 09:55:01 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::ef9f:1e01:e8a:6a4a]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::ef9f:1e01:e8a:6a4a%3]) with mapi id 15.20.6521.026; Sun, 25 Jun 2023 09:55:01 +0000 From: Sherry Sun <sherry.sun@nxp.com> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, shenwei.wang@nxp.com, gregkh@linuxfoundation.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 4/4] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Date: Sun, 25 Jun 2023 17:48:57 +0800 Message-Id: <20230625094857.29644-5-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230625094857.29644-1-sherry.sun@nxp.com> References: <20230625094857.29644-1-sherry.sun@nxp.com> Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0126.apcprd02.prod.outlook.com (2603:1096:4:188::11) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|PAXPR04MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a8ebd61-6d64-4cbf-a791-08db75623dea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZRvkmBxDvASXuA0eWDih3vspR50rA+UcuQFrGzfu8F0fvY5oIVKjziPUeTRwkrxewi/LIY6wE4sZMi1LDacztKPm9r8jxGkiemUTW3SMy4PlAUbZOE3xVi86Q0k2fAS8YfCO/iQ79ClHvzdopHVcxKHdd5PpgiKCyEoGKCqP5qzpPXSZyCu/op5cZbbqbiCoey1bxSmYUIQDo7/NTu1wU7iYZ2xnDUClCamOOHGebA7Spl8uC1IIOY+s3OMJ1DYcr6cSyLGaZnGQv6Cz4y9HXJF/gX3VwF8X8cFULZzswtAdfXL27S2jrNtRobUjrL8KjVTh4JXLDu+IgeFwXZny9IRTBybbaJVuuJBS7Hjlo6ETLBjZU3QPpdq8UJT3/6w773o75pNwnrnXIwrMUTDvo6/dGEWOSNgOTEs77Z62Pr//Znvhkf8kja3lGvtv+oEG6xz3XKqGCktoiaa06xXjhqfF7194HenmGODk8Q6WiDZeK0eEphc2ThBgvf1xFSbYV7liBfhIGMd91mxOzU67sMVwOg2ACJyGB79e9rUTcliA+GQe3SotQQGCV/jA9uxW6S6e7lPYU9p1gXrjq48Q0MsDT+t5/8D3uSldpdqn/vx+a6WaNIEYhRmZ0OTw+uNuzuut4RELl1Nnt+tl0PWyLw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199021)(26005)(36756003)(5660300002)(7416002)(44832011)(66476007)(8936002)(8676002)(41300700001)(86362001)(316002)(66556008)(4326008)(38350700002)(38100700002)(66946007)(6506007)(1076003)(4744005)(6512007)(2906002)(6486002)(186003)(52116002)(6666004)(83380400001)(478600001)(2616005)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: B8Dpvua05TDrteIyUarBt0hi5OZjN9Q0J+FoBG9ADCLNRWe14Q3EnCy+D47/uH1Jg6bh3jitooxcJpZrvyFmUO0wROgvtdb5AaAEbzL3snGbhxcJRmbptZ+lMHvojkCW/XlL9XVmOv9imtPDDs/2N4MxvgomwN8ZemZnKQSdkcKIlDUN5FgCpnY0dreKYVScZ17Dmh1FUsR3PLKSuxxOfWyX2HMPS7lL2WHTGeTgv5bIZJn5EjMh6x/+lKp3BjH8n7EeY7PTUexrYsMujzPyXWlrK1X6HADSXJokpl5FWuXF8aBb5EiSDa6wAQhD3N0d9oNHMjTD2aoZ4bRp0dmpZL92UrkwNs7BRs8arNgvooB06GGhSLbX0qPZkEa5PGPUQSNk7QDuKsNJQF7nniwRjnvJ/YmIIe3o4PSqefcdVWzSCxc/XGyF/v9vVgN14PGN328byuSJxMw8GFAWerAGWkYKRGXj5qCm61aoJznKh4vOA7wQvCb8s3IQm8AWtAOtm1k2QQ4l6MKdGzMigDlecdn5e8nLhwDBlQqx+e6YF0F5T6ogy/q1xRFblIFsz0SI4DGp2BnqUPeLvIPJwVJ5a7+rb4a9Ad++dx960vH3wHC0lhnsbddbrLTnPi8OV3GWmd5a6yhCKF1S+EtUQgqCC8bjP5Jm3f6bIXfz/fe1A9CBNmnn1ybpLialVilAmB9myzPdmd5TJyf6MrytDynbSD5m5FMjKOYCRznzISp8UI81ANiV2I4W4xhZ8x++hO+SWnZBMR9w/Ac7+YcLO+NL9yVRJoAE27rMuI16DVSj4gSCI22o7X0dW8Qijpbm/VoOT3nBr4DZ68qSo3shEERXpgvxKknJlTB45CgKa0kyPun6YAYF6vGSSNMs38vMZdhS+XPO+jdkn204fEPS+RoUuV4pHmpJrU0H0EyAPiRUK8oyUXPVjAS2oN2VOa3jSPey5BCz35Q5pusjk4N/pqxX9Ubx0pNKQHUat2tj0RQA1MatdyebnOpeUaSSBQQxK2zWUXwt/zvByLqAKeveu9Vz40VNEeqnqnKY9QYmfFbzTCF4408NAuSx7JHJ3A76gVWAY4JG+yMflktsElCH7Y1PrAsATZeu7Ng//W6EVqTDecAQ1TOLWfwzZUwIswXs6E1J2j8Al73zd7cEXoXAvDWgJFDXpU5OMjzt4fObvGxMuXqUeOSvv8pBxBrzJcTJ/uFPP3tcNY4gyLWUE+eOqh7MI9fiv0oWh+fxZODtWQXbGOxwgkuQud2oJ5p6IJio0+wAapZPl03kr0GA3CwybwiPJtHX+QFQkSDVQ1LB4IScT+7sJXaLVV4hyPNma3cf1wPF31q8KTVZuT8gpMPKGqWCyJaS+YMPs8Ee8MHmV28RFgHMjfd7UA73hwJDRMHIQn8FQ7/m8gRCjOsWV6l+OY+hsH0Wtg8SUbz7EQZPaoZsuCWihK4XS+alwp+ymxovEGOFxvhKCN716WZUAXz/UiBzQxSeOtY/LnJLLcIzys/ulrdiVEasCOnGC31rvwfiWyz/oRBvxik/P9gpMPTyXlJhoO2bNtfcYx31vKxyb4ByMqCJKJMySiwVgwQ2ou5TtQTI X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a8ebd61-6d64-4cbf-a791-08db75623dea X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 09:55:01.1928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YSspO0mV34hy0KZht3FDfy+kMs5Zk6BDZ5JEl5ukDQDRusK1/HxwbJPvZxRKj49ZHL6cUgQ5E8FZRorQ91v6VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8816 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769668533294618172?= X-GMAIL-MSGID: =?utf-8?q?1769668533294618172?= |
Series |
correct the lpuart compatible for imx8dxl/imx8ulp/imx93
|
|
Commit Message
Sherry Sun
June 25, 2023, 9:48 a.m. UTC
LPUART driver adds a new compatible string for imx8ulp, and imx93 is
much more compatible with imx8ulp than imx7ulp, so correct the
dt-binding here.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
Comments
On 25/06/2023 11:48, Sherry Sun wrote: > LPUART driver adds a new compatible string for imx8ulp, and imx93 is What driver adds or not, is not really correct argument for compatibility. There are plenty of compatible devices which have both device ID entries in the driver. Why would you drop their compatibility between each other? It does not work like that... Provide clear rationale for this. > much more compatible with imx8ulp than imx7ulp, so correct the > dt-binding here. > "Much more compatible" is too vague. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2023年6月25日 18:18 > To: Sherry Sun <sherry.sun@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com; > Shenwei Wang <shenwei.wang@nxp.com>; gregkh@linuxfoundation.org > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > kernel@pengutronix.de; linux-serial@vger.kernel.org; linux- > kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] dt-bindings: serial: fsl-lpuart: add imx8ulp > compatible string > > On 25/06/2023 11:48, Sherry Sun wrote: > > LPUART driver adds a new compatible string for imx8ulp, and imx93 is > > What driver adds or not, is not really correct argument for compatibility. > There are plenty of compatible devices which have both device ID entries in > the driver. Why would you drop their compatibility between each other? It > does not work like that... Provide clear rationale for this. Hi Krzysztof, We take imx7ulp lpuart as the basic version IP, then imx8ulp adds some improved features based on the imx7ulp lpuart IP. Actually imx8ulp can also work with the imx7ulp version, we can say it is compatible with imx7ulp, but we need to enable those new features by default on imx8ulp, so we added the imx8ulp-lpuart compatible in lpuart driver. So for this case, maybe compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart" is correct for imx8ulp platform, right? Then we have the imx93 family with the same lpuart version as imx8ulp, so how should we handle the compatible string for imx93 platform? Maybe compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"? But three compatible strings looks too long for me, so I want to drop imx7ulp-lpuart and take imx8ulp-lpuart as the basic compatible string for imx93 and later others imx9 series, I am not sure if it is suitable, some suggestions here will be appreciate, thanks! Best Regards Sherry > > > much more compatible with imx8ulp than imx7ulp, so correct the > > dt-binding here. > > > > "Much more compatible" is too vague. > > > Best regards, > Krzysztof
On 25/06/2023 15:12, Sherry Sun wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年6月25日 18:18 >> To: Sherry Sun <sherry.sun@nxp.com>; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com; >> Shenwei Wang <shenwei.wang@nxp.com>; gregkh@linuxfoundation.org >> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> kernel@pengutronix.de; linux-serial@vger.kernel.org; linux- >> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> >> Subject: Re: [PATCH 4/4] dt-bindings: serial: fsl-lpuart: add imx8ulp >> compatible string >> >> On 25/06/2023 11:48, Sherry Sun wrote: >>> LPUART driver adds a new compatible string for imx8ulp, and imx93 is >> >> What driver adds or not, is not really correct argument for compatibility. >> There are plenty of compatible devices which have both device ID entries in >> the driver. Why would you drop their compatibility between each other? It >> does not work like that... Provide clear rationale for this. > > Hi Krzysztof, > We take imx7ulp lpuart as the basic version IP, then imx8ulp adds some improved features based on the imx7ulp lpuart IP. > Actually imx8ulp can also work with the imx7ulp version, we can say it is compatible with imx7ulp, but we need to enable those new features by default on imx8ulp, so we added the imx8ulp-lpuart compatible in lpuart driver. So for this case, maybe compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart" is correct for imx8ulp platform, right? > > Then we have the imx93 family with the same lpuart version as imx8ulp, so how should we handle the compatible string for imx93 platform? Maybe compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"? But three compatible strings looks too long for me, so I want to drop imx7ulp-lpuart and take imx8ulp-lpuart as the basic compatible string for imx93 and later others imx9 series, I am not sure if it is suitable, some suggestions here will be appreciate, thanks! > Wrap your responses. So write that the reason of this change is because looks too long for you and we will judge that rationale. Three compatibles is still fine. Best regards, Krzysztof
> >> > >> On 25/06/2023 11:48, Sherry Sun wrote: > >>> LPUART driver adds a new compatible string for imx8ulp, and imx93 is > >> > >> What driver adds or not, is not really correct argument for compatibility. > >> There are plenty of compatible devices which have both device ID > >> entries in the driver. Why would you drop their compatibility between > >> each other? It does not work like that... Provide clear rationale for this. > > > > Hi Krzysztof, > > We take imx7ulp lpuart as the basic version IP, then imx8ulp adds some > improved features based on the imx7ulp lpuart IP. > > Actually imx8ulp can also work with the imx7ulp version, we can say it is > compatible with imx7ulp, but we need to enable those new features by > default on imx8ulp, so we added the imx8ulp-lpuart compatible in lpuart > driver. So for this case, maybe compatible = "fsl,imx8ulp-lpuart", > "fsl,imx7ulp-lpuart" is correct for imx8ulp platform, right? > > > > Then we have the imx93 family with the same lpuart version as imx8ulp, so > how should we handle the compatible string for imx93 platform? Maybe > compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"? > But three compatible strings looks too long for me, so I want to drop > imx7ulp-lpuart and take imx8ulp-lpuart as the basic compatible string for > imx93 and later others imx9 series, I am not sure if it is suitable, some > suggestions here will be appreciate, thanks! > > > > Wrap your responses. > > So write that the reason of this change is because looks too long for you and > we will judge that rationale. Three compatibles is still fine. > Hi Krzysztof, Got it, thanks for your suggestion, I will use three compatibles for imx93. Best Regards Sherry
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml index 93062403276b..5599be95400b 100644 --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml @@ -21,13 +21,12 @@ properties: - fsl,ls1021a-lpuart - fsl,ls1028a-lpuart - fsl,imx7ulp-lpuart + - fsl,imx8ulp-lpuart - fsl,imx8qxp-lpuart - fsl,imxrt1050-lpuart - items: - - enum: - - fsl,imx93-lpuart - - fsl,imx8ulp-lpuart - - const: fsl,imx7ulp-lpuart + - const: fsl,imx93-lpuart + - const: fsl,imx8ulp-lpuart - items: - enum: - fsl,imx8qm-lpuart