Message ID | 20230625094857.29644-3-sherry.sun@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6825578vqr; Sun, 25 Jun 2023 02:57:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xM+rys/fTHD3OH5HHPbF9DO6WkdBSJPg6aXgBGbaL8nxobjwWmlsnit/gyHpbCgfm7ZVd X-Received: by 2002:a05:6358:a5d:b0:130:faea:a80c with SMTP id 29-20020a0563580a5d00b00130faeaa80cmr12494587rwb.32.1687687052880; Sun, 25 Jun 2023 02:57:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1687687052; cv=pass; d=google.com; s=arc-20160816; b=rAJH/mTMAbeGHZpzs69myaOofxNK8UAO3rWv2p9MPZDCKrdxLkDFQyDJjmDczbKdwk IYbWkbbuOEgJR3vp09Op5O5IaQQC9c4gEcBhGgtNeIGH3eNV+FyXYVpjAoNJe/K2aKgo RSaoYa7KRQGYecQWJ/LSU/HKFuQ917xywI36stuL9ogK2pl0tYRDiP0lEhGO8Zl5xM+c 1crmDWoE7fiDsk/ZWxKZGFBk3NP6RuXrv4oQivm2E//9Jx1AqSr/s1guKByugVqb6/y+ 7qaOvEkWMJmNTA8gmXAvKwB7Or1+3qSMEeAwENyTDeQBVcLt2rYqfYhTIaAd+WScIbZI zoPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=kbmIoFm8sONkYeYQKStBZ0/Jtz8C6dB8d2q+QwxKw60=; fh=UBIUw68UfeVPOQ7o+13Az5q147TvQ4jHXFhsx7/71DA=; b=rUw5+jWvMPPjyFkWda/E+hdg2XYIxdXEM7Ywj36ajEHp5vF2XNXlfplEf7E1yx926B Lsp+G1bkgtngib63FDw+RZiEvJPUi8dYfveb9HeY+b10rJYGnyF/AcRO1PgIx3OOm4oe LJspeFdrz1PWCbyzUNxnH7hNlRH4SsLKJlVVF+P/56jI13y7L4zGKU+2Gn0bF9ugkyvs kzKr6twSC9HwMD567Y8CfRn9ja9joF0ZJxJbRfVYBrM6MXJSHujwk+fq3pKKrVCgQ/ak lhQoFoonj2m1pWTSAjCZeue3l03h9f33ZsM2ldcbhXA5CYoSPKaVMST7BB4piWKPOEK2 inYA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=ATqxLvlH; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 1-20020a630b01000000b00553e8d95744si3074469pgl.94.2023.06.25.02.57.21; Sun, 25 Jun 2023 02:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=ATqxLvlH; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232017AbjFYJzF (ORCPT <rfc822;duw91626@gmail.com> + 99 others); Sun, 25 Jun 2023 05:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231967AbjFYJy4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 25 Jun 2023 05:54:56 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5949310C4; Sun, 25 Jun 2023 02:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkwWDy3wXme5vEthZRzw2BzABoQPln/jh9WPJeIHW4yWuqMxroGYwEueGGAyDWGGoqiM7JVPGAlo7K2KyEmTAmHYUXkchWmSUg6p9qOpYluScl9ldb0qDAdtq3QDX21OwzI85xQLV80gVV87C7Qn2V2F0KveMXUcdXNLduO7PqKbvErvtyeqh5WYUd32SxeYYXrFxAatOlFysWuUml/We1X0isAT9tCzx6k2+hFRR0MShDhEn/sf8e19zZGLQ1ErPrk40C/UrKk0j4VfYMOhEzbG8G/3UYI3PYzHHEAfOxAaKhLL9hvAnz+iwgpCCg3Ln6KG8n8xAZuTshj4WdwaQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbmIoFm8sONkYeYQKStBZ0/Jtz8C6dB8d2q+QwxKw60=; b=DPWChgc3Z+fU4zkasko1ZsOcWYm1BS3/Sfg8ZMtKsCb5Z51exExQvDlXohvckYqNqd7nDZ6lKNaiFrqgv+cRo/xgvJH+mUxKxDEN0ul1fEmvHA9Ir9ANt/WJLI1fzZFZ5EtBaadMqYRMN9b51UGZvHqX/qqa9AeOeSgYlbeRBDeE26bFxuTGTzB3oIU9KUSxGaL4TyNvEQMuSn6q/S8S//xZOwTwDyJ1zkW1KUmAsncesFg8miZHi22K5hA7SCeL+3E1/eFYHGGNzam6ZZkCuhvdk8e2LYOliUERvCxvAUih/S3YU+xfi3Slu9XczXjfwaygeaiUxVmQu14ZdTUgUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kbmIoFm8sONkYeYQKStBZ0/Jtz8C6dB8d2q+QwxKw60=; b=ATqxLvlHvso+DbJfr/pLPPxTZuobDm+HoM7ahLYQMomj6PAmVePRhYSdLfUimxoJkXYcV3Ls94+zkgFLOITCOGGnFQhF7V3lqKw+5xKGhhParte3tzObRnbS4zlGADqVpLK3tPWLnHsgYKRXs/h2M6pz2Dvb37Ccmz1WrYZ3P/w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by PAXPR04MB8816.eurprd04.prod.outlook.com (2603:10a6:102:20f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Sun, 25 Jun 2023 09:54:50 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::ef9f:1e01:e8a:6a4a]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::ef9f:1e01:e8a:6a4a%3]) with mapi id 15.20.6521.026; Sun, 25 Jun 2023 09:54:50 +0000 From: Sherry Sun <sherry.sun@nxp.com> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, shenwei.wang@nxp.com, gregkh@linuxfoundation.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 2/4] arm64: dts: imx8ulp: remove "fsl,imx7ulp-lpuart" compatible for i.MX8ULP Date: Sun, 25 Jun 2023 17:48:55 +0800 Message-Id: <20230625094857.29644-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230625094857.29644-1-sherry.sun@nxp.com> References: <20230625094857.29644-1-sherry.sun@nxp.com> Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0126.apcprd02.prod.outlook.com (2603:1096:4:188::11) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|PAXPR04MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: 3401b1db-765e-458f-7801-08db756237cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1sM/W//tyHUt88vUAp1QdZongAmfjM0xWJwmmQd1rkDokS87gnXnZfSYZ+JKURKPOcBTKbAM8YpQqbd0tGAWgKDYqRiPPSPfwGvn8f8rB9f01yLr1WvyGZI0chvyuEdOOwLw2C7Kd7dGx+35ycgFo7V58b9ecXxIY8n+/rt9j8MIYU68AREznF3BnRfqOTqqrSvY6rmTiBmzC6jsLoM3EfoeS9FdsFpF4qkRyJNa9SXN6Qfmw2zfMv48jZoYxsJdUXtU5GYylSZdLKtPI3odqsvIVSXXiu99ctH1Q8rtWYRufTZPvMReX3kOVTmgmXD9cWX4ykqf0I7BkZJm/ApIvEU9nTpYOsW01oaBHYBswieEa2zgOQ3kLAg8W05LRz70YtpGZvozNCDbG2EmBmdvmvu5wP4Ff6IF0GkL8lRDt+BHPj/l51ee+tEoL9V50hPWXvOXUR9f9VYb0ABHG3dawD5IiM5Yt0yhbJvwWtwfsVrEX/GTN5gTvEC3POk3E8KBNMJWqxMcfwIydDWN2rmKI9eFBHMxHQ+mT79kfcDhXCXmXoiL27oPMYMrAW3g6K5u0oKJginFUJws0hBeUN8GCpdrAcinjb6PWeFgt1gHICugUOVf/U7vlmYH4pnonCOjum83n5erLBGWcVHdzaMzPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199021)(26005)(36756003)(5660300002)(7416002)(44832011)(66476007)(8936002)(8676002)(41300700001)(86362001)(316002)(66556008)(4326008)(38350700002)(38100700002)(66946007)(6506007)(1076003)(6512007)(2906002)(6486002)(186003)(52116002)(83380400001)(478600001)(2616005)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Sphm2HsO9PB+kFoN5v1GAx+sP0PSJJn2uLwosdLX1NlfIgplhQNhoFzZePqDRvrgAWfwTlXFNooFOUhxXyeSsY4baUudCxbPsSAejR8XoCjHsPS4IyH7HBAiYn9f3uMHuMg0JrcGiCoBbpp3RxuTuzbYLMubmeOnBnjUOHcKxaSLUwoWhnlkBuxQ0/naIb0HSYdlw2SmO7R+wu9jfo6tQqVhLbADnd3yyfNrMvvDjzmjHvwIAl7dqSTDKWN/fRggWSDS+VTFewuxfkOYttTcGPd+zsDV+hvzGfCUL3uXKxe9//iddfM31NN4tJi4rwEaofVO8NQgXBKYRrdrZhz+X6cUwOg6+BrFXuUFKa02YbK6bhwrzyCdaOWkB8c5hsncC3jPZYzTkdccPXgGFtDwcElH8eBkfxrCM6QHB/cUDjwRkZXM69I53HwCBdl1jxLBvtWW4w5c9Ioe1eFIAy0e//H9WsRwIevHQaww8fm7pF8v5Io/ftjgTKG76hiXMEUrxdly+WPoRb+07gWct8MBnahBtp8qrDnrhYwQ7mmOqwjeNV4tkuewZ50mbkjd3XMJW+R4GNiNXVgJKodvuHCGBLa6S5NvK/IALa4Ewlg/cGmSkczwujBhBbYj659HG1BOP/OaZGgggqDSwPX+oFiERcbIZhjUnmqReTutpLixBuszBvWQs6PQClEr7/pCbMXMmP+oaUg8zaF5a51+KJW2hCd8DxbdvidbP4N8ZY5+qMXlESZA97jY+Jq+zOf1ANxldU+R6ZXMLIF68eteHVvCVHxp/abNH6Fk9LbmIuXcQde0ab3CKD5AuwDlZjcrXe+WIFGj211ppKrB+rKPP0BIe/vLkR+tVaIr6u49BTK+gyI3uojn3lh01y4+3eDc27oE8hKKvNF/4XZ1ZGhmUwstkKQK2cXAVBFRLDsaExXOZpllylXDiuU24ofHMwuzZZuHc87ANvd5gl63ZHEtX9L9tyOB+CVhHZPPMUBp4aj8gXi/F7ySiuEcRizNSEpV2tTUgvIdI28zpsiXtn8Ys/5Hv6CqHirldK+I4oH+TbVy5sUXxyneNuJTdS6ijmd7tMeRC/rdH0G3vcB/09Y3CeAxL8QbtBwXwDDiF9hYsLqpaPnjR0GnQrjwtLm06sO/ywMMXoOBv8t5KoO8BVtmjji3vCFOB66zZtEfMn95NBSqfJWxdmIiBkG64TSZr/fiCMejHPJ6+YGKzjlq6g1Qy8Ekpn0O8yirtlvsgaFpSA0WaG7fdzq770hEBbZB0Q1bmQi4JpGongwinVosro3ckOELz+xhpsUrjO75lV2WKwuKmmWHgKN710IKtlDuWCGpxnT8pi+MGm8OQzv0RX/BwD8BF2BLLXBtfPqpZ/a5zLXoGm253XmBf8UAoyw0Pm/2qwF42npJqPKyEk6NoAcT3F3/2IUa3kJmt4KLZYecHd8E4Z1MfmYFnsKUDlzgDh2fGeKEPGrv4idnEIr4bApJcMLTXlAShkQnPLawKhObyMqqavlCdx+FAL5RJ/bWYmXzQRHP24RH9hHqYJsp/YUSTuQOeKAvKaGlXdrFEu/Yr6IKV7hNHiMYjgY/yecP24jsm95+ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3401b1db-765e-458f-7801-08db756237cc X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 09:54:50.8119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLZJo22AS0GRqK1cGvqTUYpLiM1ljluX23n0kXNRt1crIqoFE3Adg2lt4CCZhxCepDWO6lCNU3fZDgTT+KnOgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8816 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769668139286015310?= X-GMAIL-MSGID: =?utf-8?q?1769668139286015310?= |
Series |
correct the lpuart compatible for imx8dxl/imx8ulp/imx93
|
|
Commit Message
Sherry Sun
June 25, 2023, 9:48 a.m. UTC
i.MX8ULP has specific "fsl,imx8ulp-lpuart" compatible in lpuart driver,
"fsl,imx7ulp-lpuart" compatible is no longer needed, and i.MX8ULP is not
fully compatible with i.MX7ULP, for example, i.MX8ulp can support
EOP(end-of-packet) function while i.MX7ulp doesn't, so remove
"fsl,imx7ulp-lpuart" compatible.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On 25/06/2023 11:48, Sherry Sun wrote: > i.MX8ULP has specific "fsl,imx8ulp-lpuart" compatible in lpuart driver, > "fsl,imx7ulp-lpuart" compatible is no longer needed, and i.MX8ULP is not > fully compatible with i.MX7ULP, for example, i.MX8ulp can support > EOP(end-of-packet) function while i.MX7ulp doesn't, so remove > "fsl,imx7ulp-lpuart" compatible. That's not how compatibility works. Your commit msg says that new device comes with new features, but your code says they are incompatible. These are two different things. Either drop the patch or provide correct rationale. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi index 57627bdaa851..e900f5b25694 100644 --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi @@ -245,7 +245,7 @@ }; lpuart4: serial@29390000 { - compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"; + compatible = "fsl,imx8ulp-lpuart"; reg = <0x29390000 0x1000>; interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; clocks = <&pcc3 IMX8ULP_CLK_LPUART4>; @@ -254,7 +254,7 @@ }; lpuart5: serial@293a0000 { - compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"; + compatible = "fsl,imx8ulp-lpuart"; reg = <0x293a0000 0x1000>; interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; clocks = <&pcc3 IMX8ULP_CLK_LPUART5>; @@ -334,7 +334,7 @@ }; lpuart6: serial@29860000 { - compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"; + compatible = "fsl,imx8ulp-lpuart"; reg = <0x29860000 0x1000>; interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>; clocks = <&pcc4 IMX8ULP_CLK_LPUART6>; @@ -343,7 +343,7 @@ }; lpuart7: serial@29870000 { - compatible = "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart"; + compatible = "fsl,imx8ulp-lpuart"; reg = <0x29870000 0x1000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; clocks = <&pcc4 IMX8ULP_CLK_LPUART7>;